From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19939C43219 for ; Fri, 3 May 2019 08:04:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D604920675 for ; Fri, 3 May 2019 08:04:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="TFsaDfJk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726149AbfECIEL (ORCPT ); Fri, 3 May 2019 04:04:11 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:44540 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725775AbfECIEL (ORCPT ); Fri, 3 May 2019 04:04:11 -0400 Received: by mail-qt1-f194.google.com with SMTP id a26so3380544qtp.11 for ; Fri, 03 May 2019 01:04:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QyYnh8hGNxo4y79JyoBAvnyJOsqV/eKCHgC2055Dj70=; b=TFsaDfJktcepJhaSVkSy9jmcH5WklitGZ2BBIrKTkDmfye484EI32NBvqAF18RhDM4 icz2jBCDxSTj6qmQVp0LN0YlkJPVgxnXUunfIEesZ1FOAC5727DnzDgNJ++yI7ZM9nil K47/JWKZTYl0cyTlCD15zHWhm1WvSpjJECOdY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QyYnh8hGNxo4y79JyoBAvnyJOsqV/eKCHgC2055Dj70=; b=QBzj9/99avVfKtgQqQpqrtQeAf0mU4XUverxJcb343JgQw87q1vmaplo0B97186WRM lkNFMlkM8M8YE9M/63RXifsTC6NFtojPnZ6s9Ii+5HN8HvyO183mOE6loaG62nBBC8H+ WmTZDd6x1EBfCR1rqIEPHCJqv5I0kXZVJV7NuGdw9BxGi4qcs7kED1SWF06U45nuXaFw qtX3SWebFW3LK3LOJFQMLIU64olaG6UZFvn6kBkvD0AUrnBZ3KulKO2HpAF8UmWmfF1M 8KNzhj0KO0K1FeZh/ZwkMYo70Y10niqWj6r16FPLDweZpflozzvBtexo2vtIVGiizUEr KtRQ== X-Gm-Message-State: APjAAAWGueto4SP23lELRaaYjjIcM5w7z4D81QYM3Y++gYGisQInjz1l vro6SCmzAX8hK7Emz+Bai1WTjjRHQsVmeXKv9G8OAw== X-Google-Smtp-Source: APXvYqwK9NYfQA/9uIkz+E3ZSXoSVmvGacXxJP1bm9lZj8RtDGEHaMjRHL1WIrVFMhk5ZLbA20X7lzzIyVAj/Hr6Db0= X-Received: by 2002:ac8:3822:: with SMTP id q31mr7331051qtb.0.1556870649914; Fri, 03 May 2019 01:04:09 -0700 (PDT) MIME-Version: 1.0 References: <1556793795-25204-1-git-send-email-michael.kao@mediatek.com> <1556793795-25204-2-git-send-email-michael.kao@mediatek.com> In-Reply-To: <1556793795-25204-2-git-send-email-michael.kao@mediatek.com> From: Hsin-Yi Wang Date: Fri, 3 May 2019 16:03:58 +0800 Message-ID: Subject: Re: [PATCH 1/8] arm64: dts: mt8183: add thermal zone node To: "michael.kao" Cc: fan.chen@mediatek.com, jamesjj.liao@mediatek.com, dawei.chien@mediatek.com, louis.yu@mediatek.com, roger.lu@mediatek.com, Zhang Rui , Eduardo Valentin , Daniel Lezcano , Rob Herring , Mark Rutland , Matthias Brugger , devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 2, 2019 at 10:43 AM michael.kao wrote: > > Add thermal zone node to Mediatek MT8183 dts file. > > Signed-off-by: Michael Kao > --- > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 64 ++++++++++++++++++++++++++++++++ > 1 file changed, 64 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > index 926df75..b92116f 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > @@ -334,6 +334,67 @@ > status = "disabled"; > }; > > + thermal: thermal@1100b000 { > + #thermal-sensor-cells = <1>; > + compatible = "mediatek,mt8183-thermal"; > + reg = <0 0x1100b000 0 0x1000>; > + interrupts = <0 76 IRQ_TYPE_LEVEL_LOW>; > + clocks = <&infracfg CLK_INFRA_THERM>, > + <&infracfg CLK_INFRA_AUXADC>; > + clock-names = "therm", "auxadc"; > + resets = <&infracfg MT8183_INFRACFG_AO_THERM_SW_RST>; > + mediatek,auxadc = <&auxadc>; > + mediatek,apmixedsys = <&apmixedsys>; > + mediatek,hw-reset-temp = <117000>; > + nvmem-cells = <&thermal_calibration>; > + nvmem-cell-names = "calibration-data"; > + }; > + > + thermal-zones { > + cpu_thermal: cpu_thermal { > + polling-delay-passive = <1000>; > + polling-delay = <1000>; > + > + thermal-sensors = <&thermal 0>; > + sustainable-power = <1500>; > + }; > + > + tzts1: tzts1 { > + polling-delay-passive = <1000>; > + polling-delay = <1000>; > + thermal-sensors = <&thermal 1>; Is sustainable-power required for tzts? Though it's an optional property, kernel would have warning: [ 0.631556] thermal thermal_zone1: power_allocator: sustainable_power will be estimated [ 0.639586] thermal thermal_zone2: power_allocator: sustainable_power will be estimated [ 0.647611] thermal thermal_zone3: power_allocator: sustainable_power will be estimated [ 0.655635] thermal thermal_zone4: power_allocator: sustainable_power will be estimated [ 0.663658] thermal thermal_zone5: power_allocator: sustainable_power will be estimated if no sustainable-power assigned. > + }; > + > + tzts2: tzts2 { > + polling-delay-passive = <1000>; > + polling-delay = <1000>; > + thermal-sensors = <&thermal 2>; > + }; > + > + tzts3: tzts3 { > + polling-delay-passive = <1000>; > + polling-delay = <1000>; > + thermal-sensors = <&thermal 3>; > + }; > + > + tzts4: tzts4 { > + polling-delay-passive = <1000>; > + polling-delay = <1000>; > + thermal-sensors = <&thermal 4>; > + }; > + > + tzts5: tzts5 { > + polling-delay-passive = <1000>; > + polling-delay = <1000>; > + thermal-sensors = <&thermal 5>; > + }; > + > + tztsABB: tztsABB { > + polling-delay-passive = <1000>; > + polling-delay = <1000>; > + thermal-sensors = <&thermal 6>; > + }; > + }; > audiosys: syscon@11220000 { > compatible = "mediatek,mt8183-audiosys", "syscon"; > reg = <0 0x11220000 0 0x1000>; > @@ -368,6 +429,9 @@ > compatible = "mediatek,mt8183-efuse", > "mediatek,efuse"; > reg = <0 0x11f10000 0 0x1000>; > + thermal_calibration: calib@180 { > + reg = <0x180 0xc>; > + }; > }; > > mfgcfg: syscon@13000000 { From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29FCFC43219 for ; Fri, 3 May 2019 08:04:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF8DE2087F for ; Fri, 3 May 2019 08:04:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XaDCEIMs"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="TFsaDfJk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF8DE2087F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Umm8a/XBQHbepLouSCC0/lbbeVeSNP+d2X4/C9mLngo=; b=XaDCEIMsA/BJwi ctV15Pdr4mKGNQVrqEIjyO5GOtf463syK/vHbFs3gNhYzR0/YaF/HEzzihQvkHiPcXMK1zIjhxD0O YO7z120kFOagct3BDUV7N0QuLfNnLBeFYN/tEU3kXGGY8wXlzJvV7jUAU/cx1OFoAhk3ZQup2+xe6 YlYz+4ko150kDPKdGfFr1lv/o23aOc68r9wlOJj0QKTR1mvfRzF627RFoanJQu71zqRdA9AImaUxT ikOiXtSbWR4lEXhwhgIt0g7rYoXW82p9ikRhjpL8vbskCco7W6BrNgRSVm6LZf3ql19SAQi0ZFXiw AiomUtXuhRSslYB+b+zA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hMTB1-0003YS-Kv; Fri, 03 May 2019 08:04:15 +0000 Received: from mail-qt1-x843.google.com ([2607:f8b0:4864:20::843]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hMTAx-0003XD-CR for linux-arm-kernel@lists.infradead.org; Fri, 03 May 2019 08:04:13 +0000 Received: by mail-qt1-x843.google.com with SMTP id j6so5752822qtq.1 for ; Fri, 03 May 2019 01:04:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QyYnh8hGNxo4y79JyoBAvnyJOsqV/eKCHgC2055Dj70=; b=TFsaDfJktcepJhaSVkSy9jmcH5WklitGZ2BBIrKTkDmfye484EI32NBvqAF18RhDM4 icz2jBCDxSTj6qmQVp0LN0YlkJPVgxnXUunfIEesZ1FOAC5727DnzDgNJ++yI7ZM9nil K47/JWKZTYl0cyTlCD15zHWhm1WvSpjJECOdY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QyYnh8hGNxo4y79JyoBAvnyJOsqV/eKCHgC2055Dj70=; b=pQIWQvv5oXNkVEjovZisw8n86RSunA6stbkodI0rJ6fOY5yth4SVG3EdZyg810f8dw axPoLPTdKT8gN6Sr13jkLFudkAeGhpbV80UFNgyqS9FCz5sJw/TafT5yQ6xOJ27KRxyS E5lOuHKz68b3T9g+Lq3oe4ae4G3qrlyy2VG0NP1YeWRHhwI/ilsbeOQW5aKhVcXqEBVP TpJneMgr5WWkTsvlTxSE3d1rziYd3p4Pxk4CMOvNWErY7b2KeKUS/GmHSM+8TV6BJIdU pTPh9Si0rU87k5i2VEyzjCzLUg2D5+e5ZtAdGLEifhMFygLEJnbMcgSk75ERn3n74nBx V5Bg== X-Gm-Message-State: APjAAAULBaRa7KjrTppSmMwxCz8VbLJo+8Xeuml9b7nl5/6Vpm6FdqJX B8I8ldWhYhvgyE45d0T6vD6UIvt5NN58A4wb0m9r7w== X-Google-Smtp-Source: APXvYqwK9NYfQA/9uIkz+E3ZSXoSVmvGacXxJP1bm9lZj8RtDGEHaMjRHL1WIrVFMhk5ZLbA20X7lzzIyVAj/Hr6Db0= X-Received: by 2002:ac8:3822:: with SMTP id q31mr7331051qtb.0.1556870649914; Fri, 03 May 2019 01:04:09 -0700 (PDT) MIME-Version: 1.0 References: <1556793795-25204-1-git-send-email-michael.kao@mediatek.com> <1556793795-25204-2-git-send-email-michael.kao@mediatek.com> In-Reply-To: <1556793795-25204-2-git-send-email-michael.kao@mediatek.com> From: Hsin-Yi Wang Date: Fri, 3 May 2019 16:03:58 +0800 Message-ID: Subject: Re: [PATCH 1/8] arm64: dts: mt8183: add thermal zone node To: "michael.kao" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190503_010411_452124_0E75A99D X-CRM114-Status: GOOD ( 13.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , jamesjj.liao@mediatek.com, devicetree@vger.kernel.org, louis.yu@mediatek.com, dawei.chien@mediatek.com, linux-pm@vger.kernel.org, Daniel Lezcano , roger.lu@mediatek.com, linux-kernel@vger.kernel.org, Eduardo Valentin , fan.chen@mediatek.com, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , Zhang Rui , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 2, 2019 at 10:43 AM michael.kao wrote: > > Add thermal zone node to Mediatek MT8183 dts file. > > Signed-off-by: Michael Kao > --- > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 64 ++++++++++++++++++++++++++++++++ > 1 file changed, 64 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > index 926df75..b92116f 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > @@ -334,6 +334,67 @@ > status = "disabled"; > }; > > + thermal: thermal@1100b000 { > + #thermal-sensor-cells = <1>; > + compatible = "mediatek,mt8183-thermal"; > + reg = <0 0x1100b000 0 0x1000>; > + interrupts = <0 76 IRQ_TYPE_LEVEL_LOW>; > + clocks = <&infracfg CLK_INFRA_THERM>, > + <&infracfg CLK_INFRA_AUXADC>; > + clock-names = "therm", "auxadc"; > + resets = <&infracfg MT8183_INFRACFG_AO_THERM_SW_RST>; > + mediatek,auxadc = <&auxadc>; > + mediatek,apmixedsys = <&apmixedsys>; > + mediatek,hw-reset-temp = <117000>; > + nvmem-cells = <&thermal_calibration>; > + nvmem-cell-names = "calibration-data"; > + }; > + > + thermal-zones { > + cpu_thermal: cpu_thermal { > + polling-delay-passive = <1000>; > + polling-delay = <1000>; > + > + thermal-sensors = <&thermal 0>; > + sustainable-power = <1500>; > + }; > + > + tzts1: tzts1 { > + polling-delay-passive = <1000>; > + polling-delay = <1000>; > + thermal-sensors = <&thermal 1>; Is sustainable-power required for tzts? Though it's an optional property, kernel would have warning: [ 0.631556] thermal thermal_zone1: power_allocator: sustainable_power will be estimated [ 0.639586] thermal thermal_zone2: power_allocator: sustainable_power will be estimated [ 0.647611] thermal thermal_zone3: power_allocator: sustainable_power will be estimated [ 0.655635] thermal thermal_zone4: power_allocator: sustainable_power will be estimated [ 0.663658] thermal thermal_zone5: power_allocator: sustainable_power will be estimated if no sustainable-power assigned. > + }; > + > + tzts2: tzts2 { > + polling-delay-passive = <1000>; > + polling-delay = <1000>; > + thermal-sensors = <&thermal 2>; > + }; > + > + tzts3: tzts3 { > + polling-delay-passive = <1000>; > + polling-delay = <1000>; > + thermal-sensors = <&thermal 3>; > + }; > + > + tzts4: tzts4 { > + polling-delay-passive = <1000>; > + polling-delay = <1000>; > + thermal-sensors = <&thermal 4>; > + }; > + > + tzts5: tzts5 { > + polling-delay-passive = <1000>; > + polling-delay = <1000>; > + thermal-sensors = <&thermal 5>; > + }; > + > + tztsABB: tztsABB { > + polling-delay-passive = <1000>; > + polling-delay = <1000>; > + thermal-sensors = <&thermal 6>; > + }; > + }; > audiosys: syscon@11220000 { > compatible = "mediatek,mt8183-audiosys", "syscon"; > reg = <0 0x11220000 0 0x1000>; > @@ -368,6 +429,9 @@ > compatible = "mediatek,mt8183-efuse", > "mediatek,efuse"; > reg = <0 0x11f10000 0 0x1000>; > + thermal_calibration: calib@180 { > + reg = <0x180 0xc>; > + }; > }; > > mfgcfg: syscon@13000000 { _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel