From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 655C3C433B4 for ; Tue, 11 May 2021 04:34:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3D16361921 for ; Tue, 11 May 2021 04:34:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230135AbhEKEfm (ORCPT ); Tue, 11 May 2021 00:35:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229548AbhEKEfl (ORCPT ); Tue, 11 May 2021 00:35:41 -0400 Received: from mail-il1-x135.google.com (mail-il1-x135.google.com [IPv6:2607:f8b0:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 974C0C061574 for ; Mon, 10 May 2021 21:34:35 -0700 (PDT) Received: by mail-il1-x135.google.com with SMTP id j20so16037874ilo.10 for ; Mon, 10 May 2021 21:34:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=m4tpZentr0TR2+FXTu3cAIgvwuk8SCd5AACOcGsFclc=; b=bG2CP+eF8OkjQT3EabsJgsO+73FTRrGWVbWePSQEyPiCfhCMqDrNIsf8IlatXcwIxQ zKGRkGZffuLgiROFw15VfNpKCNxsszcOMz+wxPgK3NaJOyQsfkzdFHkifcFrshkW4psZ zsTmYDUhLk7v4sGXObhL+8wTZ6GnlKXSWFbzI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m4tpZentr0TR2+FXTu3cAIgvwuk8SCd5AACOcGsFclc=; b=CZt4KPUtqq8Q08jsT0i42MdrX/y1ZX7jufaNUc+AptOqGT0d4AsXDXTHEQgUjj+hwv cg/+lWhKmul4rhLBA2DryHozPQd0IN2T8dOLamR5fIPI3a7yeMIq9ljZUI8ixrjOr+9X qA+9Zd8k+fQMDZzS8++AIkPcQDuVaZ70VeD7G7IEpAw5s2FpAylklMO7HhPY0CshhkaF Aatx36tosq8Ya0aqHkdubsVm958+JQHKz1XHf2CL7cFzbUzO4J4YwOy1SLuDtUs+N/uZ FiNO21edHmztW9L/j61PA8SynuwzWWi3Yii2qUw/jNbxSO4VWOZ+KEsCum9cfZowBldl iLaw== X-Gm-Message-State: AOAM532zBtGNsVmHbLp31PrbbczY9ueAxgwjFpuQmM1er31yUEiptFan uZJaBj5ndBtaLIa2fVb0wFrIpi7SWiGeGw3h5kiUCPL7aOQldQ== X-Google-Smtp-Source: ABdhPJzFflNdpVJDf+0TIvFgpzzopa1uxa/OtJjcqRcc+rKSCn9UlaFhW0oFRTdjhXoBDVY9BBfp5kygW6IDQzpOHmI= X-Received: by 2002:a92:cd52:: with SMTP id v18mr24668263ilq.308.1620707675024; Mon, 10 May 2021 21:34:35 -0700 (PDT) MIME-Version: 1.0 References: <20210510053125.1595659-1-pihsun@chromium.org> <20210510053125.1595659-2-pihsun@chromium.org> In-Reply-To: <20210510053125.1595659-2-pihsun@chromium.org> From: Hsin-Yi Wang Date: Tue, 11 May 2021 12:34:09 +0800 Message-ID: Subject: Re: [PATCH v3 2/2] drm/bridge: anx7625: add suspend / resume hooks To: Pi-Hsun Shih Cc: Tzung-Bi Shih , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Xin Ji , Sam Ravnborg , "open list:DRM DRIVERS" , open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 10, 2021 at 1:31 PM Pi-Hsun Shih wrote: > > Add suspend / resume hooks for anx7625 driver, that power off the device > on suspend and power on the device on resume if it was previously > powered. > > Signed-off-by: Pi-Hsun Shih Tested-by: Hsin-Yi Wang Tested on a mt8183 juniper device. > --- > > Changes from v2: > * No change. > > --- > drivers/gpu/drm/bridge/analogix/anx7625.c | 27 +++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > index e1bf31eafe22..b165ef71e00f 100644 > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > @@ -1705,7 +1705,34 @@ static int __maybe_unused anx7625_runtime_pm_resume(struct device *dev) > return 0; > } > > +static int __maybe_unused anx7625_resume(struct device *dev) > +{ > + struct anx7625_data *ctx = dev_get_drvdata(dev); > + > + if (!ctx->pdata.intp_irq) > + return 0; > + > + if (!pm_runtime_enabled(dev) || !pm_runtime_suspended(dev)) > + anx7625_runtime_pm_resume(dev); > + > + return 0; > +} > + > +static int __maybe_unused anx7625_suspend(struct device *dev) > +{ > + struct anx7625_data *ctx = dev_get_drvdata(dev); > + > + if (!ctx->pdata.intp_irq) > + return 0; > + > + if (!pm_runtime_enabled(dev) || !pm_runtime_suspended(dev)) > + anx7625_runtime_pm_suspend(dev); > + > + return 0; > +} > + > static const struct dev_pm_ops anx7625_pm_ops = { > + SET_SYSTEM_SLEEP_PM_OPS(anx7625_suspend, anx7625_resume) > SET_RUNTIME_PM_OPS(anx7625_runtime_pm_suspend, > anx7625_runtime_pm_resume, NULL) > }; > -- > 2.31.1.607.g51e8a6a459-goog > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC4B7C433ED for ; Tue, 11 May 2021 04:34:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A2E9615FF for ; Tue, 11 May 2021 04:34:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A2E9615FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1B21D6E9B2; Tue, 11 May 2021 04:34:37 +0000 (UTC) Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) by gabe.freedesktop.org (Postfix) with ESMTPS id D028E6E9B2 for ; Tue, 11 May 2021 04:34:35 +0000 (UTC) Received: by mail-il1-x130.google.com with SMTP id c3so16079302ils.5 for ; Mon, 10 May 2021 21:34:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=m4tpZentr0TR2+FXTu3cAIgvwuk8SCd5AACOcGsFclc=; b=bG2CP+eF8OkjQT3EabsJgsO+73FTRrGWVbWePSQEyPiCfhCMqDrNIsf8IlatXcwIxQ zKGRkGZffuLgiROFw15VfNpKCNxsszcOMz+wxPgK3NaJOyQsfkzdFHkifcFrshkW4psZ zsTmYDUhLk7v4sGXObhL+8wTZ6GnlKXSWFbzI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m4tpZentr0TR2+FXTu3cAIgvwuk8SCd5AACOcGsFclc=; b=NDVOsHMv61Vktbww6JpycAJIjUAzp8qBjkkdmabkndz+eXrag8g+2zKIdu87qR/Hai nGDAoZh6ncxfqWNGTHUI2R/efbMTUdG5xwMpbRE93sSuUhQhOjTnwg5h7EOvNwwwMSNd bDjto9k/Dwcxes+TPu6syq74CCpaGVOgk99VbkC8EbyFlsNgYnyeMtEna82EiVmV9CZr D0KTiGLkVO7wpmcrwwxlE4v2JzZvo1Y63RD6w0sW7ElbbPZH6LYdywfLkd77Tbb0/ctn dJPwMmkxmrxxq7BjxyiQTqUKjT+VA+OpFI6DSXrxsOwEJ3wfA39nioje5ObPLHsuVGtj 2dNA== X-Gm-Message-State: AOAM532c9UmCY/MLnom9rRHcr50pqhw36L5wXhfe1qiu7xN3+JYNXEls tPTcgCT2p/4CJ2P7nLDpqsz+8fTZWwKu6Q794rfx5w== X-Google-Smtp-Source: ABdhPJzFflNdpVJDf+0TIvFgpzzopa1uxa/OtJjcqRcc+rKSCn9UlaFhW0oFRTdjhXoBDVY9BBfp5kygW6IDQzpOHmI= X-Received: by 2002:a92:cd52:: with SMTP id v18mr24668263ilq.308.1620707675024; Mon, 10 May 2021 21:34:35 -0700 (PDT) MIME-Version: 1.0 References: <20210510053125.1595659-1-pihsun@chromium.org> <20210510053125.1595659-2-pihsun@chromium.org> In-Reply-To: <20210510053125.1595659-2-pihsun@chromium.org> From: Hsin-Yi Wang Date: Tue, 11 May 2021 12:34:09 +0800 Message-ID: Subject: Re: [PATCH v3 2/2] drm/bridge: anx7625: add suspend / resume hooks To: Pi-Hsun Shih Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , Jonas Karlman , David Airlie , "open list:DRM DRIVERS" , Neil Armstrong , open list , Robert Foss , Andrzej Hajda , Tzung-Bi Shih , Laurent Pinchart , Sam Ravnborg , Xin Ji Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, May 10, 2021 at 1:31 PM Pi-Hsun Shih wrote: > > Add suspend / resume hooks for anx7625 driver, that power off the device > on suspend and power on the device on resume if it was previously > powered. > > Signed-off-by: Pi-Hsun Shih Tested-by: Hsin-Yi Wang Tested on a mt8183 juniper device. > --- > > Changes from v2: > * No change. > > --- > drivers/gpu/drm/bridge/analogix/anx7625.c | 27 +++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > index e1bf31eafe22..b165ef71e00f 100644 > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > @@ -1705,7 +1705,34 @@ static int __maybe_unused anx7625_runtime_pm_resume(struct device *dev) > return 0; > } > > +static int __maybe_unused anx7625_resume(struct device *dev) > +{ > + struct anx7625_data *ctx = dev_get_drvdata(dev); > + > + if (!ctx->pdata.intp_irq) > + return 0; > + > + if (!pm_runtime_enabled(dev) || !pm_runtime_suspended(dev)) > + anx7625_runtime_pm_resume(dev); > + > + return 0; > +} > + > +static int __maybe_unused anx7625_suspend(struct device *dev) > +{ > + struct anx7625_data *ctx = dev_get_drvdata(dev); > + > + if (!ctx->pdata.intp_irq) > + return 0; > + > + if (!pm_runtime_enabled(dev) || !pm_runtime_suspended(dev)) > + anx7625_runtime_pm_suspend(dev); > + > + return 0; > +} > + > static const struct dev_pm_ops anx7625_pm_ops = { > + SET_SYSTEM_SLEEP_PM_OPS(anx7625_suspend, anx7625_resume) > SET_RUNTIME_PM_OPS(anx7625_runtime_pm_suspend, > anx7625_runtime_pm_resume, NULL) > }; > -- > 2.31.1.607.g51e8a6a459-goog >