From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753868AbbK3UdM (ORCPT <rfc822;w@1wt.eu>);
	Mon, 30 Nov 2015 15:33:12 -0500
Received: from mail-yk0-f173.google.com ([209.85.160.173]:35115 "EHLO
	mail-yk0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751250AbbK3UdL convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 30 Nov 2015 15:33:11 -0500
MIME-Version: 1.0
In-Reply-To: <CAHp75Vf2VKmNCw-pJBBO8-8CgwYZE-BmfHd9RcmgUgGNKHmghw@mail.gmail.com>
References: <CAJN_NGagPZVTPs3CmenhusC06u5svYcEBqv9dooij9kDf6yjUw@mail.gmail.com>
	<CAHp75Vf2VKmNCw-pJBBO8-8CgwYZE-BmfHd9RcmgUgGNKHmghw@mail.gmail.com>
Date: Mon, 30 Nov 2015 23:33:10 +0300
Message-ID: <CAJN_NGb36NPwCPMHstU2Dck=BVAr9J1-cFcNjzhftxidNiWXww@mail.gmail.com>
Subject: Re: [PATCH 1/1] Remove unneeded "0x" when %pa formatting is used.
From: Dmitry Krivenok <krivenok.dmitry@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> First of all, please, split per subsystem / driver. Here seems one
> file — one patch.

Sure, will do.

>>      if (size > max_size) {
>>          dev_err(pcie->dev,
>> -            "res size 0x%pap exceeds max supported size 0x%llx\n",
>> +            "res size %pap exceeds max supported size 0x%llx\n",
>
> %pa also works.
>

Yes, but AFAIK %pap and %pa are identical (see address_val() in lib/vsprintf.c),
so I'm not sure I understand your comment.

Did you mean that %pa should be used instead of %pap?
I see that %pa is used much more often than %pap, but I didn't find any
evidence that %pap is deprecated.

Thanks,
Dmitry