From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH 16/21] usb: chipidea: msm: Restore wrapper settings after reset Date: Thu, 30 Jun 2016 09:24:29 -0700 Message-ID: References: <20160626072838.28082-1-stephen.boyd@linaro.org> <20160626072838.28082-17-stephen.boyd@linaro.org> <20160629082648.GK25236@shlinux2> <146722762509.16253.13062209537472705701@sboyd-linaro> <20160630085436.GA18426@shlinux2> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20160630085436.GA18426@shlinux2> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Peter Chen Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Felipe Balbi , Arnd Bergmann , Neil Armstrong , linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux Kernel Mailing List , Bjorn Andersson , Peter Chen , Greg Kroah-Hartman , Andy Gross , linux-arm-kernel List-Id: linux-arm-msm@vger.kernel.org On 30 June 2016 at 01:54, Peter Chen wrote: > On Wed, Jun 29, 2016 at 12:13:45PM -0700, Stephen Boyd wrote: >> Quoting Peter Chen (2016-06-29 01:26:48 >> > Why not using ci->platdata->vbus_extcon directly? >> >> Because ci->platdata->vbus_extcon is assigned after the child platform >> driver probes, and we have no idea when that will happen from the >> ci_hdrc_msm driver probe. If we try after ci_hdrc_add_device() we'll >> race with the driver probe and only get the pointer sometimes. > > ci->platdata->vbus_extcon->edev is assigned at ci_get_platdata which is > called before ci core device is created. > Ok. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932945AbcF3QYj (ORCPT ); Thu, 30 Jun 2016 12:24:39 -0400 Received: from mail-vk0-f43.google.com ([209.85.213.43]:34996 "EHLO mail-vk0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932372AbcF3QYa (ORCPT ); Thu, 30 Jun 2016 12:24:30 -0400 MIME-Version: 1.0 In-Reply-To: <20160630085436.GA18426@shlinux2> References: <20160626072838.28082-1-stephen.boyd@linaro.org> <20160626072838.28082-17-stephen.boyd@linaro.org> <20160629082648.GK25236@shlinux2> <146722762509.16253.13062209537472705701@sboyd-linaro> <20160630085436.GA18426@shlinux2> From: Stephen Boyd Date: Thu, 30 Jun 2016 09:24:29 -0700 Message-ID: Subject: Re: [PATCH 16/21] usb: chipidea: msm: Restore wrapper settings after reset To: Peter Chen Cc: linux-usb@vger.kernel.org, Felipe Balbi , Arnd Bergmann , Neil Armstrong , linux-arm-msm@vger.kernel.org, Linux Kernel Mailing List , Bjorn Andersson , Peter Chen , Greg Kroah-Hartman , Andy Gross , linux-arm-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30 June 2016 at 01:54, Peter Chen wrote: > On Wed, Jun 29, 2016 at 12:13:45PM -0700, Stephen Boyd wrote: >> Quoting Peter Chen (2016-06-29 01:26:48 >> > Why not using ci->platdata->vbus_extcon directly? >> >> Because ci->platdata->vbus_extcon is assigned after the child platform >> driver probes, and we have no idea when that will happen from the >> ci_hdrc_msm driver probe. If we try after ci_hdrc_add_device() we'll >> race with the driver probe and only get the pointer sometimes. > > ci->platdata->vbus_extcon->edev is assigned at ci_get_platdata which is > called before ci core device is created. > Ok. From mboxrd@z Thu Jan 1 00:00:00 1970 From: stephen.boyd@linaro.org (Stephen Boyd) Date: Thu, 30 Jun 2016 09:24:29 -0700 Subject: [PATCH 16/21] usb: chipidea: msm: Restore wrapper settings after reset In-Reply-To: <20160630085436.GA18426@shlinux2> References: <20160626072838.28082-1-stephen.boyd@linaro.org> <20160626072838.28082-17-stephen.boyd@linaro.org> <20160629082648.GK25236@shlinux2> <146722762509.16253.13062209537472705701@sboyd-linaro> <20160630085436.GA18426@shlinux2> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 30 June 2016 at 01:54, Peter Chen wrote: > On Wed, Jun 29, 2016 at 12:13:45PM -0700, Stephen Boyd wrote: >> Quoting Peter Chen (2016-06-29 01:26:48 >> > Why not using ci->platdata->vbus_extcon directly? >> >> Because ci->platdata->vbus_extcon is assigned after the child platform >> driver probes, and we have no idea when that will happen from the >> ci_hdrc_msm driver probe. If we try after ci_hdrc_add_device() we'll >> race with the driver probe and only get the pointer sometimes. > > ci->platdata->vbus_extcon->edev is assigned at ci_get_platdata which is > called before ci core device is created. > Ok.