From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH v2 15/22] usb: chipidea: msm: Mux over secondary phy at the right time Date: Mon, 11 Jul 2016 15:03:37 -0700 Message-ID: References: <20160707222114.1673-1-stephen.boyd@linaro.org> <20160707222114.1673-16-stephen.boyd@linaro.org> <20160711044327.GG30448@shlinux2> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20160711044327.GG30448@shlinux2> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Peter Chen Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel , Linux Kernel Mailing List , linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andy Gross , Bjorn Andersson , Neil Armstrong , Arnd Bergmann , Felipe Balbi , Peter Chen , Greg Kroah-Hartman List-Id: linux-arm-msm@vger.kernel.org On 10 July 2016 at 21:43, Peter Chen wrote: > On Thu, Jul 07, 2016 at 03:21:06PM -0700, Stephen Boyd wrote: >> diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_hdrc_msm.c >> index 7e870a253f55..7708bee3ff3e 100644 >> --- a/drivers/usb/chipidea/ci_hdrc_msm.c >> +++ b/drivers/usb/chipidea/ci_hdrc_msm.c >> @@ -8,29 +8,44 @@ >> #include >> #include >> #include >> -#include >> #include >> #include >> #include >> +#include >> +#include >> +#include >> >> #include "ci.h" >> >> #define HS_PHY_AHB_MODE 0x0098 >> >> +/* Vendor base starts at 0x200 beyond CI base */ >> +#define HS_PHY_SEC_CTRL 0x0078 >> +#define HS_PHY_DIG_CLAMP_N BIT(16) >> + > > Keep alignment It's aligned in my editor, tabs vs. spaces problem? >> @@ -123,9 +177,12 @@ static int ci_hdrc_msm_probe(struct platform_device *pdev) >> if (ret) >> goto err_iface; >> >> - plat_ci = ci_hdrc_add_device(&pdev->dev, >> - pdev->resource, pdev->num_resources, >> - &ci_hdrc_msm_platdata); >> + ret = ci_hdrc_msm_mux_phy(ci, pdev); >> + if (ret) >> + goto err_mux; >> + >> + plat_ci = ci_hdrc_add_device(&pdev->dev, pdev->resource, >> + pdev->num_resources, &ci_hdrc_msm_platdata); > > The above line has not changed. Fixed. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932245AbcGKWDk (ORCPT ); Mon, 11 Jul 2016 18:03:40 -0400 Received: from mail-vk0-f48.google.com ([209.85.213.48]:34249 "EHLO mail-vk0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752461AbcGKWDi (ORCPT ); Mon, 11 Jul 2016 18:03:38 -0400 MIME-Version: 1.0 In-Reply-To: <20160711044327.GG30448@shlinux2> References: <20160707222114.1673-1-stephen.boyd@linaro.org> <20160707222114.1673-16-stephen.boyd@linaro.org> <20160711044327.GG30448@shlinux2> From: Stephen Boyd Date: Mon, 11 Jul 2016 15:03:37 -0700 Message-ID: Subject: Re: [PATCH v2 15/22] usb: chipidea: msm: Mux over secondary phy at the right time To: Peter Chen Cc: linux-usb@vger.kernel.org, linux-arm-kernel , Linux Kernel Mailing List , linux-arm-msm@vger.kernel.org, Andy Gross , Bjorn Andersson , Neil Armstrong , Arnd Bergmann , Felipe Balbi , Peter Chen , Greg Kroah-Hartman Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10 July 2016 at 21:43, Peter Chen wrote: > On Thu, Jul 07, 2016 at 03:21:06PM -0700, Stephen Boyd wrote: >> diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_hdrc_msm.c >> index 7e870a253f55..7708bee3ff3e 100644 >> --- a/drivers/usb/chipidea/ci_hdrc_msm.c >> +++ b/drivers/usb/chipidea/ci_hdrc_msm.c >> @@ -8,29 +8,44 @@ >> #include >> #include >> #include >> -#include >> #include >> #include >> #include >> +#include >> +#include >> +#include >> >> #include "ci.h" >> >> #define HS_PHY_AHB_MODE 0x0098 >> >> +/* Vendor base starts at 0x200 beyond CI base */ >> +#define HS_PHY_SEC_CTRL 0x0078 >> +#define HS_PHY_DIG_CLAMP_N BIT(16) >> + > > Keep alignment It's aligned in my editor, tabs vs. spaces problem? >> @@ -123,9 +177,12 @@ static int ci_hdrc_msm_probe(struct platform_device *pdev) >> if (ret) >> goto err_iface; >> >> - plat_ci = ci_hdrc_add_device(&pdev->dev, >> - pdev->resource, pdev->num_resources, >> - &ci_hdrc_msm_platdata); >> + ret = ci_hdrc_msm_mux_phy(ci, pdev); >> + if (ret) >> + goto err_mux; >> + >> + plat_ci = ci_hdrc_add_device(&pdev->dev, pdev->resource, >> + pdev->num_resources, &ci_hdrc_msm_platdata); > > The above line has not changed. Fixed. From mboxrd@z Thu Jan 1 00:00:00 1970 From: stephen.boyd@linaro.org (Stephen Boyd) Date: Mon, 11 Jul 2016 15:03:37 -0700 Subject: [PATCH v2 15/22] usb: chipidea: msm: Mux over secondary phy at the right time In-Reply-To: <20160711044327.GG30448@shlinux2> References: <20160707222114.1673-1-stephen.boyd@linaro.org> <20160707222114.1673-16-stephen.boyd@linaro.org> <20160711044327.GG30448@shlinux2> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10 July 2016 at 21:43, Peter Chen wrote: > On Thu, Jul 07, 2016 at 03:21:06PM -0700, Stephen Boyd wrote: >> diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_hdrc_msm.c >> index 7e870a253f55..7708bee3ff3e 100644 >> --- a/drivers/usb/chipidea/ci_hdrc_msm.c >> +++ b/drivers/usb/chipidea/ci_hdrc_msm.c >> @@ -8,29 +8,44 @@ >> #include >> #include >> #include >> -#include >> #include >> #include >> #include >> +#include >> +#include >> +#include >> >> #include "ci.h" >> >> #define HS_PHY_AHB_MODE 0x0098 >> >> +/* Vendor base starts at 0x200 beyond CI base */ >> +#define HS_PHY_SEC_CTRL 0x0078 >> +#define HS_PHY_DIG_CLAMP_N BIT(16) >> + > > Keep alignment It's aligned in my editor, tabs vs. spaces problem? >> @@ -123,9 +177,12 @@ static int ci_hdrc_msm_probe(struct platform_device *pdev) >> if (ret) >> goto err_iface; >> >> - plat_ci = ci_hdrc_add_device(&pdev->dev, >> - pdev->resource, pdev->num_resources, >> - &ci_hdrc_msm_platdata); >> + ret = ci_hdrc_msm_mux_phy(ci, pdev); >> + if (ret) >> + goto err_mux; >> + >> + plat_ci = ci_hdrc_add_device(&pdev->dev, pdev->resource, >> + pdev->num_resources, &ci_hdrc_msm_platdata); > > The above line has not changed. Fixed.