From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) by mx.groups.io with SMTP id smtpd.web11.8980.1613487650019267250 for ; Tue, 16 Feb 2021 07:00:50 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=TfMHfBZF; spf=pass (domain: gmail.com, ip: 209.85.222.177, mailfrom: sam.van.den.berge@gmail.com) Received: by mail-qk1-f177.google.com with SMTP id 81so9630922qkf.4 for ; Tue, 16 Feb 2021 07:00:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ih9Rpr5STqLvRLXC+XveVAslDfPvi+micEppHKojwzo=; b=TfMHfBZFKDdYEFlU9cUj704Z0bmEVNrHKLUCby1aXn1tYhCwA3kYxAc9MmqmNMN3SH Xyq+fd735O4HZ6r7mHAhXg8fMLmJy9nROsePly/WgD2DB+2kxKBmGjLrBoCRPybFrvOQ QZ0vSpbJALVnBpl8rMoRN1phzg64zsm7Lbmasw0RII/r05itIs2LScGi83SlL/6gBzmd rpi4gly7NnaxFL5mKIkQpoaoeWbcHYyOIcdqAs5zsMgmkCtBcCAgiAtrUG7OJlft93+P jS8L0xsN8utLDTrR87tnsvXAfpj4femWclSadBTFf7DI+lHVR0iw9A6GZy6SP1gPQiQf PGLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ih9Rpr5STqLvRLXC+XveVAslDfPvi+micEppHKojwzo=; b=S72bWAu3KohEXt0/KsfehGHWi6nzbfNpDZ22Pqf4asYgeFAfE/dzXM075Vp7I0iLhA o8ZXGQbdo884SvNUnDzv0L8A/IAXlObbRx1gGe2WDwUGnBI24Gmg3oN+5HQxXe6UqgQ8 MB7ihAriGJaAV2DLe6ZJptu7OvMCukr3rGZME72oUiLKt7h+2VQlrfOdN0gGg2s8nl4A hOXGZPApF3AqLDqOmXg9ZUY4Qjo1d3T5hmy99UNHb032VY4Ys8KpxQLhzyTCcR1ZtNyI sdjidpaw5Dnbi61BZYWFexcUPMW6lFCrxjXHzSDfNZ1/4cArOgMlHqYTfmGcUdqjAclt mUqg== X-Gm-Message-State: AOAM531GGa5M9HUvc/cVdY2QIWsGKia+QK3AimnlPMdZL8Gz2WHXssIo neppyU++mNLJiQWtMpYbt4IUQ3sAgMNSri61Cw== X-Google-Smtp-Source: ABdhPJxEZT7SYEfSjk9uKuGlTYS7PQpOISIQMigtwAyxoLdQbz980wrzXKeYx5gw/yheKwyvGzMgpgx2DawitcDmuPM= X-Received: by 2002:a37:a7c3:: with SMTP id q186mr20557969qke.475.1613487649110; Tue, 16 Feb 2021 07:00:49 -0800 (PST) MIME-Version: 1.0 References: <28924.1603788360363021085@lists.yoctoproject.org> <18462.1613421333255881579@lists.yoctoproject.org> In-Reply-To: From: "svdb" Date: Tue, 16 Feb 2021 16:00:37 +0100 Message-ID: Subject: Re: [meta-freescale] Cannot run "devtool mofidy linux-fslc" in Dunfell branch To: Andrey Zhizhikin Cc: meta-freescale@lists.yoctoproject.org Content-Type: text/plain; charset="UTF-8" On Tue, Feb 16, 2021 at 12:13 PM Andrey Zhizhikin wrote: > > Hello Sam, > > On Tue, Feb 16, 2021 at 12:05 PM Sam Van Den Berge > wrote: > > > > On Mon, Feb 15, 2021 at 11:10 PM Andrey Zhizhikin wrote: > > > > > > Hello Sam, > > > > > > On Mon, Feb 15, 2021 at 9:35 PM wrote: > > > > > > > > I also have the exact same error with linux-fslc 5.10.12. > > > > > > Can you try to change SRCBRANCH in > > > recipes-kernel/linux/linux-fslc_5.10.bb to KBRANCH? I've just tried it > > > out and it should solve the problem. > > > > > > I have a patch for this and made a PR to address the issue, please > > > have a look at https://github.com/Freescale/meta-freescale/pull/652. I > > > would appreciate if you test it locally on your end and report here if > > > that solves your devtool errors. > > > > Unfortunately it's not solved in my case. Depending on the path that > > gets executed in > > devtool/standard.py, I do think your patch does solve the issue in some cases. > > Since linux-fslc[-imx] recipes are inheriting kernel-yocto class, it > is needed that the KBRANCH to be defined as it can be seen in > scripts/lib/devtool/standard.py on line 822. > > Which particular error do you see when you apply the patch from PR? > Do you have any appends to the kernel recipe? > Which machine are you trying to build and which distro? > We have one small append to the kernel recipe but it's something with a dts. No additional kernel configs or whatsoever. Machine is imx6q and distro is an internal one. I modified devtool a little bit so that it prints the variables from line 822 and this is what I get: kernelVersion=5.10.12 kbranch=5.10.x+fslc staging_kerVer= staging_kbranch= so in my case the if statement at line 822 is not True. I think this is because we do not clone the git repo but have extracted a tar.gz and we use that as the source. Not sure though... As a result of the False if-statement, _extract_source will be executed. Then at line 607 it will start executing the configure task. At the point the execution reaches the do_preconfigure() from fsl-kernel-localversion.bbclass while the file defconfig is not in ${WORKDIR} but in the ${WORKDIR}/../oe-local-files folder. As a result, the following command in the do_preconfigure() will fail: sed -e "${CONF_SED_SCRIPT}" < '${WORKDIR}/defconfig' >> '${B}/.config' This is the error I get: DEBUG: Executing shell function do_preconfigure ..../linux-fslc/5.10.12+gitAUTOINC+ed3accb10c-r0/devtooltmp-otiy_odb/temp/run.do_preconfigure.3336084: line 160: ...../devtooltmp-otiy_odb/workdir/defconfig: No such file or directory WARNING: ..../devtooltmp-otiy_odb/temp/run.do_preconfigure.3336084:160 exit 1 from 'sed -e "${CONF_SED_SCRIPT}" < ..../devtooltmp-otiy_odb/workdir/defconfig' >> '....devtooltmp-otiy_odb/workdir/build/.config'' The problem really is that devtool copies Non-patch files to an oe-local-files folder, in contrast to just running bitbake which puts both patch and non-patch files in the ${WORKDIR}. > -- > Regards, > Andrey.