All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jingbao Qiu <qiujingbao.dlmu@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: a.zummo@towertech.it, alexandre.belloni@bootlin.com,
	robh+dt@kernel.org,  krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org,  paul.walmsley@sifive.com,
	palmer@dabbelt.com, aou@eecs.berkeley.edu,
	 linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/1] dt-bindings: rtc: sophgo: add RTC support for Sophgo CV1800 series SoC
Date: Tue, 9 Jan 2024 17:51:48 +0800	[thread overview]
Message-ID: <CAJRtX8SBEXBzjs4sU+zOmsGUDF+K+TFw4S4x-f6WR5f2K5h6yw@mail.gmail.com> (raw)
In-Reply-To: <a6ee48ad-f4c1-4d75-956b-a5283ee92eaa@linaro.org>

On Tue, Jan 9, 2024 at 4:02 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 09/01/2024 03:26, Jingbao Qiu wrote:
> > On Mon, Jan 8, 2024 at 11:24 PM Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org> wrote:
> >>
> >> On 08/01/2024 14:47, Jingbao Qiu wrote:
> >>>>> So I wrote the following in the changelog.
> >>>>>
> >>>>> - add syscon attribute to share registers
> >>>>>   with POR
> >>>>
> >>>> Where is this syscon attribute? Please point me to specific line in DTS
> >>>> and in the driver.
> >>>
> >>> I will explain in the next version of DTS.
> >>> Thank you again for your patient reply.
> >>
> >> You added some syscon attribute. What is this?
> >>
> >
> > This RTC device has a POR submodule, which is explained in the description.
> > The corresponding driver of the POR submodule provides power off
> > restart function.
> > The driver of the POR submodule just uses reg to work.As you mentioned in your
> > last comment.POR  is empty, so there is little point in having it as
> > subnode. we need
> > share the reg to POR. RTC driver and POR driver will access this
> > address simultaneously.
> > so,I added this syscon attribute.
>
> Nothing from above explains what is "syscon attribute", but if you
> cannot explain it, at least point me to where did you add this syscon
> attribute? Changelog said you added it. Where?
>

Thank you for your comment. I will add it in the next version.

Best regards,
Jingbao Qiu

  reply	other threads:[~2024-01-09  9:52 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-08  7:22 [PATCH v5 0/1] dt-bindings: riscv: sophgo: add RTC for CV1800 Jingbao Qiu
2024-01-08  7:22 ` [PATCH v5 1/1] dt-bindings: rtc: sophgo: add RTC support for Sophgo CV1800 series SoC Jingbao Qiu
2024-01-08  8:04   ` Krzysztof Kozlowski
2024-01-08  9:10     ` Jingbao Qiu
2024-01-08  9:28       ` Krzysztof Kozlowski
2024-01-08 13:47         ` Jingbao Qiu
2024-01-08 15:24           ` Krzysztof Kozlowski
2024-01-09  2:26             ` Jingbao Qiu
2024-01-09  8:02               ` Krzysztof Kozlowski
2024-01-09  9:51                 ` Jingbao Qiu [this message]
2024-01-08  8:02 ` [PATCH v5 0/1] dt-bindings: riscv: sophgo: add RTC for CV1800 Krzysztof Kozlowski
2024-01-08  9:00   ` Jingbao Qiu
2024-01-08  9:06     ` Krzysztof Kozlowski
2024-01-08  9:11       ` Jingbao Qiu
2024-01-08  9:28         ` Krzysztof Kozlowski
2024-01-08 13:42           ` Jingbao Qiu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJRtX8SBEXBzjs4sU+zOmsGUDF+K+TFw4S4x-f6WR5f2K5h6yw@mail.gmail.com \
    --to=qiujingbao.dlmu@gmail.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.