Re: [PATCH v1 1/3] dt-bindings: rtc: sophgo: add RTC for Sophgo CV1800 series SoC.

[Jingbao Qiu <qiujingbao.dlmu@gmail.com>]

On Thu, Jan 4, 2024 at 4:32 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 29/12/2023 10:06, Jingbao Qiu wrote:
> > Add devicetree binding to describe the RTC for Sophgo CV1800 SoC.
> >
> > Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@gmail.com>
> > ---
> > This patch depends on the clk driver
> > Clk driver link:
> > https://lore.kernel.org/all/IA1PR20MB49539CDAD9A268CBF6CA184BBB9FA@IA1PR20MB4953.namprd20.prod.outlook.com/
>
> I don't understand how binding can depend on a driver. This is very
> confusing and suggests you write binding for the driver, which is not
> what we want.
>
> What's more, I really do not see the dependency here, so your message is
> incorrect?
>

What I mean is that clk is used in the following example. In the clk
patch, there
is a macro definition that can be used to replace this number.

> >
> >  .../bindings/rtc/sophgo,cv1800-rtc.yaml       | 40 +++++++++++++++++++
> >  1 file changed, 40 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/rtc/sophgo,cv1800-rtc.yaml
> >
>
> You have dependencies between patches, but I do not see this explained
> at all. How people can figure out merging strategy if they are not aware
> there is dependency?

I'm sorry for that, I will add an explanation in the description.

Happy new year!

Best regards,
Jingbao Qiu

>
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Best regards,
> Krzysztof
>