From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55213) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTje1-0008HW-CT for qemu-devel@nongnu.org; Fri, 15 Jun 2018 03:59:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fTje0-0004va-LJ for qemu-devel@nongnu.org; Fri, 15 Jun 2018 03:59:41 -0400 MIME-Version: 1.0 In-Reply-To: References: <20180614164431.29305-1-stefanha@redhat.com> <5768e8f3-eae5-30ef-888a-5e62692c238d@redhat.com> From: Stefan Hajnoczi Date: Fri, 15 Jun 2018 08:59:34 +0100 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] compiler: add a sizeof_field() macro List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Cc: John Snow , xen-devel@lists.xenproject.org, qemu-s390x@nongnu.org, "qemu-ppc@nongnu.org list:PowerPC" , qemu-devel , Stefan Hajnoczi On Thu, Jun 14, 2018 at 9:33 PM, Philippe Mathieu-Daud=C3=A9 wrote: > On 06/14/2018 04:17 PM, John Snow wrote: >> On 06/14/2018 12:44 PM, Stefan Hajnoczi wrote: >>> Determining the size of a field is useful when you don't have a struct >>> variable handy. Open-coding this is ugly. >>> >>> This patch adds the sizeof_field() macro, which is similar to >>> typeof_field(). Existing instances are updated to use the macro. >>> >>> Signed-off-by: Stefan Hajnoczi >> >> How'd you find all the existing instances? > > This works: > > $ git grep -E 'sizeof.*)0)->' Yes, I used a similar grep command-line. I also checked for "sizeof.*)NULL" but nothing uses that syntax. Stefan From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Hajnoczi Subject: Re: [Qemu-devel] [PATCH] compiler: add a sizeof_field() macro Date: Fri, 15 Jun 2018 08:59:34 +0100 Message-ID: References: <20180614164431.29305-1-stefanha@redhat.com> <5768e8f3-eae5-30ef-888a-5e62692c238d@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1fTjdx-0000oD-DK for xen-devel@lists.xenproject.org; Fri, 15 Jun 2018 07:59:37 +0000 Received: by mail-wm0-x244.google.com with SMTP id r15-v6so2056591wmc.1 for ; Fri, 15 Jun 2018 00:59:36 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Cc: qemu-devel , qemu-s390x@nongnu.org, "qemu-ppc@nongnu.org list:PowerPC" , Stefan Hajnoczi , xen-devel@lists.xenproject.org, John Snow List-Id: xen-devel@lists.xenproject.org T24gVGh1LCBKdW4gMTQsIDIwMTggYXQgOTozMyBQTSwgUGhpbGlwcGUgTWF0aGlldS1EYXVkw6kg PGY0YnVnQGFtc2F0Lm9yZz4gd3JvdGU6Cj4gT24gMDYvMTQvMjAxOCAwNDoxNyBQTSwgSm9obiBT bm93IHdyb3RlOgo+PiBPbiAwNi8xNC8yMDE4IDEyOjQ0IFBNLCBTdGVmYW4gSGFqbm9jemkgd3Jv dGU6Cj4+PiBEZXRlcm1pbmluZyB0aGUgc2l6ZSBvZiBhIGZpZWxkIGlzIHVzZWZ1bCB3aGVuIHlv dSBkb24ndCBoYXZlIGEgc3RydWN0Cj4+PiB2YXJpYWJsZSBoYW5keS4gIE9wZW4tY29kaW5nIHRo aXMgaXMgdWdseS4KPj4+Cj4+PiBUaGlzIHBhdGNoIGFkZHMgdGhlIHNpemVvZl9maWVsZCgpIG1h Y3JvLCB3aGljaCBpcyBzaW1pbGFyIHRvCj4+PiB0eXBlb2ZfZmllbGQoKS4gIEV4aXN0aW5nIGlu c3RhbmNlcyBhcmUgdXBkYXRlZCB0byB1c2UgdGhlIG1hY3JvLgo+Pj4KPj4+IFNpZ25lZC1vZmYt Ynk6IFN0ZWZhbiBIYWpub2N6aSA8c3RlZmFuaGFAcmVkaGF0LmNvbT4KPj4KPj4gSG93J2QgeW91 IGZpbmQgYWxsIHRoZSBleGlzdGluZyBpbnN0YW5jZXM/Cj4KPiBUaGlzIHdvcmtzOgo+Cj4gJCBn aXQgZ3JlcCAtRSAnc2l6ZW9mLiopMCktPicKClllcywgSSB1c2VkIGEgc2ltaWxhciBncmVwIGNv bW1hbmQtbGluZS4KCkkgYWxzbyBjaGVja2VkIGZvciAic2l6ZW9mLiopTlVMTCIgYnV0IG5vdGhp bmcgdXNlcyB0aGF0IHN5bnRheC4KClN0ZWZhbgoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlz dHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xp c3RpbmZvL3hlbi1kZXZlbA==