From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45920) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrPzA-0003lt-LI for qemu-devel@nongnu.org; Wed, 18 Jul 2012 04:51:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SrPz9-00044c-I6 for qemu-devel@nongnu.org; Wed, 18 Jul 2012 04:51:56 -0400 Received: from mail-lb0-f173.google.com ([209.85.217.173]:53234) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SrPz9-00044V-Ac for qemu-devel@nongnu.org; Wed, 18 Jul 2012 04:51:55 -0400 Received: by lbok6 with SMTP id k6so2036053lbo.4 for ; Wed, 18 Jul 2012 01:51:54 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <5005C253.1010506@linux.vnet.ibm.com> References: <1341307259-27262-1-git-send-email-harsh@linux.vnet.ibm.com> <5005C253.1010506@linux.vnet.ibm.com> Date: Wed, 18 Jul 2012 09:51:53 +0100 Message-ID: From: Stefan Hajnoczi Content-Type: text/plain; charset=ISO-8859-1 Subject: Re: [Qemu-devel] [PATCH v7 0/3] Simpletrace v2: Support multiple args, strings. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Harsh Bora Cc: qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com On Tue, Jul 17, 2012 at 8:51 PM, Harsh Bora wrote: > On 07/17/2012 08:53 PM, Stefan Hajnoczi wrote: >> >> On Tue, Jul 3, 2012 at 10:20 AM, Harsh Prateek Bora >> wrote: >>> >>> Existing simpletrace backend allows to trace at max 6 args and does not >>> support strings. This newer tracelog format gets rid of fixed size >>> records >>> and therefore allows to trace variable number of args including strings. >>> >>> Sample trace: >>> v9fs_version 0.000 tag=0xffff id=0x64 msize=0x2000 version=9P2000.L >>> v9fs_version_return 6.705 tag=0xffff id=0x64 msize=0x2000 >>> version=9P2000.L >>> v9fs_attach 174.467 tag=0x1 id=0x68 fid=0x0 afid=0xffffffffffffffff >>> uname=nobody aname= >>> v9fs_attach_return 4720.454 tag=0x1 id=0x68 type=0xffffffffffffff80 >>> version=0x4f2a4dd0 path=0x220ea6 >> >> >> I have successfully tested it with the fix that I posted. Writing >> simpletrace.Analyzer Python scripts still works - now with string >> arguments too :). >> >> Besides the last few comments on Patch 2, this looks okay now. > > > Thanks, I have the updated patches ready except for the question asked on > prev reply. Shall I fold your fix in patch 2 with comments as necessary. Let > me know if I need to add your s-o-b after merging your fix in patch #2? You > can update the commit message as you feel appropriate while merging to your > tree though. It's a trivial patch, feel free to squash it without noting anything. Stefan