From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:48115)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QpGEq-0001Yx-Ok
	for qemu-devel@nongnu.org; Fri, 05 Aug 2011 04:58:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QpGEl-0004DB-9a
	for qemu-devel@nongnu.org; Fri, 05 Aug 2011 04:58:40 -0400
Received: from mail-yx0-f173.google.com ([209.85.213.173]:34432)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QpGEk-0004Cy-WE
	for qemu-devel@nongnu.org; Fri, 05 Aug 2011 04:58:35 -0400
Received: by yxt3 with SMTP id 3so1817044yxt.4
	for <qemu-devel@nongnu.org>; Fri, 05 Aug 2011 01:58:34 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <alpine.LNX.2.00.1108051019170.14809@linmac>
References: <alpine.LNX.2.00.1108051019170.14809@linmac>
Date: Fri, 5 Aug 2011 09:58:34 +0100
Message-ID: <CAJSP0QUAhd2jZcYDAx_S1rik9Awu21iXEADfSkibRaZi0OTkCw@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] Build broken
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org

On Fri, Aug 5, 2011 at 7:22 AM, malc <av1474@comtv.ru> wrote:
>
> /home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c: In function 'coroutine=
_new':
> /home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c:160:16: error: 'arg.i[1=
]' may be used uninitialized in this function
> /home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c:136:18: note: 'arg.i[1]=
' was declared here
>
> diff --git a/coroutine-ucontext.c b/coroutine-ucontext.c
> index 41c2379..42dc3e2 100644
> --- a/coroutine-ucontext.c
> +++ b/coroutine-ucontext.c
> @@ -133,7 +133,7 @@ static Coroutine *coroutine_new(void)
> =A0 =A0 CoroutineUContext *co;
> =A0 =A0 ucontext_t old_uc, uc;
> =A0 =A0 jmp_buf old_env;
> - =A0 =A0union cc_arg arg;
> + =A0 =A0union cc_arg arg =3D {0};
>
> =A0 =A0 /* The ucontext functions preserve signal masks which incurs a sy=
stem call
> =A0 =A0 =A0* overhead. =A0setjmp()/longjmp() does not preserve signal mas=
ks but only
>
> I guess gcc should yell not only here on ppc32 but on any machine where
> pointer size is less than the size of two ints.

Makes sense.  Are you going to commit a fix or send a signed-off-by patch?

Stefan