From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45271) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YW7Fl-0004zL-NN for qemu-devel@nongnu.org; Thu, 12 Mar 2015 13:50:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YW7Fj-0007iO-Md for qemu-devel@nongnu.org; Thu, 12 Mar 2015 13:50:37 -0400 Received: from mail-ob0-x229.google.com ([2607:f8b0:4003:c01::229]:36106) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YW7Fj-0007iJ-Gc for qemu-devel@nongnu.org; Thu, 12 Mar 2015 13:50:35 -0400 Received: by obcva2 with SMTP id va2so15624157obc.3 for ; Thu, 12 Mar 2015 10:50:35 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1426170808-6343-1-git-send-email-stefanha@redhat.com> Date: Thu, 12 Mar 2015 17:50:34 +0000 Message-ID: From: Stefan Hajnoczi Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PULL v4 00/11] Net patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Peter Maydell , QEMU Developers , Stefan Hajnoczi On Thu, Mar 12, 2015 at 3:03 PM, Peter Maydell wrote: > On 12 March 2015 at 14:43, Peter Maydell wrote: >> On 12 March 2015 at 14:33, Stefan Hajnoczi wrote: >>> v4: >>> * Drop clang 3.5.0 fixes since they break with older clang and w32 [Peter] >>> >>> v3: >>> * Add clang 3.5.0 warning fixes >>> * Squash David Ahern's clang struct definition warnings fix >>> >>> v2: >>> * Squash in Jiri's fix for rocker format string specifiers [Peter] >>> * Squash in Windows build fix [Peter] >>> * Both build fixes are described in "rocker: add new rocker switch device" >>> >>> The following changes since commit ee74801035b0b5f1fdfd4e31d3a53f511f91c804: >>> >>> Merge remote-tracking branch 'remotes/lalrae/tags/mips-20150311' into staging (2015-03-11 18:22:15 +0000) >>> >>> are available in the git repository at: >>> >>> git://github.com/stefanha/qemu.git tags/net-pull-request >>> >>> for you to fetch changes up to 8d3f4f565fb4adf940a8824882a7f549304f34fd: >>> >>> rocker: timestamp on the debug logs helps correlate with events in the VM (2015-03-12 14:18:11 +0000) >> >> w32 build failure :-( >> >> cc1: warnings being treated as errors >> /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker.c: In >> function 'rocker_io_readq': >> /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker.c:1109: >> warning: integer constant is too large for 'long' type >> >> (64 bit constant without ULL suffix.) > > Also fails to build with our minimum glib version: > > /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_of_dpa.c: > In function 'of_dpa_init': > /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_of_dpa.c:2273: > error: 'g_int64_hash' undeclared (first use in this function) > /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_of_dpa.c:2273: > error: (Each undeclared identifier is reported only once > /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_of_dpa.c:2273: > error: for each function it appears in.) > /home/petmay01/linaro/qemu-for-merges/hw/net/rocker/rocker_of_dpa.c:2273: > error: 'g_int64_equal' undeclared (first use in this function) > > (Both first introduced in glib 2.22.) Hi Fam, This pull request contains patches that fail mingw compilation and glib version requirements. They passed in patchew: http://qemu.patchew.org/testing/log/%3C1426170808-6343-1-git-send-email-stefanha@redhat.com%3E Peter's build script is here: https://git.linaro.org/people/peter.maydell/misc-scripts.git/blob/HEAD:/remake-merge-builds It would be great to add build environments from Peter's script so that patchew can flag patches that will fail. Any thoughts? Do you need help with that? Stefan