All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: "Benoît Canet" <benoit.canet@irqsave.net>,
	qemu-devel <qemu-devel@nongnu.org>,
	"Benoit Canet" <benoit@irqsave.net>
Subject: Re: [Qemu-devel] [PATCH v2] qemu-iotests: Disable Quorum testing in 041 when Quorum is not builtin
Date: Tue, 1 Jul 2014 10:45:54 +0200	[thread overview]
Message-ID: <CAJSP0QUHdvcpuDnGNPHt=NSPyMsp1HEhKeoYaG13g8kPWGvTsg@mail.gmail.com> (raw)
In-Reply-To: <20140701081054.GB4587@noname.str.redhat.com>

On Tue, Jul 1, 2014 at 10:10 AM, Kevin Wolf <kwolf@redhat.com> wrote:
> Am 30.06.2014 um 16:09 hat Stefan Hajnoczi geschrieben:
>> On Fri, Jun 27, 2014 at 10:17:16PM +0200, Benoît Canet wrote:
>> I think this patch can be boiled down to 2 lines:
>>
>>  if __name__ == '__main__':
>> +    if 'quorum' not in iotests.qemu_img('--help'):
>> +        iotests.notrun('not built with quorum support')
>>      iotests.main(supported_fmts=['qcow2', 'qed'])
>>
>> What do you think?
>
> That would disable the whole test case 041, whereas Benoît's patch
> only disables the quorum-related part. (The test case is really about
> migration, not only quorum.)

Good point.  I thought about skipping TestRepairQuorum to avoid all
those if statements (which are also easy to forget when adding a new
test case) but it would be more hassle than just having the if
statements.

I now think the original approach was right, just simplify
has_quorum() using qemu_img_pipe() instead of using subprocess.

Stefan

  reply	other threads:[~2014-07-01  8:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-27 20:17 [Qemu-devel] [PATCH v2] qemu-iotests: Disable Quorum testing in 041 when Quorum is not builtin Benoît Canet
2014-06-27 20:23 ` Kevin Wolf
2014-06-30 14:09 ` Stefan Hajnoczi
2014-06-30 14:25   ` Benoît Canet
2014-07-01  7:28     ` Stefan Hajnoczi
2014-07-01  8:10   ` Kevin Wolf
2014-07-01  8:45     ` Stefan Hajnoczi [this message]
2014-07-01 11:34 Benoît Canet
2014-07-02  8:22 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJSP0QUHdvcpuDnGNPHt=NSPyMsp1HEhKeoYaG13g8kPWGvTsg@mail.gmail.com' \
    --to=stefanha@gmail.com \
    --cc=benoit.canet@irqsave.net \
    --cc=benoit@irqsave.net \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.