From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38332)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Sr9d2-0006y6-Af
	for qemu-devel@nongnu.org; Tue, 17 Jul 2012 11:24:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Sr9cx-0002Vf-KE
	for qemu-devel@nongnu.org; Tue, 17 Jul 2012 11:24:00 -0400
Received: from mail-lb0-f173.google.com ([209.85.217.173]:45426)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Sr9cx-0002Va-Cp
	for qemu-devel@nongnu.org; Tue, 17 Jul 2012 11:23:55 -0400
Received: by lbok6 with SMTP id k6so858528lbo.4
	for <qemu-devel@nongnu.org>; Tue, 17 Jul 2012 08:23:54 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1341307259-27262-1-git-send-email-harsh@linux.vnet.ibm.com>
References: <1341307259-27262-1-git-send-email-harsh@linux.vnet.ibm.com>
Date: Tue, 17 Jul 2012 16:23:54 +0100
Message-ID: <CAJSP0QUcEcP8O+=XBbbeZj9mTMrBxCoY_csxF6JjQZdgyR1rpA@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [Qemu-devel] [PATCH v7 0/3] Simpletrace v2: Support multiple
	args, strings.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Harsh Prateek Bora <harsh@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com

On Tue, Jul 3, 2012 at 10:20 AM, Harsh Prateek Bora
<harsh@linux.vnet.ibm.com> wrote:
> Existing simpletrace backend allows to trace at max 6 args and does not
> support strings. This newer tracelog format gets rid of fixed size records
> and therefore allows to trace variable number of args including strings.
>
> Sample trace:
> v9fs_version 0.000 tag=0xffff id=0x64 msize=0x2000 version=9P2000.L
> v9fs_version_return 6.705 tag=0xffff id=0x64 msize=0x2000 version=9P2000.L
> v9fs_attach 174.467 tag=0x1 id=0x68 fid=0x0 afid=0xffffffffffffffff
> uname=nobody aname=
> v9fs_attach_return 4720.454 tag=0x1 id=0x68 type=0xffffffffffffff80
> version=0x4f2a4dd0  path=0x220ea6

I have successfully tested it with the fix that I posted.  Writing
simpletrace.Analyzer Python scripts still works - now with string
arguments too :).

Besides the last few comments on Patch 2, this looks okay now.

Stefan