All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Goswin von Brederlow <goswin-v-b@web.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Support for multiboot images in elf64 (EM_X86_64) format
Date: Mon, 6 Feb 2012 12:38:14 +0000	[thread overview]
Message-ID: <CAJSP0QUwVhAoV7RE_tUONB7ZwY2Bk-s+D=obAr_ed2JrZOvpfw@mail.gmail.com> (raw)
In-Reply-To: <E1RtjZT-0007R7-Tw@frosties.localnet>

On Sat, Feb 4, 2012 at 5:38 PM, Goswin von Brederlow <goswin-v-b@web.de> wrote:
> Description: Allow 64bit elf binaries in multiboot format
>  This patch allows 64bit elf files with multiboot header to be loaded.
>  The entry point will still be called in 32bit mode and the kernel
>  must switch to 64bit mode on its own. The image and all modules must
>  also be located in the lower 2GB of ram. All the restrictions of a
>  32bit image still apply.
> Author: Goswin von Brederlow <goswin-v-b@web.de>
> Last-Updated: 2011-04-08
> ---

The multiboot specification is 32-bit only.  This patch enables a
non-standard 64-bit version of multiboot.  Have you checked whether
GRUB or other multiboot loaders have equivalent functionality?  Have
you contacted the multiboot specification authors?

> --- qemu-kvm-0.14.0+dfsg.orig/hw/multiboot.c
> +++ qemu-kvm-0.14.0+dfsg/hw/multiboot.c
> @@ -173,8 +173,7 @@ int load_multiboot(void *fw_cfg,
>         fclose(f);
>
>         if (((struct elf64_hdr*)header)->e_machine == EM_X86_64) {
> -            fprintf(stderr, "Cannot load x86-64 image, give a 32bit one.\n");
> -            exit(1);
> +           mb_debug("qemu: 64bit elf, I hope you know what you are doing\n");

This is silent by default, but given the nature of 64-bit multiboot
support I think this warning should be on by default.  Anyone using
this really needs to know what they are doing and QEMU should not
silently do weird things.

Stefan

  reply	other threads:[~2012-02-06 12:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-04 17:38 [Qemu-devel] Support for multiboot images in elf64 (EM_X86_64) format Goswin von Brederlow
2012-02-06 12:38 ` Stefan Hajnoczi [this message]
2012-02-08  9:53   ` Goswin von Brederlow
2012-02-08 11:30     ` Kevin Wolf
2012-02-08 12:06     ` Stefan Hajnoczi
2012-02-09  0:35       ` Paul Brook
2012-02-09 13:07         ` Goswin von Brederlow
2012-02-09 13:36           ` Paul Brook
2012-02-09 15:38             ` Goswin von Brederlow
2012-02-09 16:01               ` Paul Brook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJSP0QUwVhAoV7RE_tUONB7ZwY2Bk-s+D=obAr_ed2JrZOvpfw@mail.gmail.com' \
    --to=stefanha@gmail.com \
    --cc=goswin-v-b@web.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.