From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44881)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1c6kXD-0003FA-NK
	for qemu-devel@nongnu.org; Tue, 15 Nov 2016 15:40:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1c6kXD-0000EB-04
	for qemu-devel@nongnu.org; Tue, 15 Nov 2016 15:40:51 -0500
Received: from mail-it0-x241.google.com ([2607:f8b0:4001:c0b::241]:35388)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <stefanha@gmail.com>) id 1c6kXC-0000DR-Qs
	for qemu-devel@nongnu.org; Tue, 15 Nov 2016 15:40:50 -0500
Received: by mail-it0-x241.google.com with SMTP id b123so2683379itb.2
	for <qemu-devel@nongnu.org>; Tue, 15 Nov 2016 12:40:50 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <CAAo6VWN9uO9-jjEfHxLHCBE5V5tr5Sx52tGY5vu3g8JgcCRqvQ@mail.gmail.com>
References: <20161114150701.GD26198@stefanha-x1.localdomain>
	<20161114154906.GC2373@lemon>
	<20161114165034.GA1352@stefanha-x1.localdomain>
	<20161114180359.GA24217@lemon>
	<ff56438b-d75f-eb5a-c398-9ce1b20c2f40@redhat.com>
	<20161115020405.GB9226@lemon>
	<20161115101850.GA4836@stefanha-x1.localdomain>
	<20161115124417.GC9226@lemon>
	<20161115144551.GB17672@stefanha-x1.localdomain>
	<20161115150016.GD9226@lemon>
	<20161115192026.GA26428@stefanha-x1.localdomain>
	<CAAo6VWN9uO9-jjEfHxLHCBE5V5tr5Sx52tGY5vu3g8JgcCRqvQ@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Date: Tue, 15 Nov 2016 20:40:49 +0000
Message-ID: <CAJSP0QV-AGbuPKT87jpFNDqeJQVDiO-DcAhvpdM=75NJNUmJJw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v6 1/2] block/vxhs.c: Add support for a new
 block device type called "vxhs"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: ashish mittal <ashmit602@gmail.com>
Cc: Fam Zheng <famz@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Eric Blake <eblake@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Venkatesha.Mg@veritas.com, Ashish Mittal <ashish.mittal@veritas.com>, Jeff Cody <jcody@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Rakesh Ranjan <Rakesh.Ranjan@veritas.com>, Markus Armbruster <armbru@redhat.com>, Ketan Nilangekar <Ketan.Nilangekar@veritas.com>, Abhijit Dey <Abhijit.Dey@veritas.com>, Paolo Bonzini <pbonzini@redhat.com>, Buddhi.Madhav@veritas.com

On Tue, Nov 15, 2016 at 8:39 PM, ashish mittal <ashmit602@gmail.com> wrote:
> Thanks for concluding on this.
>
> I will rearrange the qnio_api.h header accordingly as follows:
>
> +#include "qemu/osdep.h"
> +#include <qnio/qnio_api.h>   <=== after osdep.h
> +#include "block/block_int.h"
> +#include "qapi/qmp/qerror.h"
> +#include "qapi/qmp/qdict.h"
> +#include "qapi/qmp/qstring.h"
> +#include "trace.h"
> +#include "qemu/uri.h"
> +#include "qapi/error.h"
> +#include "qemu/error-report.h"  <==== remove

Looks good.

Stefan