All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Zhi Yong Wu <zwu.kernel@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Bug 902148 <902148@bugs.launchpad.net>,
	qemu-devel@nongnu.org,
	Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [Bug 902148] Re: qemu-img V1.0 hangs on creating Image (0.15.1 runs)
Date: Sun, 15 Jan 2012 11:14:48 +0000	[thread overview]
Message-ID: <CAJSP0QVFat_YLxzvnr=HjgAkqkLrrdYG=-SM0-N_g0EW2xWWmw@mail.gmail.com> (raw)
In-Reply-To: <CAEH94Lgzdov+36ut8KLq6dBuP6a-0=C2whWhb24eX3xJCPrckw@mail.gmail.com>

On Sat, Jan 14, 2012 at 3:40 PM, Zhi Yong Wu <zwu.kernel@gmail.com> wrote:
> On Mon, Jan 9, 2012 at 9:00 PM, Stefan Hajnoczi <stefanha@gmail.com> wrote:
>> On Mon, Jan 9, 2012 at 11:25 AM, Kevin Wolf <kwolf@redhat.com> wrote:
>>> Am 20.12.2011 17:49, schrieb Stefan Hajnoczi:
>>>> On Tue, Dec 20, 2011 at 3:25 PM, Michael Niehren
>>>> <902148@bugs.launchpad.net> wrote:
>>>>> here we are. Attached the tgz. I am using no spezial distribution, it's a self compiled LFS with
>>>>> gcc V4.5.1
>>>>>
>>>>> Is there a different compiler-call if i use --enable-debug, which then
>>>>> works ?
>>>>
>>>> Richard Sandiford looked at your gcc -fdump-tree-all-details output
>>>> and suggests that this bug has been fixed in gcc 4.5.3:
>>>>
>>>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45967
>>>>
>>>> Using the most recent gcc should fix the issue you are seeing.
>>>
>>> Can we add some workaround? Not sure what will work, maybe a simple
>>> compiler barrier?
>>
>> Sure though it seems like a very rare case - OP was running Linux From
>> Scratch and hence got the broken gcc.  But if someone does a small
>> workaround and tests it then that would be nice.
> How to do this workaround in qemu since it is one gcc bug?

The problem is that that compiler keeps values in registers across a
point where C semantics require that they be reloaded.

There are several ways to force a compiler to reload values including
a barrier (which Kevin suggested) or the volatile keyword.  One of
these techniques can probably be used as a workaround, but it would be
necessary to check gcc 4.5.1 output to make sure it's effective.

I think it's not worth doing unless we think more users will be
affected.  Unless a distro ships the broken compiler version or it's
the latest gcc release that people would build from source, I bet the
number of users is very small.

Stefan

  reply	other threads:[~2012-01-15 11:14 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-09 13:10 [Qemu-devel] [Bug 902148] [NEW] qemu-img V1.0 hangs on creating Image (0.15.1 runs) Michael Niehren
2011-12-12 10:09 ` Stefan Hajnoczi
2011-12-19 10:02 ` [Qemu-devel] [Bug 902148] " Michael Niehren
2011-12-19 10:31   ` Stefan Hajnoczi
2011-12-19 10:52 ` Michael Niehren
2011-12-19 13:22   ` Stefan Hajnoczi
2011-12-19 17:26 ` Michael Niehren
2011-12-20  8:04   ` Stefan Hajnoczi
2011-12-20 10:17 ` Michael Niehren
2011-12-20 10:25 ` Michael Niehren
2011-12-20 10:49   ` Stefan Hajnoczi
2011-12-20 11:53     ` Stefan Hajnoczi
2011-12-20 15:25 ` Michael Niehren
2011-12-20 16:49   ` Stefan Hajnoczi
2011-12-20 21:45     ` Stefan Hajnoczi
2012-01-09 11:25     ` Kevin Wolf
2012-01-09 13:00       ` Stefan Hajnoczi
2012-01-14 15:40         ` Zhi Yong Wu
2012-01-15 11:14           ` Stefan Hajnoczi [this message]
2012-01-16  2:44             ` Zhi Yong Wu
2011-12-20 16:51 ` Stefan Hajnoczi
2011-12-20 23:59 ` Michael Niehren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJSP0QVFat_YLxzvnr=HjgAkqkLrrdYG=-SM0-N_g0EW2xWWmw@mail.gmail.com' \
    --to=stefanha@gmail.com \
    --cc=902148@bugs.launchpad.net \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    --cc=zwu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.