From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:36127)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QfAbA-0000qW-PX
	for qemu-devel@nongnu.org; Fri, 08 Jul 2011 08:56:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QfAb9-0006Iw-Ki
	for qemu-devel@nongnu.org; Fri, 08 Jul 2011 08:56:00 -0400
Received: from mail-yi0-f45.google.com ([209.85.218.45]:59808)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1QfAb9-0006Io-8z
	for qemu-devel@nongnu.org; Fri, 08 Jul 2011 08:55:59 -0400
Received: by yia25 with SMTP id 25so916412yia.4
	for <qemu-devel@nongnu.org>; Fri, 08 Jul 2011 05:55:58 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1309865478-32766-10-git-send-email-famcool@gmail.com>
References: <1309865478-32766-1-git-send-email-famcool@gmail.com>
	<1309865478-32766-10-git-send-email-famcool@gmail.com>
Date: Fri, 8 Jul 2011 13:55:57 +0100
Message-ID: <CAJSP0QWKcK5SdjBrQ18rzid2nAq_MLcK=3mbXJkcW22uNg5Pwg@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v8 09/12] VMDK: open/read/write for
	monolithicFlat image
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famcool@gmail.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, hch@lst.de

On Tue, Jul 5, 2011 at 12:31 PM, Fam Zheng <famcool@gmail.com> wrote:
> + =A0 =A0 =A0 =A0ret =3D sscanf(p, "%10s %lld %10s %512s",
[...]
> + =A0 =A0 =A0 =A0 =A0 =A0ret =3D sscanf(p, "%10s %lld %10s %511s %lld",

%512s -> %511s

But instead of duplicating the format string and sscanf(3), I suggest
doing sscanf(p, "%10s %lld %10s %511s %lld", ...) once only.

After it returns you can check:
if (ret < 4) {
    ...fail...
} else if (!strcmp(access, "FLAT")) {
    if (ret !=3D 5 || flat_offset < 0) {
        ...fail...
    }
} else {
    if (ret !=3D 4) {
        ...fail...
    }
}

Stefan