All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Cindy Lu <lulu@redhat.com>
Cc: rdunlap@infradead.org, Michael Tsirkin <mst@redhat.com>,
	mhabets@solarflare.com, qemu-devel <qemu-devel@nongnu.org>,
	rob.miller@broadcom.com, saugatm@xilinx.com,
	Markus Armbruster <armbru@redhat.com>,
	Christoph Hellwig <hch@infradead.org>,
	Eugenio Perez Martin <eperezma@redhat.com>,
	jgg@mellanox.com, Jason Wang <jasowang@redhat.com>,
	Shahaf Shuler <shahafs@mellanox.com>,
	"Tian, Kevin" <kevin.tian@intel.com>,
	parav@mellanox.com, vmireyno@marvell.com, "Liang,
	Cunming" <cunming.liang@intel.com>,
	gdawar@xilinx.com, jiri@mellanox.com, "Wang,
	Xiao W" <xiao.w.wang@intel.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	"Wang, Zhihong" <zhihong.wang@intel.com>,
	Maxime Coquelin <maxime.coquelin@redhat.com>,
	Tiwei Bie <tiwei.bie@intel.com>, Ariel Adam <aadam@redhat.com>,
	Cornelia Huck <cohuck@redhat.com>,
	hanand@xilinx.com, "Zhu, Lingshan" <lingshan.zhu@intel.com>
Subject: Re: [RFC v2 5/9] vhost-vdpa: implement vhost-vdpa backend
Date: Mon, 25 May 2020 17:15:35 +0100	[thread overview]
Message-ID: <CAJSP0QWSk2kYoYKvtkAdeR8ohLX7rnqVem5o-5z1aAqv5axMKA@mail.gmail.com> (raw)
In-Reply-To: <CACLfguUVO_zhZbrZ2bW--i5KrP+Yxe0EQwOCrtihSDqRADOKfA@mail.gmail.com>

On Mon, May 25, 2020 at 4:34 PM Cindy Lu <lulu@redhat.com> wrote:
> On Thu, May 21, 2020 at 8:40 PM Stefan Hajnoczi <stefanha@gmail.com> wrote:
> > On Sat, May 09, 2020 at 12:32:14AM +0800, Cindy Lu wrote:
> > > From: Tiwei Bie <tiwei.bie@intel.com>
> > >
> > > Currently we have 2 types of vhost backends in QEMU: vhost kernel and
> > > vhost-user. The above patch provides a generic device for vDPA purpose,
> > > this vDPA device exposes to user space a non-vendor-specific configuration
> > > interface for setting up a vhost HW accelerator, this patch set introduces
> > > a third vhost backend called vhost-vdpa based on the vDPA interface.
> > >
> > > Vhost-vdpa usage:
> > >
> > >   qemu-system-x86_64 -cpu host -enable-kvm \
> > >     ......
> > >   -netdev type=vhost-vdpa,vhostdev=/dev/vhost-vdpa-id,id=vhost-vdpa0 \
> > >   -device virtio-net-pci,netdev=vhost-vdpa0,page-per-vq=on \
> >
> > I haven't looked at vDPA in depth. What is different here compared to
> > the existing vhost-backend.c kernel backend?
> >
> > It seems to be making the same ioctls calls so I wonder if it makes
> > sense to share the vhost-backend.c kernel code?
> >
> > Stefan
> Hi Stefan,
> Sorry for the late reply and Thanks for these suggestions.
> I think the most difference between vhost kernel and vdpa is vdpa
> depends on a real hardware.
> The point is that vDPA devices work as a virtio device, but vhost-vdpa
> qemu must present a vhost-like device in qemu vhost layer.
> The ioctl  calls are similar  with vhost-backend.c now, but after more
> and more NIC support vdpa. The difference between vhost-backend.c and
> vpda will become more and more big. It will make the code complicated
> to share the  code with kernel code.

Okay, thanks.

Stefan


  reply	other threads:[~2020-05-25 16:17 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-08 16:32 [RFC v2 0/9] vDPA support in qemu Cindy Lu
2020-05-08 16:32 ` [RFC v2 1/9] net: introduce qemu_get_peer Cindy Lu
2020-05-08 16:32 ` [RFC v2 2/9] net: use the function qemu_get_peer Cindy Lu
2020-05-09  2:19   ` Jason Wang
2020-05-09  6:49     ` Cindy Lu
2020-05-08 16:32 ` [RFC v2 3/9] virtio_net: introduce vhost_set_state Cindy Lu
2020-05-09  2:25   ` Jason Wang
2020-05-09  7:08     ` Cindy Lu
2020-05-08 16:32 ` [RFC v2 4/9] vhost-vdpa: introduce vhost-vdpa net client Cindy Lu
2020-05-08 16:41   ` Eric Blake
2020-05-09  7:17     ` Cindy Lu
2020-05-09  2:40   ` Jason Wang
2020-05-09  7:31     ` Cindy Lu
2020-05-08 16:32 ` [RFC v2 5/9] vhost-vdpa: implement vhost-vdpa backend Cindy Lu
2020-05-09  3:00   ` Jason Wang
2020-05-09  3:07     ` Jason Wang
2020-05-09  8:14     ` Cindy Lu
2020-05-21 12:40   ` Stefan Hajnoczi
2020-05-25 15:33     ` Cindy Lu
2020-05-25 16:15       ` Stefan Hajnoczi [this message]
2020-05-08 16:32 ` [RFC v2 6/9] virtio-bus: introduce queue_enabled method Cindy Lu
2020-05-09  3:01   ` Jason Wang
2020-05-09  6:50     ` Cindy Lu
2020-05-08 16:32 ` [RFC v2 7/9] virito-pci: implement " Cindy Lu
2020-05-09  3:02   ` Jason Wang
2020-05-09 12:01   ` Philippe Mathieu-Daudé
2020-05-11  5:08     ` Cindy Lu
2020-05-08 16:32 ` [RFC v2 8/9] vhost_net: set vq ready during start if necessary Cindy Lu
2020-05-09  3:03   ` Jason Wang
2020-05-09  6:51     ` Cindy Lu
2020-05-08 16:32 ` [RFC v2 9/9] vhost: introduce vhost_set_vring_ready method Cindy Lu
2020-05-09  3:05   ` Jason Wang
2020-05-09  3:10 ` [RFC v2 0/9] vDPA support in qemu Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJSP0QWSk2kYoYKvtkAdeR8ohLX7rnqVem5o-5z1aAqv5axMKA@mail.gmail.com \
    --to=stefanha@gmail.com \
    --cc=aadam@redhat.com \
    --cc=armbru@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=cunming.liang@intel.com \
    --cc=eperezma@redhat.com \
    --cc=gdawar@xilinx.com \
    --cc=hanand@xilinx.com \
    --cc=hch@infradead.org \
    --cc=jasowang@redhat.com \
    --cc=jgg@mellanox.com \
    --cc=jiri@mellanox.com \
    --cc=kevin.tian@intel.com \
    --cc=lingshan.zhu@intel.com \
    --cc=lulu@redhat.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=mhabets@solarflare.com \
    --cc=mst@redhat.com \
    --cc=parav@mellanox.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rdunlap@infradead.org \
    --cc=rob.miller@broadcom.com \
    --cc=saugatm@xilinx.com \
    --cc=shahafs@mellanox.com \
    --cc=stefanha@redhat.com \
    --cc=tiwei.bie@intel.com \
    --cc=vmireyno@marvell.com \
    --cc=xiao.w.wang@intel.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.