From: Stefan Hajnoczi <stefanha@gmail.com>
To: Patrick Jackson <patricksjackson@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 06/11] Goldfish: Added a nand controller.
Date: Mon, 22 Aug 2011 13:04:38 +0100 [thread overview]
Message-ID: <CAJSP0QWYeKas=GhfwGXV8uR61P1PueD4_S9ZQ1RTNOxGXHV1qQ@mail.gmail.com> (raw)
In-Reply-To: <CAKspZ_vVt29xL27YHeG2vX3xiPis_QVQ2Pg_beXXLH+V-r3XNA@mail.gmail.com>
On Mon, Aug 22, 2011 at 10:39 AM, Patrick Jackson
<patricksjackson@gmail.com> wrote:
>
> The paths to the system images must be specified from the command line as
> follows.
> -global goldfish_nand.system_init_path=/path/to/initial/system/image -global
> goldfish_nand.user_data_path=/path/to/user/data
> Signed-off-by: Patrick Jackson <PatrickSJackson@gmail.com>
> ---
> Makefile.target | 2 +-
> hw/android_arm.c | 2 +
> hw/goldfish_device.c | 1398
> ++++++++++++++++++++++++++++++++++++++++++++++++
> hw/goldfish_device.h | 205 +++++++
> hw/goldfish_nand.c | 914 +++++++++++++++++++++++++++++++
> hw/goldfish_nand.h | 29 +
> hw/goldfish_nand_reg.h | 54 ++
> 7 files changed, 2603 insertions(+), 1 deletions(-)
> create mode 100644 hw/goldfish_nand.c
> create mode 100644 hw/goldfish_nand.h
> create mode 100644 hw/goldfish_nand_reg.h
Please use the block layer instead of reinventing portable file I/O.
Also, please check which of the utility functions already exist in
QEMU. If a utility function in this patch is needed it should be made
generic for all of QEMU, not just goldfish or nand.
Stefan
next prev parent reply other threads:[~2011-08-22 12:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-22 9:39 [Qemu-devel] [PATCH 06/11] Goldfish: Added a nand controller Patrick Jackson
2011-08-22 12:04 ` Stefan Hajnoczi [this message]
2011-08-22 14:16 ` Paolo Bonzini
2011-08-22 20:41 ` Stefan Hajnoczi
2011-08-23 7:17 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJSP0QWYeKas=GhfwGXV8uR61P1PueD4_S9ZQ1RTNOxGXHV1qQ@mail.gmail.com' \
--to=stefanha@gmail.com \
--cc=patricksjackson@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.