From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51361)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1S223X-00023U-KS
	for qemu-devel@nongnu.org; Mon, 27 Feb 2012 10:00:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1S223R-0003dR-3F
	for qemu-devel@nongnu.org; Mon, 27 Feb 2012 10:00:03 -0500
Received: from mail-lpp01m010-f45.google.com ([209.85.215.45]:35104)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1S223Q-0003dG-Q6
	for qemu-devel@nongnu.org; Mon, 27 Feb 2012 09:59:57 -0500
Received: by lahe6 with SMTP id e6so376950lah.4
	for <qemu-devel@nongnu.org>; Mon, 27 Feb 2012 06:59:55 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <CAJSP0QWjEhJT0uVm8bE8wN3yGeZq51uXevrqTZuS02K-k8RgcA@mail.gmail.com>
References: <1329930815-7995-1-git-send-email-fsimonce@redhat.com>
	<1329930815-7995-2-git-send-email-fsimonce@redhat.com>
	<CAJSP0QWqXYsE3dUm2k_OqQaXoZMd2LggTA3saBABxuW61ajtFA@mail.gmail.com>
	<CAJSP0QUDsNsD9wmpFeAKYK81Es6cWiv32e=p6xdX4efHpyjBQg@mail.gmail.com>
	<4F4B6AFE.6090601@redhat.com>
	<CAJSP0QVWgtaBH-vWeHX59OqCvTOMYkMWorgzsmT=3GSRBFEegg@mail.gmail.com>
	<4F4B6D99.3090305@redhat.com>
	<CAJSP0QUEy-Nyds7EM17QSyst2_6xEw9gjjSVyxGbp7E4scMv3A@mail.gmail.com>
	<4F4B8957.7060404@redhat.com>
	<CAJSP0QWjEhJT0uVm8bE8wN3yGeZq51uXevrqTZuS02K-k8RgcA@mail.gmail.com>
Date: Mon, 27 Feb 2012 14:59:55 +0000
Message-ID: <CAJSP0QXDjrPKqGhMqJJCYPOAmeDQqcCP7ivkmnFj_93E-oqK4Q@mail.gmail.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/3] Add blkmirror block driver
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kwolf@redhat.com, Federico Simoncelli <fsimonce@redhat.com>, mtosatti@redhat.com, qemu-devel@nongnu.org

On Mon, Feb 27, 2012 at 2:49 PM, Stefan Hajnoczi <stefanha@gmail.com> wrote=
:
> On Mon, Feb 27, 2012 at 1:47 PM, Paolo Bonzini <pbonzini@redhat.com> wrot=
e:
>> On 02/27/2012 02:09 PM, Stefan Hajnoczi wrote:
>> 3) blkverify in the future could add callbacks to create snapshots or
>> load/save imgstate, and forward them to the test file; this doesn't make
>> sense for blkmirror.
>
> I guess what I'm saying is, if we need to copy-paste in order to fork
> them in the future that's fine, but why maintain duplicates in the
> mean-time? =A0Please make the codebase nice today. =A0We can always exten=
d
> it in the future, we're not forced to keep them unified forever if it
> turns out we want to split them. =A0But as it stands they are
> essentially the same thing.

BTW, I feel that I may just be missing context on what the plans are
around mirroring and block migration.  Is there a plan or discussions
that haven't hit qemu-devel (maybe they were done in ovirt or
internally)?

Stefan