On Jan 25, 2021 3:58 PM, "Pete= r Kjellerstedt" <pet= er.kjellerstedt@axis.com> wrote:
> -----Original Message-----
> From: open= embedded-core@lists.openembedded.org <openembedded-
> core@lists.openembedded= .org> On Behalf Of Quentin Schulz
> Sent: den 25 januari 2021 10:22
> To: Dorinda <dorindabass= ey@gmail.com>
> Cc: openem= bedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [PATCH 5/5] sanity.bbclass: verify that user is= n't
> building in PSEUDO_IGNORE_PATHS
>
> Hi Dorinda,
>
> On Sun, Jan 24, 2021 at 02:55:59PM +0100, Dorinda wrote:
> > added a check to ensure that a user isn't building in
> PSEUDO_IGNORE_PATHS
> >
>
> Missing [YOCTO #14179] tag I think :)
>
> > Signed-off-by: Dorinda Bassey <dorindabassey@gmail.com>
> > ---
> >=C2=A0 meta/classes/sanity.bbclass | 7 +++++++
> >=C2=A0 1 file changed, 7 insertions(+)
> >
> > diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bb= class
> > index 2040b48595..78c0343f0d 100644
> > --- a/meta/classes/sanity.bbclass
> > +++ b/meta/classes/sanity.bbclass
> > @@ -703,6 +703,13 @@ def check_sanity_version_change(status,= d):
> >=C2=A0 =C2=A0 =C2=A0 if (tmpdirmode & stat.S_ISUID):
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 status.addresult("TMPDIR i= s setuid, please don't build in a setuid directory")
> >
> > +=C2=A0 =C2=A0 # Check that user isn't building in PSEUDO_IGN= ORE_PATHS
> > +=C2=A0 =C2=A0 pseudoignorepaths =3D d.getVar('PSEUDO_IGNORE_= PATHS', expand=3DTrue).split(",")
> > +=C2=A0 =C2=A0 workdir =3D d.getVar('WORKDIR', expand=3DT= rue)
> > +=C2=A0 =C2=A0 for i in pseudoignorepaths:
> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 if workdir.startswith(i):

PSEUDO_IGNORE_PATHS may contain empty paths (i.e., from multiple
consecutive commas, or a trailing commas). Pseudo will ignore these
paths, so this code should ignore them too:

=C2=A0 =C2=A0 =C2=A0 =C2=A0 if i and workdir.startswith(i):

> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 status.addresult("= ;you are building in a path under PSEUDO_IGNORE_PATHS, please remove this&q= uot; + str(i) + "directory in \nParsed WORKDIR: " + str(workdir) = + "\n")
>
> Capital Y for the beginning of the sentence?
>
> Missing space before and after str(i).
>
> I'm not familiar with this part of the code, so forgive me if this= is
> wrong but... is your sentence finished?
>
> You are building in a path under PSEUDO_IGNORE_PATHS, please remove th= is <dir> directory in
> Parsed WORKDIR: <workdir>
>
> That is to me not very telling about what I should do to fix this issu= e.
>
> I honestly might be missing a lot of context on the issue so wouldn= 9;t be
> surprised if the issue is with me not understanding the sentence more<= br> > than the sentence being "unfinished".

No, I don't think you are wrong. I do not understand it either.

> Thanks,
> Quentin

//Peter