From: Vijay Khemka <vijaykhemkalinux@gmail.com>
To: "Harvey Wu (吳崇維)" <Harvey.Wu@quantatw.com>
Cc: "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
Lei Yu <yulei.sh@bytedance.com>
Subject: Re: [phosphor-virtual-sensor] Add new feature to get Warning or Critical property
Date: Tue, 29 Dec 2020 21:02:03 -0800 [thread overview]
Message-ID: <CAJTGxZHhbRs7pedZ+Ag8v7WACzXYyg43ZKYNWB75VywzoaSbpA@mail.gmail.com> (raw)
In-Reply-To: <TY2PR04MB39337E262BA43CA7378F2B6C95D70@TY2PR04MB3933.apcprd04.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1932 bytes --]
I am not understanding why you want to use threshold values to calculate
new sensor values. We can certainly add this feature but it can not be
based on name rather we have to think differently to get. It would really
help to decide on design once we know it's actual usage. I can't think of
any situation here.
Regards
-Vijay
On Tue, Dec 29, 2020 at 6:49 PM Harvey Wu (吳崇維) <Harvey.Wu@quantatw.com>
wrote:
> > On Wed, Dec 30, 2020 at 10:19 AM Harvey Wu (吳崇維)
> > <Harvey.Wu@quantatw.com> wrote:
> > >
> > > Hi All,
> > >
> > >
> > >
> > > The current phosphor-virtual-sensor DbusParam value is from
> > DBus “Value” property which interface is
> > “xyz.openbmc_project.Sensor.Value”.
> > >
> > > Because I want to get the property “CriticalHigh” value on DBus, could
> I
> > add a new feature “Interface” property in json file? The property can be
> > “CriticalHigh” , “CriticalLow” , “WarningHigh” or “WarningLow”.
> >
> >
> > According to
> > https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub
> .
> > com%2Fopenbmc%2Fphosphor-virtual-sensor%2Fblob%2Fmaster%2Fvirtual_
> > sensor_config.json%23L8-L14&data=04%7C01%7CHarvey.Wu%40quantat
> > w.com%7C1479ebd5aedd4b8a7c3308d8ac6a4393%7C179b032707fc4973ac73
> > 8de7313561b2%7C1%7C0%7C637448919693850853%7CUnknown%7CTWFpb
> > GZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6
> > Mn0%3D%7C1000&sdata=0KyrnRkZKr9M59DEg%2BnyUruiege%2B3EDXb
> > mxzR%2B6xeng%3D&reserved=0,
> > the threshold properties are already supported.
>
> The "Threshold" in json seems only can set the sensor critical or warning
> value, but I want to use the critical or warning value in "Expression".
> After check the newest commit, this function seems doesn't implement in
> current source code.
>
> >
> > --
> > BRs,
> > Lei YU
>
>
> Harvey Wu
>
[-- Attachment #2: Type: text/html, Size: 2711 bytes --]
next prev parent reply other threads:[~2020-12-30 5:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-30 2:18 [phosphor-virtual-sensor] Add new feature to get Warning or Critical property Harvey Wu (吳崇維)
2020-12-30 2:25 ` Lei Yu
2020-12-30 2:47 ` Harvey Wu (吳崇維)
2020-12-30 5:02 ` Vijay Khemka [this message]
2020-12-30 6:13 ` Harvey Wu (吳崇維)
2020-12-30 20:47 ` Vijay Khemka
2020-12-30 21:05 ` Ed Tanous
2020-12-30 21:03 ` Ed Tanous
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJTGxZHhbRs7pedZ+Ag8v7WACzXYyg43ZKYNWB75VywzoaSbpA@mail.gmail.com \
--to=vijaykhemkalinux@gmail.com \
--cc=Harvey.Wu@quantatw.com \
--cc=openbmc@lists.ozlabs.org \
--cc=yulei.sh@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.