From: "Burton, Ross" <ross.burton@intel.com>
To: Laurentiu Palcu <laurentiu.palcu@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v2 1/1] xinput-calibrator: move it from meta-oe to oe-core
Date: Tue, 2 Jul 2013 16:25:19 +0100 [thread overview]
Message-ID: <CAJTo0LZ=m=no=aiTcBqgGM_J0b5t429xkztCO1gkf-z2hC7UPg@mail.gmail.com> (raw)
In-Reply-To: <b2b193d7632393d1a1ac091ce01eb9d93d44886b.1372686507.git.laurentiu.palcu@intel.com>
On 1 July 2013 14:57, Laurentiu Palcu <laurentiu.palcu@intel.com> wrote:
> +do_install() {
> + # Only install file if it has a contents
> + if [ -s ${S}/pointercal.xinput ]; then
> + install -d ${D}${sysconfdir}/
> + install -m 0644 ${S}/pointercal.xinput ${D}${sysconfdir}/
> + fi
> +}
The file always has content because the file in the main recipe has a
comment in. Personally I think not installing a useless file is the
right thing to do, so we should change the default pointercal.xinput
to be empty.
Relatedly, interestingly Weston has a different approach and attaches
the calibration to the device using udev properties, which means
systems where touch devices can be hotplugged actually work. I'm
incredibly tempted to extend xinput-calibrator to write out udev
fragments and make Xi respect them if they exist...
> +++ b/meta/recipes-graphics/xinput-calibrator/xinput-calibrator_git.bb
> +inherit autotools systemd
systemd?
> +RPROVIDES_${PN} += "${PN}-systemd"
> +RREPLACES_${PN} += "${PN}-systemd"
> +RCONFLICTS_${PN} += "${PN}-systemd"
It doesn't anymore, so these can be dropped.
Ross
next prev parent reply other threads:[~2013-07-02 15:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 12:26 [PATCH 0/1] xinput-calibrator: move it from meta-oe to oe-core Laurentiu Palcu
2013-06-17 12:26 ` [PATCH 1/1] " Laurentiu Palcu
2013-06-17 15:15 ` Burton, Ross
2013-06-18 10:58 ` Laurentiu Palcu
2013-06-18 13:02 ` Burton, Ross
2013-07-01 13:57 ` [PATCH v2 0/1] " Laurentiu Palcu
2013-07-01 13:57 ` [PATCH v2 1/1] " Laurentiu Palcu
2013-07-02 15:25 ` Burton, Ross [this message]
2013-07-02 16:21 ` Laurentiu Palcu
2013-07-02 16:31 ` Burton, Ross
2013-07-02 16:50 ` Martin Jansa
2013-07-02 17:01 ` Paul Eggleton
2013-07-12 12:04 ` [PATCH v3 0/1] xinput-calibrator: move it from meta-oe to oe-core (cover letter only) Laurentiu Palcu
2013-07-17 12:40 ` Paul Eggleton
2013-07-22 14:13 ` [PATCH v4 " Laurentiu Palcu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJTo0LZ=m=no=aiTcBqgGM_J0b5t429xkztCO1gkf-z2hC7UPg@mail.gmail.com' \
--to=ross.burton@intel.com \
--cc=laurentiu.palcu@intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.