All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Burton, Ross" <ross.burton@intel.com>
To: Hongxu Jia <hongxu.jia@windriver.com>
Cc: Paul Eggleton <paul.eggleton@linux.intel.com>,
	OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 2/2] distutils3/setuptools3-native: do not try to fetch code during do_compile
Date: Tue, 17 Jul 2018 12:13:26 +0100	[thread overview]
Message-ID: <CAJTo0LZW2UdP221rM_z5f2Eq5uyc65hbYZUOUDmz8CZn-o4G_w@mail.gmail.com> (raw)
In-Reply-To: <dfc75ebfb9a5282585d621ea66b4590dbb8b6b17.1531798346.git.hongxu.jia@windriver.com>

On 17 July 2018 at 04:34, Hongxu Jia <hongxu.jia@windriver.com> wrote:
>  distutils3_do_compile() {
> +        NO_FETCH_BUILD=1 \
> +        NO_FETCH_BUILD_HELP="Please add its native recipe to DEPENDS." \

...

> +     def easy_install(self, spec, deps=False):
> ++        if os.environ.get('NO_FETCH_BUILD', None):
> ++            log.error("ERROR: Do not try to fetch `%s' for building. %s" %
> ++                             (spec,  os.environ.get('NO_FETCH_BUILD_HELP', '')))

Passing the help to the patch seems overkill considering we're
patching in the message in the first place.  Why not just put this in
the patch itself?

> +SRC_URI_append_class-native = " file://0001-conditionally-do-not-fetch-code-by-easy_install.patch"

Do this in setuptools.inc and you won't need to patch both recipes.

Ross


  reply	other threads:[~2018-07-17 11:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-17  3:34 [PATCH 0/2] distutils/setuptools:fix recipes may try to fetch code during do_compile Hongxu Jia
2018-07-17  3:34 ` [PATCH 1/2] distutils/setuptools-native: do not " Hongxu Jia
2018-07-17  3:34 ` [PATCH 2/2] distutils3/setuptools3-native: " Hongxu Jia
2018-07-17 11:13   ` Burton, Ross [this message]
2018-07-17 13:36     ` [PATCH V2] distutils/setuptools-native, " Hongxu Jia
2018-07-27 11:38       ` Martin Jansa
2018-07-27 11:41         ` Derek Straka
2018-07-27 12:43           ` Derek Straka
2018-07-27 13:29             ` Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJTo0LZW2UdP221rM_z5f2Eq5uyc65hbYZUOUDmz8CZn-o4G_w@mail.gmail.com \
    --to=ross.burton@intel.com \
    --cc=hongxu.jia@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=paul.eggleton@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.