From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f53.google.com (mail-it0-f53.google.com [209.85.214.53]) by mail.openembedded.org (Postfix) with ESMTP id 8477A78745 for ; Mon, 11 Dec 2017 17:31:42 +0000 (UTC) Received: by mail-it0-f53.google.com with SMTP id b5so17747504itc.3 for ; Mon, 11 Dec 2017 09:31:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=i51YpcosCi1QVnzUwVyvg5mDthPXLdvvXt5LnNcz5UU=; b=xzZk2XaKe4Ua2Vu5bNcyrnCO8Q2873AKNd9fN4DhJFXPOo8GCdFI2F0IYHumPkvZe7 LCSSnu+dmxpy3sWNc8oOzProFjddDd7XuAcn/b0CGmozZ+BuFLOUvMjR4tBpPMV+GT7S o6pCmb7GeT7RkshTgemdL05yDx53qKueUpPJBl76bb+EYnTbB2d/P7lbhp2M1rFEwvt4 6SkbnuyMPujz3H4jU2m3LzRGl3y9GI3wKKUvvJewyW8njrpuIGDYbrkUD9S4Q8n93HBh ZFnbWoankvJxyyr27zjwzbbDdNvk1RdDGvo7+uuISja3fE/2d5CFIYBMqd1n98ldeQiY 0eug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=i51YpcosCi1QVnzUwVyvg5mDthPXLdvvXt5LnNcz5UU=; b=YxpJJaZBe86qWrw1DiczMqdqqID20agZdz6ZTFtYoV1wB+bhifevWEyIgvzyBr6iQl f5QRJiHqnd8WOkwXADIc2o8OjYr+Ff2EmwSSQ8HRYpk5reR9ZY289SBz0lTfPGecfj6K 4TdQ7R0dakIYLH8JT10zg2jdHa2AFCp/fAQMSVMFi1KGkEztSlWmM6gkZju/KHnhU8t+ DT06tJ7ZgEC9SEfzs/sHI2Jq4jnKydydhnMAWPcE7MKuZekNrbX3fytaWnCB281Om5Zu PK9oyNH6ZdnIHW8K+AibgqK9fzdzxSTTZtW5yFMKNm5mxQbjNs8yvLuIMtSY5uFJfaze dNSw== X-Gm-Message-State: AKGB3mKs8h2Ih5Wml6xfms86MCik9E/SIkY6mut3BJ99JYVuYj0A27Fa Y0rDugu8Q7PBVmCBwDqJogJry/ivp89gxRDSAxaGHg== X-Google-Smtp-Source: ACJfBoubTKr9yXVEqn7czSSjmmsW5XIIzHkrq9qGqxtHRT1dRbcepNT59cTfe2XN669H2vI04axMgpV0H3jRwhFidcY= X-Received: by 10.36.17.15 with SMTP id 15mr2117965itf.53.1513013503737; Mon, 11 Dec 2017 09:31:43 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.137.195 with HTTP; Mon, 11 Dec 2017 09:31:23 -0800 (PST) In-Reply-To: <91239d937858880057ddc741cc6a80fda699575b.1512765610.git.jair.de.jesus.gonzalez.plascencia@linux.intel.com> References: <91239d937858880057ddc741cc6a80fda699575b.1512765610.git.jair.de.jesus.gonzalez.plascencia@linux.intel.com> From: "Burton, Ross" Date: Mon, 11 Dec 2017 17:31:23 +0000 Message-ID: To: Jair Gonzalez Cc: OE-core Subject: Re: [PATCH V4 1/2] imagefeatures.py: Added testcase to track IMAGE_GEN_DEBUGFS X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Dec 2017 17:31:42 -0000 Content-Type: multipart/alternative; boundary="001a11445d686e5d12056013e8f7" --001a11445d686e5d12056013e8f7 Content-Type: text/plain; charset="UTF-8" On 8 December 2017 at 21:03, Jair Gonzalez < jair.de.jesus.gonzalez.plascencia@linux.intel.com> wrote: > + def test_image_gen_debugfs(self): > + """ > + Summary: Check debugfs generation > + Expected: 1. core-image-minimal can be build with > IMAGE_GEN_DEBUGFS variable set > + 2. debug filesystem is created when variable set > + Product: oe-core > + Author: Humberto Ibarra > + """ > + > + image_name = 'core-image-minimal' > + deploy_dir_image = get_bb_var('DEPLOY_DIR_IMAGE') > + > + features = 'IMAGE_GEN_DEBUGFS = "1"\n' > + features += 'IMAGE_FSTYPES_DEBUGFS = "tar.bz2"' > + self.write_config(features) > + > + bitbake(image_name) > + debug_files = glob.glob(os.path.join(deploy_ > dir_image,"*-dbg.rootfs.tar.bz2")) > + self.assertNotEqual(len(debug_files), 0, 'debug filesystem not > generated') Checking the file exists doesn't really exercise the codepaths, it should at least verify the tarball contains the debug symbols for some packages that are in that image. Ross --001a11445d686e5d12056013e8f7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On 8 December 2017 at 21:03, Jair Gonzalez <jair.de.jesus.gonzalez.plascencia@linux.intel.com>= ; wrote:
+=C2=A0 =C2=A0 def test_image_gen_debugfs(self= ):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 """
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 Summary:=C2=A0 =C2=A0 =C2=A0Check debugfs gene= ration
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 Expected:=C2=A0 =C2=A0 1. core-image-minimal c= an be build with IMAGE_GEN_DEBUGFS variable set
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A02. debug filesystem is created when variable set
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 Product:=C2=A0 =C2=A0 =C2=A0oe-core
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 Author:=C2=A0 =C2=A0 =C2=A0 Humberto Ibarra &l= t;humberto.ibarra.lopez@= intel.com>
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 """
+
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 image_name =3D 'core-image-minimal' +=C2=A0 =C2=A0 =C2=A0 =C2=A0 deploy_dir_image =3D get_bb_var('DEPLOY_DI= R_IMAGE')
+
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 features =3D 'IMAGE_GEN_DEBUGFS =3D "= 1"\n'
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 features +=3D 'IMAGE_FSTYPES_DEBUGFS =3D &= quot;tar.bz2"'
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.write_config(features)
+
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 bitbake(image_name)
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 debug_files =3D glob.glob(os.path.join(deploy_= dir_image,"*-dbg.rootfs.tar.bz2"))
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.assertNotEqual(len(debug_files), 0, = 'debug filesystem not generated')

C= hecking the file exists doesn't really exercise the codepaths, it shoul= d at least verify the tarball contains the debug symbols for some packages = that are in that image.

Ross
--001a11445d686e5d12056013e8f7--