From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f181.google.com (mail-io0-f181.google.com [209.85.223.181]) by mail.openembedded.org (Postfix) with ESMTP id CC459788B1 for ; Tue, 20 Mar 2018 09:02:50 +0000 (UTC) Received: by mail-io0-f181.google.com with SMTP id e7so1401552iof.2 for ; Tue, 20 Mar 2018 02:02:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=2J4K4ef/PIQaQFW5CL8gFi964Bk3aQlab758GGMslbs=; b=r+y1Zp5d4F2xJ5Ryb5N+E7e4iadxHlKkxfXCaWjF6m18UMFwAbLQdKzp6cE/jSD1hC 2DW9TWxmmgpBY5QHV8P69gyq9F/Ps7ENGXPGq4QSOgMGuxe6t3ZUyAyo8Pn/3w+rFCbt 0QGUYoqmS/tsw7H3sVe6vMF2zozpA9+3vBBpEC64YyThnMobPoCzYEVgBORqAySOMqSm WXHEPTGl1/rzJpCxuS9Xb2h9e4M/2YA/lWpXRJOBxoC87Bn2fAY4yn03C3ZPcy4RpBoS X4EBglmJoYK0+GmyaAdeh2xCnQdK68DQu5zy11UpYweBKkqFB31codBLmS3a6G/0grKF jbPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=2J4K4ef/PIQaQFW5CL8gFi964Bk3aQlab758GGMslbs=; b=diUajToDiA9vHflOlWAjI395JxgLC4aJB0+txFxY6Agx06WgHZjgQ4OfENZsnyNWgo nIIiBoSShZxRIBrGHdzl3RBNfxtr8Mgdl2VeMSJWO3+s2LTDONl7mcIc3bxalMtLQk1C KheE866+2GaCzVoAAWHzzejBXdBJ82H08vMViW90aMsOu7cJRJ60IwaNLf/0Z0duyWdz 8e9E5FGpIuXZjycf48W1c8e4lmg+0ti9cA8ScYTdiqpVynkZLygpynGs42DzniP+4Qw/ ChjGlejHLGGmk8TpRzWYIbOj1ncAAhSsVLOIejOMtn7UmsPl6c7N1W2YjoKvocJzNia2 uKiA== X-Gm-Message-State: AElRT7GpSjVu4o+LEV4klpyKCkoE9ucK0LSM//ypiXaSQPfYlN9d/ixD 8VwSsEziKuxJUc15qr/yrIQKwvpV3LEBxNlhXIHQhw== X-Google-Smtp-Source: AG47ELtzNWWAkH/CVoFv3RrWOsb/ZsGlmZ/CWTVvKjUrKr9QGMSYaYTpEaROhDTgKofTBp7GOFUDofUDRE+kwE7e/Zw= X-Received: by 10.107.161.200 with SMTP id k191mr14387162ioe.270.1521536571881; Tue, 20 Mar 2018 02:02:51 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.30.9 with HTTP; Tue, 20 Mar 2018 02:02:31 -0700 (PDT) In-Reply-To: <20180320041253.24537-1-raj.khem@gmail.com> References: <20180320041253.24537-1-raj.khem@gmail.com> From: "Burton, Ross" Date: Tue, 20 Mar 2018 09:02:31 +0000 Message-ID: To: Khem Raj Cc: OE-core Subject: Re: [PATCH V2] site/risc-v: Cache common variables to build libIDL X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Mar 2018 09:02:50 -0000 Content-Type: multipart/alternative; boundary="001a113e9198e158420567d456b6" --001a113e9198e158420567d456b6 Content-Type: text/plain; charset="UTF-8" Are the sizeof values actually needed, or are they copy/pasted from another site? autoconf hasn't need to run code to do sizeof for a *long* time. Ross On 20 March 2018 at 04:12, Khem Raj wrote: > These variables force runtime tests during configure > they are already cached for other architectures > > Signed-off-by: Khem Raj > --- > Changes from v1 -> v2: > - Drop libIDL specific setting since they need to be in meta-gnome > > meta/site/riscv32-linux | 10 ++++++++++ > meta/site/riscv64-linux | 5 +++++ > 2 files changed, 15 insertions(+) > > diff --git a/meta/site/riscv32-linux b/meta/site/riscv32-linux > index 138aeb0a11..fc5b99d147 100644 > --- a/meta/site/riscv32-linux > +++ b/meta/site/riscv32-linux > @@ -1,6 +1,16 @@ > +# general > +ac_cv_alignof_guint32=4 > +ac_cv_alignof_guint64=8 > +ac_cv_alignof_unsigned_long=4 > + > # glib-2.0 > glib_cv_stack_grows=${glib_cv_stack_grows=no} > glib_cv_uscore=${glib_cv_uscore=no} > +glib_cv_sizeof_gmutex=${glib_cv_sizeof_gmutex=24} > +glib_cv_sizeof_intmax_t=${glib_cv_sizeof_intmax_t=8} > +glib_cv_sizeof_ptrdiff_t=${glib_cv_sizeof_ptrdiff_t=4} > +glib_cv_sizeof_size_t=${glib_cv_sizeof_size_t=4} > +glib_cv_sizeof_system_thread=${glib_cv_sizeof_system_thread=4} > > # startup-notification > lf_cv_sane_realloc=${lf_cv_sane_realloc=yes} > diff --git a/meta/site/riscv64-linux b/meta/site/riscv64-linux > index 138aeb0a11..38bc5f044d 100644 > --- a/meta/site/riscv64-linux > +++ b/meta/site/riscv64-linux > @@ -1,3 +1,8 @@ > +# general > +ac_cv_alignof_guint32=4 > +ac_cv_alignof_guint64=8 > +ac_cv_alignof_unsigned_long=8 > + > # glib-2.0 > glib_cv_stack_grows=${glib_cv_stack_grows=no} > glib_cv_uscore=${glib_cv_uscore=no} > -- > 2.16.2 > > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core > --001a113e9198e158420567d456b6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Are the sizeof values actually needed, or are they copy/pa= sted from another site? =C2=A0autoconf hasn't need to run code to do si= zeof for a *long* time.

Ross

On 20 March 2018 at 04:12, Khem R= aj <raj.khem@gmail.com> wrote:
These variables force runtime tests during configure
they are already cached for other architectures

Signed-off-by: Khem Raj <raj.khem@= gmail.com>
---
Changes from v1 -> v2:
- Drop libIDL specific setting since they need to be in meta-gnome

=C2=A0meta/site/riscv32-linux | 10 ++++++++++
=C2=A0meta/site/riscv64-linux |=C2=A0 5 +++++
=C2=A02 files changed, 15 insertions(+)

diff --git a/meta/site/riscv32-linux b/meta/site/riscv32-linux
index 138aeb0a11..fc5b99d147 100644
--- a/meta/site/riscv32-linux
+++ b/meta/site/riscv32-linux
@@ -1,6 +1,16 @@
+# general
+ac_cv_alignof_guint32=3D4
+ac_cv_alignof_guint64=3D8
+ac_cv_alignof_unsigned_long=3D4
+
=C2=A0# glib-2.0
=C2=A0glib_cv_stack_grows=3D${glib_cv_stack_grows=3Dno}
=C2=A0glib_cv_uscore=3D${glib_cv_uscore=3Dno}
+glib_cv_sizeof_gmutex=3D${glib_cv_sizeof_gmutex=3D24}
+glib_cv_sizeof_intmax_t=3D${glib_cv_sizeof_intmax_t=3D8}
+glib_cv_sizeof_ptrdiff_t=3D${glib_cv_sizeof_ptrdiff_t=3D4}
+glib_cv_sizeof_size_t=3D${glib_cv_sizeof_size_t=3D4}
+glib_cv_sizeof_system_thread=3D${glib_cv_sizeof_system_thread=3D= 4}

=C2=A0# startup-notification
=C2=A0lf_cv_sane_realloc=3D${lf_cv_sane_realloc=3Dyes}
diff --git a/meta/site/riscv64-linux b/meta/site/riscv64-linux
index 138aeb0a11..38bc5f044d 100644
--- a/meta/site/riscv64-linux
+++ b/meta/site/riscv64-linux
@@ -1,3 +1,8 @@
+# general
+ac_cv_alignof_guint32=3D4
+ac_cv_alignof_guint64=3D8
+ac_cv_alignof_unsigned_long=3D8
+
=C2=A0# glib-2.0
=C2=A0glib_cv_stack_grows=3D${glib_cv_stack_grows=3Dno}
=C2=A0glib_cv_uscore=3D${glib_cv_uscore=3Dno}
--
2.16.2

--
_______________________________________________
Openembedded-core mailing list
Openembedded-co= re@lists.openembedded.org
http://lists.openembedded.org/m= ailman/listinfo/openembedded-core

--001a113e9198e158420567d456b6--