All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Burton, Ross" <ross.burton@intel.com>
To: Jiang Lu <lu.jiang@windriver.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 3/4] glib-networking:enable glib-networking build as native package
Date: Wed, 20 Mar 2019 10:19:06 +0000	[thread overview]
Message-ID: <CAJTo0LaCF5__QA-mw-oCewVVRbEZvAcHk2YfS-SCaLFnG0=5iQ@mail.gmail.com> (raw)
In-Reply-To: <20190320093929.28688-4-lu.jiang@windriver.com>

On Wed, 20 Mar 2019 at 09:42, Jiang Lu <lu.jiang@windriver.com> wrote:
> +# Make sure we compile with ca-certificates support enabled.
> +PACKAGECONFIG_append = " ca-certificates"

Aside from doing PACKAGECONFIG_append in a recipe being the wrong thing to do:

PACKAGECONFIG ??= "gnutls"
PACKAGECONFIG[gnutls] = "-Dgnutls=true,-Dgnutls=false,gnutls"
PACKAGECONFIG[libproxy] =
"-Dlibproxy_support=true,-Dlibproxy_support=false,libproxy"

There is no ca-certificates PACKAGECONFIG.

> +DEPENDS += "ca-certificates"
> +RDEPENDS_${PN} += "ca-certificates"

Build time and runtime?  Not explained in the commit message.  Should
be part of this mythical ca-certificates PACKAGECONFIG.

> +# We need native version for ostree-/flatpak-native.
> +BBCLASSEXTEND = "native"

oe-core doesnt need a comment listing the recipes that you're trying to build.

Ross


  reply	other threads:[~2019-03-20 10:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-20  9:39 [v2] libsoup:add a new routine & build as native package Jiang Lu
2019-03-20  9:39 ` [PATCH 1/4] libsoup:add soup_uri_to_string_with_password Jiang Lu
2019-03-20 10:15   ` Burton, Ross
2019-03-20  9:39 ` [PATCH 2/4] libsoup:enable libsoup build as native package Jiang Lu
2019-03-20 10:15   ` Burton, Ross
2019-03-20  9:39 ` [PATCH 3/4] glib-networking:enable glib-networking " Jiang Lu
2019-03-20 10:19   ` Burton, Ross [this message]
2019-03-20 11:03   ` Martin Jansa
2019-03-20 12:03   ` richard.purdie
2019-03-20  9:39 ` [PATCH 4/4] relocatable: add file existence checking in relocatable_native_pcfiles Jiang Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJTo0LaCF5__QA-mw-oCewVVRbEZvAcHk2YfS-SCaLFnG0=5iQ@mail.gmail.com' \
    --to=ross.burton@intel.com \
    --cc=lu.jiang@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.