All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Burton, Ross" <ross.burton@intel.com>
To: "Davis, Michael" <michael.davis@essvote.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] Support for changing the imager used in wic.
Date: Mon, 8 Oct 2018 16:43:15 +0100	[thread overview]
Message-ID: <CAJTo0LacsX89u4ueXgQmgtip_PtyfF04SekXD1pAMjtTgtu2GQ@mail.gmail.com> (raw)
In-Reply-To: <655290B7709079438B7932553958E60DA15843CA@ESS-EX01.essvote.corp.local>

[-- Attachment #1: Type: text/plain, Size: 2371 bytes --]

That's one messed up patch: can you resend using git-send-email please?

Ross

On Mon, 8 Oct 2018 at 14:59, Davis, Michael <michael.davis@essvote.com>
wrote:

> >*From 136d6214b6fc2c1118dac5b7f3e029ed006fab8a Mon Sep 17 00:00:00 2001*
>
> From: Paul Knopf <pauldotknopf at gmail.com <https://lists.yoctoproject.org/listinfo/yocto>>
>
> Date: Mon, 21 May 2018 16:56:51 -0400
>
> Subject: [PATCH] Support for changing the imager used in wic.
>
>
>
> ---
>
>  scripts/lib/wic/engine.py | 2 +-
>
>  scripts/wic               | 1 +
>
>  2 files changed, 2 insertions(+), 1 deletion(-)
>
>
>
> diff --git a/scripts/lib/wic/engine.py b/scripts/lib/wic/engine.py
>
> index edcfab3..d7c5c11 100644
>
> --- a/scripts/lib/wic/engine.py
>
> +++ b/scripts/lib/wic/engine.py
>
> @@ -191,7 +191,7 @@ def wic_create(wks_file, rootfs_dir, bootimg_dir,
>
> kernel_dir,
>
>      if not os.path.exists(options.outdir):
>
>          os.makedirs(options.outdir)
>
>
>
> -    pname = 'direct'
>
> +    pname = options.imager
>
>      plugin_class = PluginMgr.get_plugins('imager').get(pname)
>
>      if not plugin_class:
>
>          raise WicError('Unknown plugin: %s' % pname)
>
> diff --git a/scripts/wic b/scripts/wic
>
> index 7392bc4..255e524 100755
>
> --- a/scripts/wic
>
> +++ b/scripts/wic
>
> @@ -360,6 +360,7 @@ def wic_init_parser_create(subparser):
>
>      subparser.add_argument("-v", "--vars", dest='vars_dir',
>
>                        help="directory with <image>.env files that store "
>
>                             "bitbake variables")
>
> +    subparser.add_argument("-i", "--imager", dest="imager",
>
> default="direct", help="the wic imager plugin")
>
>      subparser.add_argument("-D", "--debug", dest="debug",
>
> action="store_true",
>
>                        default=False, help="output debug information")
>
>      return
>
> --
>
> 2.7.4
>
>
>
>
>
> I found this patch that got sent to the yocto mailing list, but never made
> it to the correct mailing list.
>
> I would really like to have the functionality if it is possible to get it
> pulled in.
>
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 5622 bytes --]

      reply	other threads:[~2018-10-08 15:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-08 13:43 [PATCH] Support for changing the imager used in wic Davis, Michael
2018-10-08 15:43 ` Burton, Ross [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJTo0LacsX89u4ueXgQmgtip_PtyfF04SekXD1pAMjtTgtu2GQ@mail.gmail.com \
    --to=ross.burton@intel.com \
    --cc=michael.davis@essvote.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.