From: "Burton, Ross" <ross.burton@intel.com>
To: "Bystricky, Juro" <juro.bystricky@intel.com>
Cc: Yocto-mailing-list <yocto@yoctoproject.org>,
Juro Bystricky <jurobystricky@hotmail.com>,
Alistair Francis <alistair.francis@xilinx.com>
Subject: Re: [meta-mingw][PATCH] qemu_2.11.%.bbappend: fix broken qemu build for mingw
Date: Fri, 13 Apr 2018 16:19:25 +0100 [thread overview]
Message-ID: <CAJTo0LbQhrh+26n5OZKj-Grhrmc=5ANNdPEWgWDfLfKd+QSJew@mail.gmail.com> (raw)
In-Reply-To: <6E51916E4A1F32428260031F4C7CD2B64C6A8227@ORSMSX112.amr.corp.intel.com>
Thanks Juro. I'll remember to keep an eye out for the ifdefs disappearing.
Ross
On 13 April 2018 at 15:46, Bystricky, Juro <juro.bystricky@intel.com> wrote:
> yes, I've done it before:
> https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?h=sumo&id=bc112b8368eb3842ccb2430fdf17e736ea39a742
> I'll do it gain. Hopefully it will last longer this time.
>
>
> ________________________________________
> From: Burton, Ross [ross.burton@intel.com]
> Sent: Friday, April 13, 2018 5:50 AM
> To: Bystricky, Juro
> Cc: Yocto-mailing-list; Juro Bystricky; Alistair Francis
> Subject: Re: [yocto] [meta-mingw][PATCH] qemu_2.11.%.bbappend: fix broken qemu build for mingw
>
> Is it feasible to fix the original patch?
>
> Ross
>
> On 13 April 2018 at 00:55, Juro Bystricky <juro.bystricky@intel.com> wrote:
>> The commit "qemu: Bump to version 2.11.0" in oe-core broke the
>> build of qemu for mingw, due to using "socketpair", which is
>> not supported by mingw. "socketpair" is used in a local patch,
>> not in the qemu upstream code. The original local patch had
>> conditional code to exclude "socketpair" for _WIN32, but the
>> modified patch for qemu 2.11.0 removed this.
>>
>> The fix is to simply remove the offending patch.
>>
>> Signed-off-by: Juro Bystricky <juro.bystricky@intel.com>
>> ---
>> recipes-devtools/qemu/qemu_2.11.%.bbappend | 4 ++++
>> 1 file changed, 4 insertions(+)
>> create mode 100644 recipes-devtools/qemu/qemu_2.11.%.bbappend
>>
>> diff --git a/recipes-devtools/qemu/qemu_2.11.%.bbappend b/recipes-devtools/qemu/qemu_2.11.%.bbappend
>> new file mode 100644
>> index 0000000..764b500
>> --- /dev/null
>> +++ b/recipes-devtools/qemu/qemu_2.11.%.bbappend
>> @@ -0,0 +1,4 @@
>> +
>> +
>> +SRC_URI_remove_mingw32 = "file://chardev-connect-socket-to-a-spawned-command.patch"
>> +
>> --
>> 2.7.4
>>
>> --
>> _______________________________________________
>> yocto mailing list
>> yocto@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/yocto
next prev parent reply other threads:[~2018-04-13 15:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 23:55 [meta-mingw][PATCH] qemu_2.11.%.bbappend: fix broken qemu build for mingw Juro Bystricky
2018-04-13 12:50 ` Burton, Ross
2018-04-13 14:46 ` Bystricky, Juro
2018-04-13 15:19 ` Burton, Ross [this message]
2018-04-13 15:24 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJTo0LbQhrh+26n5OZKj-Grhrmc=5ANNdPEWgWDfLfKd+QSJew@mail.gmail.com' \
--to=ross.burton@intel.com \
--cc=alistair.francis@xilinx.com \
--cc=juro.bystricky@intel.com \
--cc=jurobystricky@hotmail.com \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.