From: "Burton, Ross" <ross.burton@intel.com>
To: Andre McCurdy <armccurdy@gmail.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] util-linux.inc: add fallocate only for class-target
Date: Fri, 27 Jul 2018 12:05:18 +0100 [thread overview]
Message-ID: <CAJTo0LbkAc9NgGyE2HCvFLt6ggcO-iMpYp-XMDB9oy=RAV7TEQ@mail.gmail.com> (raw)
In-Reply-To: <CAJ86T=VQ_Qk0TOhHRiZ0SThgZ8-HZOTz6L5JXD4K2ut+7tbWFA@mail.gmail.com>
On 27 July 2018 at 00:58, Andre McCurdy <armccurdy@gmail.com> wrote:
> On Thu, Jul 26, 2018 at 4:34 PM, Burton, Ross <ross.burton@intel.com> wrote:
>> On 26 July 2018 at 14:58, Ioan-Adrian Ratiu <adrian.ratiu@ni.com> wrote:
>>> Because the util-linux_2.32.bb recipe explicitely disables fallocate
>>> for nativesdk triggering build warnings:
>>
>> Does anyone know why util-linux disables fallocate for nativesdk and
>> native builds?
>
> Seems to date back to this commit:
>
> http://git.openembedded.org/openembedded-core/commit/?id=17f3c548caf4adec37c3bbb139aa6b3900419794
>
> +# fallocate is glibc 2.10, fallocate64 is glibc 2.11
> +# we need to disable it for older versions
> +EXTRA_OECONF += "ac_cv_func_fallocate=no"
> +EXTRA_OECONF_virtclass-native += "--disable-fallocate
> --disable-use-tty-group"
Well done, it was late and I got bored following the git-blame log. :)
Sounds like historical reasons to me, does anyone object to dropping this?
Ross
next prev parent reply other threads:[~2018-07-27 11:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 13:58 [PATCH] util-linux.inc: add fallocate only for class-target Ioan-Adrian Ratiu
2018-07-26 14:00 ` Martin Jansa
2018-07-26 14:19 ` [PATCHv2] " Martin Jansa
2018-07-26 14:22 ` [PATCH] " Martin Jansa
2018-07-26 17:06 ` Ioan-Adrian Ratiu
2018-07-26 23:19 ` Andre McCurdy
2018-07-26 23:34 ` Burton, Ross
2018-07-26 23:58 ` Andre McCurdy
2018-07-27 11:05 ` Burton, Ross [this message]
2018-07-31 12:12 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJTo0LbkAc9NgGyE2HCvFLt6ggcO-iMpYp-XMDB9oy=RAV7TEQ@mail.gmail.com' \
--to=ross.burton@intel.com \
--cc=armccurdy@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.