All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexei Podtelezhnikov <apodtele@gmail.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/selftests: Tweak the tolerance for clock ticks to 12.5%
Date: Tue, 28 Apr 2020 14:44:13 -0400	[thread overview]
Message-ID: <CAJU=AjWyX_zV4PaFNYxzCVz2svsKW3UHr9-R7aqajmj97ZHwcw@mail.gmail.com> (raw)
In-Reply-To: <20200428114307.5153-1-chris@chris-wilson.co.uk>

On Tue, Apr 28, 2020 at 7:43 AM Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
> Give a small bump for our tolerance on comparing the expected vs
> measured clock ticks/time from 10% to 12.5% to accommodate a bad result
> on Sandybridge that was off by 10.3%. Hopefully, that is the worst we
> will see.
> -                       if (10 * time < 9 * ktime_to_ns(dt) ||
> -                           10 * time > 11 * ktime_to_ns(dt)) {
> +                       if (10 * time < 8 * ktime_to_ns(dt) ||
> +                           8 * time > 10 * ktime_to_ns(dt)) {

This is actually -25%/+20% and you could have used 5:4. If your goal
is to cover 10.3% in either direction just barely, use 8:9.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2020-04-28 18:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-28 11:43 [Intel-gfx] [PATCH] drm/i915/selftests: Tweak the tolerance for clock ticks to 12.5% Chris Wilson
2020-04-28 13:21 ` Mika Kuoppala
2020-04-28 17:06 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-04-28 18:44 ` Alexei Podtelezhnikov [this message]
2020-04-28 18:52   ` [Intel-gfx] [PATCH] " Chris Wilson
2020-04-28 20:04 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJU=AjWyX_zV4PaFNYxzCVz2svsKW3UHr9-R7aqajmj97ZHwcw@mail.gmail.com' \
    --to=apodtele@gmail.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.