From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9932589C80 for ; Tue, 28 Sep 2021 14:48:29 +0000 (UTC) Received: by mail-lf1-x132.google.com with SMTP id z24so94736453lfu.13 for ; Tue, 28 Sep 2021 07:48:29 -0700 (PDT) MIME-Version: 1.0 References: <20210927160700.1570885-1-aurabindo.pillai@amd.com> <0e047200-f40a-daa8-80d8-4745da3b9430@amd.com> <0aadb8c4-1329-4241-a65a-1348c7b5b692@amd.com> <20210928144347.iv3dxo4rmu7u42c7@outlook.office365.com> In-Reply-To: <20210928144347.iv3dxo4rmu7u42c7@outlook.office365.com> From: Mark Yacoub Date: Tue, 28 Sep 2021 10:48:17 -0400 Message-ID: Content-Type: text/plain; charset="UTF-8" Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Rodrigo Siqueira Cc: Aurabindo Pillai , Petri Latvala , Development mailing list for IGT GPU Tools , Mark Yacoub List-ID: On Tue, Sep 28, 2021 at 10:43 AM Rodrigo Siqueira wrote: > > Hi, > > I also tested it using vkms and vc4. > > I already applied the V1 in the upstream. > > Thanks > Siqueira > > On 09/28, Aurabindo Pillai wrote: > > > > On 9/28/21 9:53 AM, Petri Latvala wrote: > > > On Tue, Sep 28, 2021 at 09:35:10AM -0400, Aurabindo Pillai wrote: > > > > On 9/28/21 5:15 AM, Petri Latvala wrote: > > > > > On Mon, Sep 27, 2021 at 07:10:45PM +0000, Pillai, Aurabindo wrote: > > > > > > Skipping using the continue statement has the side effect of this > > > > > > subtest being absent from the list of subtests, when running the > > > > > > test executable with paramter --list-subtest. Is that okay ? > > > > > It's not okay btw. When you're not in an igt_fixture or an > > > > > igt_subtest, you cannot use anything that touches the hardware or the > > > > > running system in any way. Hi Petri, can you elaborate more on this. I'm curious to understand what you mean. I'm slightly confused. > > > > > > > > > > > > > > In that case, please discard v2. Is this version good enough ? > > > > > > > > > > No objections with v1. > > > Acked-by: Petri Latvala > > > > > > Thank you. > > > > -- > Rodrigo Siqueira > https://siqueira.tech