From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED0EFC433EF for ; Tue, 14 Dec 2021 15:13:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235220AbhLNPNP (ORCPT ); Tue, 14 Dec 2021 10:13:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229883AbhLNPNN (ORCPT ); Tue, 14 Dec 2021 10:13:13 -0500 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 745BBC061574 for ; Tue, 14 Dec 2021 07:13:13 -0800 (PST) Received: by mail-lf1-x133.google.com with SMTP id t26so37398975lfk.9 for ; Tue, 14 Dec 2021 07:13:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=H+bLnAgO3b5siLg+4Vc0pITri5Pyuz0KEVByfdnYDUc=; b=kCE7rz4ty8OGXocOaIZ3U4M6gf6ZOKVj3wNbZYF0cgfawnSE7lraEFy4XZSw/fLgSF +znofuf+MuVMaaLS3TEXk10vJMTERr9+PeavbiQTq8Tls0YR5gjguTMLcRzSVqJt99K/ 0je4UkVDApqGfFNiKg32fiTXAGdspkepqWSlo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=H+bLnAgO3b5siLg+4Vc0pITri5Pyuz0KEVByfdnYDUc=; b=CAm+L59/ceUDt+Ttj4quxx7k6Fxk+owPDbHV7p9QguZ74nrIfoNjLVaAV5Ylrx8KPH uOYkVD1JnZ9CsdtjecxS9MW5R0dpVmWncRyF6aDtVsE/qzt1AyPMUnxWPyzVTOLYN3FH G+WNZueDfdeg2CEYi6omgbqWBZW4v20Vgw7w1tFUcGlB3o85kBry4cf101S3hzWSiWqU +EWp1q8xwQA2GkqOIWN8x1nx7e39XIshOILcAM27TP4w9Dk45iA9IuZO2sZ3qaCRqrXw sFZPITvPZvp1XO1KfbXPCmMJAuTCrwJVzGlD9jDWhHtjV9L+XifitknnpFZT+msVHZk+ GvKA== X-Gm-Message-State: AOAM532AqwT2WOTUCm4eM3hYFlCgfKbh/Wgc5tg0rcukl/8CXsTz2bzv AG+dOrvnp5w7AIdvZBQHnWmCVtCV0sQ1nQY+mnRKYw== X-Google-Smtp-Source: ABdhPJyJT7xqBLUyVs9umwlaLSNF7gCLRF7yhoSNNTuBadwQHuxuZn1gHe8yhGYuShqyro78Lu0JCvDSqBPxCAMGnYs= X-Received: by 2002:a05:6512:1510:: with SMTP id bq16mr4926777lfb.628.1639494791345; Tue, 14 Dec 2021 07:13:11 -0800 (PST) MIME-Version: 1.0 References: <20211022172413.195559-1-markyacoub@chromium.org> <20211026011318.GF2515@art_vandelay> In-Reply-To: <20211026011318.GF2515@art_vandelay> From: Mark Yacoub Date: Tue, 14 Dec 2021 10:13:00 -0500 Message-ID: Subject: Re: [PATCH] mediatek: Set default value for Panel Orientation connector prop. To: Sean Paul Cc: linux-mediatek@lists.infradead.org, seanpaul@chromium.org, Mark Yacoub , Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey CK, can we have this merged? Thank you! On Mon, Oct 25, 2021 at 9:13 PM Sean Paul wrote: > > On Fri, Oct 22, 2021 at 01:24:03PM -0400, Mark Yacoub wrote: > > From: Mark Yacoub > > > > [Why] > > Creating the prop uses UNKNOWN as the initial value, which is not a > > supported value if the props is to be supported. > > > > [How] > > Set the panel orientation default value to NORMAL right after creating > > the prop. > > Reviewed-by: Sean Paul > > > > > Tested on Jacuzzi(MTK) > > Fixes IGT@kms_properties@get_properties-sanity-{atomic,non-atomic} > > > > Signed-off-by: Mark Yacoub > > --- > > drivers/gpu/drm/mediatek/mtk_dsi.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c > > index 0ad7157660afa..b7c2528a8f41c 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > > @@ -1039,6 +1039,8 @@ static int mtk_dsi_encoder_init(struct drm_device *drm, struct mtk_dsi *dsi) > > DRM_ERROR("Unable to init panel orientation\n"); > > goto err_cleanup_encoder; > > } > > + drm_connector_set_panel_orientation(dsi->connector, > > + DRM_MODE_PANEL_ORIENTATION_NORMAL); > > > > drm_connector_attach_encoder(dsi->connector, &dsi->encoder); > > > > -- > > 2.33.0.1079.g6e70778dc9-goog > > > > -- > Sean Paul, Software Engineer, Google / Chromium OS From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D077C433EF for ; Tue, 14 Dec 2021 15:13:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ys2Fdi5ISHISrZ6Yh5jIMmYNuoWxN5jUFnf9YIlla+Q=; b=BnHA7Gs4dCsWp8 nqNCRNegYFrCzbceL2jDqkpoC+Y9N4aA0bwz/wCrBMDEX/EHotBkigia4E2go3+Makd8BrAy5TGWw hD27Z1poWP6OAnXNuJDiLJBy0uPTwCoVCnap8MmjUfqrSWSX1y4+DcVUkvfG40XHSYzcHehwpyFjU O1bQ2nzN4gYCD7rPDgaSehjwK13aIz3eYSe6Xq6jLltLXW1ceF2kselvsC16rSk3/6q3D396ooUZW RpXFztYU1Kxdqxb+zx2DBwVXuIV8EJ2eEMiAlKWdzoN5VI6Jh84M3QKEg9kSvKUbRopF1ocDL0SvH t1Luxi/wLL/ybVU2TmaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mx9UT-00Eb5e-2b; Tue, 14 Dec 2021 15:13:17 +0000 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mx9UP-00Eb40-RN for linux-mediatek@lists.infradead.org; Tue, 14 Dec 2021 15:13:15 +0000 Received: by mail-lf1-x135.google.com with SMTP id b40so37357528lfv.10 for ; Tue, 14 Dec 2021 07:13:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=H+bLnAgO3b5siLg+4Vc0pITri5Pyuz0KEVByfdnYDUc=; b=kCE7rz4ty8OGXocOaIZ3U4M6gf6ZOKVj3wNbZYF0cgfawnSE7lraEFy4XZSw/fLgSF +znofuf+MuVMaaLS3TEXk10vJMTERr9+PeavbiQTq8Tls0YR5gjguTMLcRzSVqJt99K/ 0je4UkVDApqGfFNiKg32fiTXAGdspkepqWSlo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=H+bLnAgO3b5siLg+4Vc0pITri5Pyuz0KEVByfdnYDUc=; b=7Oh/Mo9nCYHyxnKWnZ0g9zC9SVHKxJ+tf21nIfFUnaBlLGLFUPO/LK8xNFod08rnnz UVoJEV710U8EuiNH4jhLw20wIVSabYHkzQ0DmfVXhA3Wn0lzuJC9WZ5zmBrGcpRfQSoF 0bQXwvwqNSDs/pLrF85KyuJ5cI8fQW4Ll81wnMLr7ySjQ4Hml+W+wjNLoFiDmdrL9tUP knZaMgkxvFERCQtY+EergbTSlF+6rP4pquyb1hxrNkeAXrSGIK7xeO4p/AQrsqcdjYNl SudpTaioo5U9q3JzPAjYOHCFKZ80jF6/KNikNVKP49+rfu3Lal74S4twnS2BOWIeQv09 8azQ== X-Gm-Message-State: AOAM531sFP9A6Y6jKmCOEGPSFJqinrDx0ebCpPcBADbLnDYFsxMlxNbv sSeA25cTnZ2/itRaTaeOgmrK6BuQXoTueyCjqoszhw== X-Google-Smtp-Source: ABdhPJyJT7xqBLUyVs9umwlaLSNF7gCLRF7yhoSNNTuBadwQHuxuZn1gHe8yhGYuShqyro78Lu0JCvDSqBPxCAMGnYs= X-Received: by 2002:a05:6512:1510:: with SMTP id bq16mr4926777lfb.628.1639494791345; Tue, 14 Dec 2021 07:13:11 -0800 (PST) MIME-Version: 1.0 References: <20211022172413.195559-1-markyacoub@chromium.org> <20211026011318.GF2515@art_vandelay> In-Reply-To: <20211026011318.GF2515@art_vandelay> From: Mark Yacoub Date: Tue, 14 Dec 2021 10:13:00 -0500 Message-ID: Subject: Re: [PATCH] mediatek: Set default value for Panel Orientation connector prop. To: Sean Paul Cc: linux-mediatek@lists.infradead.org, seanpaul@chromium.org, Mark Yacoub , Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211214_071313_946493_399932C0 X-CRM114-Status: GOOD ( 17.27 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hey CK, can we have this merged? Thank you! On Mon, Oct 25, 2021 at 9:13 PM Sean Paul wrote: > > On Fri, Oct 22, 2021 at 01:24:03PM -0400, Mark Yacoub wrote: > > From: Mark Yacoub > > > > [Why] > > Creating the prop uses UNKNOWN as the initial value, which is not a > > supported value if the props is to be supported. > > > > [How] > > Set the panel orientation default value to NORMAL right after creating > > the prop. > > Reviewed-by: Sean Paul > > > > > Tested on Jacuzzi(MTK) > > Fixes IGT@kms_properties@get_properties-sanity-{atomic,non-atomic} > > > > Signed-off-by: Mark Yacoub > > --- > > drivers/gpu/drm/mediatek/mtk_dsi.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c > > index 0ad7157660afa..b7c2528a8f41c 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > > @@ -1039,6 +1039,8 @@ static int mtk_dsi_encoder_init(struct drm_device *drm, struct mtk_dsi *dsi) > > DRM_ERROR("Unable to init panel orientation\n"); > > goto err_cleanup_encoder; > > } > > + drm_connector_set_panel_orientation(dsi->connector, > > + DRM_MODE_PANEL_ORIENTATION_NORMAL); > > > > drm_connector_attach_encoder(dsi->connector, &dsi->encoder); > > > > -- > > 2.33.0.1079.g6e70778dc9-goog > > > > -- > Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23570C433F5 for ; Tue, 14 Dec 2021 15:13:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4CFF710E55F; Tue, 14 Dec 2021 15:13:16 +0000 (UTC) Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by gabe.freedesktop.org (Postfix) with ESMTPS id 73FA310E55F for ; Tue, 14 Dec 2021 15:13:14 +0000 (UTC) Received: by mail-lf1-x132.google.com with SMTP id bi37so37437353lfb.5 for ; Tue, 14 Dec 2021 07:13:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=H+bLnAgO3b5siLg+4Vc0pITri5Pyuz0KEVByfdnYDUc=; b=kCE7rz4ty8OGXocOaIZ3U4M6gf6ZOKVj3wNbZYF0cgfawnSE7lraEFy4XZSw/fLgSF +znofuf+MuVMaaLS3TEXk10vJMTERr9+PeavbiQTq8Tls0YR5gjguTMLcRzSVqJt99K/ 0je4UkVDApqGfFNiKg32fiTXAGdspkepqWSlo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=H+bLnAgO3b5siLg+4Vc0pITri5Pyuz0KEVByfdnYDUc=; b=GM9aFMcgYTxtJ1oFcW4rMczNpl6SD7IE55bo/YzNR59bADF3Fc98BWVg0IGAHOgE1x ZM0XkDpmq9OtrQnlL8osBTYw1iZ3gb1CXQYhLRbdf3EIqZ6faMjwsXCTA2LC6gxOow8h KG19Svi9RLf7Myr0OuT8j6nsbw5cb1DfXORD45R73yJTLpl8gXV0f82OOBhm0oUZd+it uOY+WD2s3bBXp/PdUp2sv5l55J3YIpOQTpr84uOkbtu12GtLy5s1t/dSCTi2YQcHCsjb LIBBXdm7FDc673Zjgvt4n2+Y8kxDGKICaq3KJBmgl/vVqwzntF051Civ/SuO2IdG/dps b1ew== X-Gm-Message-State: AOAM532cgVL1DyIAWtQtL5IsPckOOR9Ehk1EW9i9iQ9UHxBKBZIeS/4U LbWQuzWA31cbiv5nGDqAcWRSI3D7WROrVcfvkoVlsg== X-Google-Smtp-Source: ABdhPJyJT7xqBLUyVs9umwlaLSNF7gCLRF7yhoSNNTuBadwQHuxuZn1gHe8yhGYuShqyro78Lu0JCvDSqBPxCAMGnYs= X-Received: by 2002:a05:6512:1510:: with SMTP id bq16mr4926777lfb.628.1639494791345; Tue, 14 Dec 2021 07:13:11 -0800 (PST) MIME-Version: 1.0 References: <20211022172413.195559-1-markyacoub@chromium.org> <20211026011318.GF2515@art_vandelay> In-Reply-To: <20211026011318.GF2515@art_vandelay> From: Mark Yacoub Date: Tue, 14 Dec 2021 10:13:00 -0500 Message-ID: Subject: Re: [PATCH] mediatek: Set default value for Panel Orientation connector prop. To: Sean Paul Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chun-Kuang Hu , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, seanpaul@chromium.org, Matthias Brugger , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Mark Yacoub Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hey CK, can we have this merged? Thank you! On Mon, Oct 25, 2021 at 9:13 PM Sean Paul wrote: > > On Fri, Oct 22, 2021 at 01:24:03PM -0400, Mark Yacoub wrote: > > From: Mark Yacoub > > > > [Why] > > Creating the prop uses UNKNOWN as the initial value, which is not a > > supported value if the props is to be supported. > > > > [How] > > Set the panel orientation default value to NORMAL right after creating > > the prop. > > Reviewed-by: Sean Paul > > > > > Tested on Jacuzzi(MTK) > > Fixes IGT@kms_properties@get_properties-sanity-{atomic,non-atomic} > > > > Signed-off-by: Mark Yacoub > > --- > > drivers/gpu/drm/mediatek/mtk_dsi.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c > > index 0ad7157660afa..b7c2528a8f41c 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > > @@ -1039,6 +1039,8 @@ static int mtk_dsi_encoder_init(struct drm_device *drm, struct mtk_dsi *dsi) > > DRM_ERROR("Unable to init panel orientation\n"); > > goto err_cleanup_encoder; > > } > > + drm_connector_set_panel_orientation(dsi->connector, > > + DRM_MODE_PANEL_ORIENTATION_NORMAL); > > > > drm_connector_attach_encoder(dsi->connector, &dsi->encoder); > > > > -- > > 2.33.0.1079.g6e70778dc9-goog > > > > -- > Sean Paul, Software Engineer, Google / Chromium OS From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D840C433EF for ; Tue, 14 Dec 2021 15:14:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4lpw1cYw1N0N7l16l7kAz7tK1c4Uy682bdHzCNsHmgY=; b=nfcI/3vmnBDScp HCHQFRPM8/JxtCXM6F2KrUEqCcTyO07MD8NE14oeJyhuHk8piBAMNvzwD56rHu64xN8cPci/EEV22 Zb6YnvizE/q2JttPQMojHto2srHKIh2mIyqdmFdocb2orulYkPzpfmbsqBqvoqyPcH9LK8Dm8484z 0MvqFN+THWz7OjmIXFBQ2HhVUWe8LMoHATgpbl2JZhtDGFrKeFfN1r+05+6D9nTF0RVAifLWemzxa 9vkwMj/rSZ6r1vMBP47I4sc0Lo6hKIEhdRGQkgZ56Rs9PvypaM9DOtFq7p+WR9/bAVudHQBlUAHvN vuCVp8L+V8WTbmtMFCXw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mx9UV-00Eb6K-3x; Tue, 14 Dec 2021 15:13:19 +0000 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mx9UP-00Eb41-RY for linux-arm-kernel@lists.infradead.org; Tue, 14 Dec 2021 15:13:15 +0000 Received: by mail-lf1-x134.google.com with SMTP id l22so37363441lfg.7 for ; Tue, 14 Dec 2021 07:13:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=H+bLnAgO3b5siLg+4Vc0pITri5Pyuz0KEVByfdnYDUc=; b=kCE7rz4ty8OGXocOaIZ3U4M6gf6ZOKVj3wNbZYF0cgfawnSE7lraEFy4XZSw/fLgSF +znofuf+MuVMaaLS3TEXk10vJMTERr9+PeavbiQTq8Tls0YR5gjguTMLcRzSVqJt99K/ 0je4UkVDApqGfFNiKg32fiTXAGdspkepqWSlo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=H+bLnAgO3b5siLg+4Vc0pITri5Pyuz0KEVByfdnYDUc=; b=jggN/qBXD/6viJPNVZ/ESe4MR5rczRITF4nKQCw6Dv6jLYXz6OjIK+b5+lCqo0aOkJ Nu0mfJDbcex61pcOXhYCR8ltolcmG+7CFLfrFF5zfLhZE+6ZikND5o7ARxoPMcR3Q9LA 73Qf9Rwsy61knItxw6cA2MOeq3JWr6hyZtWy/aldF6H5jpt49mLRJ2fJB8JKRRDZz78j jmGNNI0CRJT0E+BsIZBx777MK5tcdSZugTkq2ubtnnq9K2Za++GtMRTBpvAX/JqLkAvt XE0aW+IydMCujGLjonkU3/ZPkSV/MMhiWKqLndEZGxLf/U2QWZ5GJgHFFcIg+bN1btat p03g== X-Gm-Message-State: AOAM531OhS4xewNCMIrlo3Uz0kZ/x6HvzPqHrhru6ClXbLxj8ZBVNJLZ hBg1rREzBNmNLr8u81994L89oXD8cZfc/Q+Agk+V8A== X-Google-Smtp-Source: ABdhPJyJT7xqBLUyVs9umwlaLSNF7gCLRF7yhoSNNTuBadwQHuxuZn1gHe8yhGYuShqyro78Lu0JCvDSqBPxCAMGnYs= X-Received: by 2002:a05:6512:1510:: with SMTP id bq16mr4926777lfb.628.1639494791345; Tue, 14 Dec 2021 07:13:11 -0800 (PST) MIME-Version: 1.0 References: <20211022172413.195559-1-markyacoub@chromium.org> <20211026011318.GF2515@art_vandelay> In-Reply-To: <20211026011318.GF2515@art_vandelay> From: Mark Yacoub Date: Tue, 14 Dec 2021 10:13:00 -0500 Message-ID: Subject: Re: [PATCH] mediatek: Set default value for Panel Orientation connector prop. To: Sean Paul Cc: linux-mediatek@lists.infradead.org, seanpaul@chromium.org, Mark Yacoub , Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211214_071313_944956_E64A87DF X-CRM114-Status: GOOD ( 18.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hey CK, can we have this merged? Thank you! On Mon, Oct 25, 2021 at 9:13 PM Sean Paul wrote: > > On Fri, Oct 22, 2021 at 01:24:03PM -0400, Mark Yacoub wrote: > > From: Mark Yacoub > > > > [Why] > > Creating the prop uses UNKNOWN as the initial value, which is not a > > supported value if the props is to be supported. > > > > [How] > > Set the panel orientation default value to NORMAL right after creating > > the prop. > > Reviewed-by: Sean Paul > > > > > Tested on Jacuzzi(MTK) > > Fixes IGT@kms_properties@get_properties-sanity-{atomic,non-atomic} > > > > Signed-off-by: Mark Yacoub > > --- > > drivers/gpu/drm/mediatek/mtk_dsi.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c > > index 0ad7157660afa..b7c2528a8f41c 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > > @@ -1039,6 +1039,8 @@ static int mtk_dsi_encoder_init(struct drm_device *drm, struct mtk_dsi *dsi) > > DRM_ERROR("Unable to init panel orientation\n"); > > goto err_cleanup_encoder; > > } > > + drm_connector_set_panel_orientation(dsi->connector, > > + DRM_MODE_PANEL_ORIENTATION_NORMAL); > > > > drm_connector_attach_encoder(dsi->connector, &dsi->encoder); > > > > -- > > 2.33.0.1079.g6e70778dc9-goog > > > > -- > Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel