From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by gabe.freedesktop.org (Postfix) with ESMTPS id A42446E059 for ; Wed, 7 Jul 2021 16:09:26 +0000 (UTC) Received: by mail-lf1-x134.google.com with SMTP id r26so5128685lfp.2 for ; Wed, 07 Jul 2021 09:09:26 -0700 (PDT) MIME-Version: 1.0 References: <20210701174424.2261499-1-markyacoub@chromium.org> <20210701174424.2261499-2-markyacoub@chromium.org> <20210706134110.iopwgjfwpnibtyjb@outlook.office365.com> In-Reply-To: <20210706134110.iopwgjfwpnibtyjb@outlook.office365.com> From: Mark Yacoub Date: Wed, 7 Jul 2021 12:09:14 -0400 Message-ID: Subject: Re: [igt-dev] [PATCH 2/2] kms_addfb_basic: Check for AMDGPU and MSM bad pitch. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Rodrigo Siqueira Cc: Development mailing list for IGT GPU Tools , Sean Paul , Petri Latvala , Mark Yacoub List-ID: This is odd, idrk. On Tue, Jul 6, 2021 at 9:41 AM Rodrigo Siqueira wrote: > > On 07/01, Mark Yacoub wrote: > > From: Mark Yacoub > > > > [Why] > > AMDGPU and MSM devices have a known errno when it fails coorectly for > > bad pitches. > > > > [How] > > Assert `errno` to `EINVAL` for both AMDGPU and MSM as well. > > > > Signed-off-by: Mark Yacoub > > --- > > tests/kms_addfb_basic.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c > > index 85c14be5..91fb6ac9 100644 > > --- a/tests/kms_addfb_basic.c > > +++ b/tests/kms_addfb_basic.c > > @@ -310,7 +310,7 @@ static void pitch_tests(int fd) > > f.pitches[0] = bad_pitches[i]; > > igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &f), -1); > > igt_assert(errno != 0); > > - if (is_i915_device(fd)) { > > + if (is_i915_device(fd) || is_amdgpu_device(fd) || is_msm_device(fd)) { > > igt_assert_eq(errno, EINVAL); > > } else if (is_nouveau_device(fd)) { > > if (bad_pitches[i] > 4 * 1024) > > -- > > 2.32.0.93.g670b81a890-goog > > > > Reviewed-by: Rodrigo Siqueira > > Btw, from the CI log, we have: > > igt@kms_addfb_basic@invalid-smem-bo-on-discrete: > shard-apl: NOTRUN -> FAIL > shard-tglb: NOTRUN -> FAIL > shard-glk: NOTRUN -> FAIL > shard-kbl: NOTRUN -> FAIL > shard-snb: NOTRUN -> FAIL > shard-iclb: NOTRUN -> FAIL > > igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-async-flip: > shard-iclb: NOTRUN -> SKIP +1 similar issue > > I don't know why your patch makes something that was not running start > to run. Any theory? > > Thanks > > -- > Rodrigo Siqueira > https://siqueira.tech _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev