From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 490F5C433F5 for ; Wed, 15 Dec 2021 17:25:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=09Asx/N792C0ZhP6jyWkfwo1D5lEIcQImfi4Z/HdNtU=; b=QpwjbyCrD9dpuY lEJ4MmpBBtDs2smc1pSYnVBmFqBq/ZTgV0SLLdktubnk3xb3KkTY2mT8MtCt9EGs7jT4Gye6K7f90 /QOFHZVlIE3PNhOaaUEuC/XD9kHUwUO4KM/EZkYQkQ2yeCtdTnWiCN6Li0jxE2j6vSAksgRNn582I yhdywov0KxtMoaNXhZJPbt+Mcq9CMxfV35uvx/fYSHKRo0n9S58rv345p2S/dqm96tYhEyzg1idEw LbuglTyR5UIz0b0o3PEzsg2DrzRqyzysC1+Zl2ojXvjWKthCsKOO/fxKpqhAD77wFbQMbV1WU7J7+ xLrKDZFD9abkvIK4KnGA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxY22-00252o-0S; Wed, 15 Dec 2021 17:25:34 +0000 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxY1l-0024va-1x for linux-mediatek@lists.infradead.org; Wed, 15 Dec 2021 17:25:19 +0000 Received: by mail-lf1-x136.google.com with SMTP id l22so44471491lfg.7 for ; Wed, 15 Dec 2021 09:25:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Ru1QL2NBcOaL08U8KTJ8X+cObMY1RMiyv3ZA0fT6+tc=; b=NR1IRP7NBuHpjy3NNtMcQtDrQeD4PxJvs2bqCI4hudQOXKBccGAg80rzb7VJTpUgKj b7Bp+VIFxZ1rqSd77PsBDV7klG9eUd3MurAAwSlG5r1DquTsvSnoKtfYPeZcEXouJWtA G52s1P4JbdQ81xsrDlSW58wYsOKxsMMQ9xqwo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Ru1QL2NBcOaL08U8KTJ8X+cObMY1RMiyv3ZA0fT6+tc=; b=T2d/ds3GQ6tmB1sH6l5pmHimvw3wp5LUm7bXkqoeVdEXX0IUZt/ciRNKg6dveyQ4mC 9C+kS5q7uu/t/VGs4I11ic1EIrbJg4RzgNb4LNeJEOcmVb5zM0DTSU838IZq4J1ldEfy osXodzTdZS5d6qMHL837O1pf9i9aux7ttvmZRFa/lvUJXHwxUCtZ5ehpF5mTGpTD4ryM gK5h7GWRwMgiGh5VGnPRyw1HofsGBITzXmjJ3WADiLRRtsp7p02xk8JAMz0NRGyrUM4w IZwJ43dE+XUeSVCcF+h/kJbaQs6x2Cao9A8LYT3dSwryHCjt/y0VZTkiwdwF12OSwPj7 1ZfQ== X-Gm-Message-State: AOAM530F329n/S3DX2WCVLugliLRQZGr9KHKDdpt9H6ozV67cTVGQgf1 95uYLe0you5PmqNdkcxX7Qv9a988j2gx9/0DU+g3zQ== X-Google-Smtp-Source: ABdhPJznEJza5b1lb+va724WlFIkZtOElqFWZGL/mIh6Ux79XpFZA9BLaQf0YiyCn/PejWZESk08SwEHLgkNYSPRTxQ= X-Received: by 2002:a19:7417:: with SMTP id v23mr10778310lfe.19.1639589114100; Wed, 15 Dec 2021 09:25:14 -0800 (PST) MIME-Version: 1.0 References: <20211022172413.195559-1-markyacoub@chromium.org> <20211026011318.GF2515@art_vandelay> In-Reply-To: From: Mark Yacoub Date: Wed, 15 Dec 2021 12:25:02 -0500 Message-ID: Subject: Re: [PATCH] mediatek: Set default value for Panel Orientation connector prop. To: Chun-Kuang Hu Cc: Sean Paul , "moderated list:ARM/Mediatek SoC support" , Sean Paul , Mark Yacoub , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , DRI Development , Linux ARM , linux-kernel X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211215_092517_157472_76D0DAF0 X-CRM114-Status: GOOD ( 24.54 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org T24gV2VkLCBEZWMgMTUsIDIwMjEgYXQgMTE6MTQgQU0gQ2h1bi1LdWFuZyBIdSA8Y2h1bmt1YW5n Lmh1QGtlcm5lbC5vcmc+IHdyb3RlOgo+Cj4gSGksIE1hcms6Cj4KPiBNYXJrIFlhY291YiA8bWFy a3lhY291YkBjaHJvbWl1bS5vcmc+IOaWvCAyMDIx5bm0MTLmnIgxNOaXpSDpgLHkuowg5LiL5Y2I MTE6MTPlr6vpgZPvvJoKPiA+Cj4gPiBIZXkgQ0ssIGNhbiB3ZSBoYXZlIHRoaXMgbWVyZ2VkPwo+ ID4gVGhhbmsgeW91IQo+ID4KPiA+IE9uIE1vbiwgT2N0IDI1LCAyMDIxIGF0IDk6MTMgUE0gU2Vh biBQYXVsIDxzZWFuQHBvb3JseS5ydW4+IHdyb3RlOgo+ID4gPgo+ID4gPiBPbiBGcmksIE9jdCAy MiwgMjAyMSBhdCAwMToyNDowM1BNIC0wNDAwLCBNYXJrIFlhY291YiB3cm90ZToKPiA+ID4gPiBG cm9tOiBNYXJrIFlhY291YiA8bWFya3lhY291YkBjaHJvbWl1bS5vcmc+Cj4gPiA+ID4KPiA+ID4g PiBbV2h5XQo+ID4gPiA+IENyZWF0aW5nIHRoZSBwcm9wIHVzZXMgVU5LTk9XTiBhcyB0aGUgaW5p dGlhbCB2YWx1ZSwgd2hpY2ggaXMgbm90IGEKPiA+ID4gPiBzdXBwb3J0ZWQgdmFsdWUgaWYgdGhl IHByb3BzIGlzIHRvIGJlIHN1cHBvcnRlZC4KPiA+ID4gPgo+ID4gPiA+IFtIb3ddCj4gPiA+ID4g U2V0IHRoZSBwYW5lbCBvcmllbnRhdGlvbiBkZWZhdWx0IHZhbHVlIHRvIE5PUk1BTCByaWdodCBh ZnRlciBjcmVhdGluZwo+ID4gPiA+IHRoZSBwcm9wLgo+ID4gPgo+ID4gPiBSZXZpZXdlZC1ieTog U2VhbiBQYXVsIDxzZWFucGF1bEBjaHJvbWl1bS5vcmc+Cj4gPiA+Cj4gPiA+ID4KPiA+ID4gPiBU ZXN0ZWQgb24gSmFjdXp6aShNVEspCj4gPiA+ID4gRml4ZXMgSUdUQGttc19wcm9wZXJ0aWVzQGdl dF9wcm9wZXJ0aWVzLXNhbml0eS17YXRvbWljLG5vbi1hdG9taWN9Cj4gPiA+ID4KPiA+ID4gPiBT aWduZWQtb2ZmLWJ5OiBNYXJrIFlhY291YiA8bWFya3lhY291YkBjaHJvbWl1bS5vcmc+Cj4gPiA+ ID4gLS0tCj4gPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHNpLmMgfCAyICsr Cj4gPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKykKPiA+ID4gPgo+ID4gPiA+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RzaS5jIGIvZHJpdmVy cy9ncHUvZHJtL21lZGlhdGVrL210a19kc2kuYwo+ID4gPiA+IGluZGV4IDBhZDcxNTc2NjBhZmEu LmI3YzI1MjhhOGY0MWMgMTAwNjQ0Cj4gPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21lZGlh dGVrL210a19kc2kuYwo+ID4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtf ZHNpLmMKPiA+ID4gPiBAQCAtMTAzOSw2ICsxMDM5LDggQEAgc3RhdGljIGludCBtdGtfZHNpX2Vu Y29kZXJfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZHJtLCBzdHJ1Y3QgbXRrX2RzaSAqZHNpKQo+ ID4gPiA+ICAgICAgICAgICAgICAgRFJNX0VSUk9SKCJVbmFibGUgdG8gaW5pdCBwYW5lbCBvcmll bnRhdGlvblxuIik7Cj4gPiA+ID4gICAgICAgICAgICAgICBnb3RvIGVycl9jbGVhbnVwX2VuY29k ZXI7Cj4gPiA+ID4gICAgICAgfQo+ID4gPiA+ICsgICAgIGRybV9jb25uZWN0b3Jfc2V0X3BhbmVs X29yaWVudGF0aW9uKGRzaS0+Y29ubmVjdG9yLAo+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIERSTV9NT0RFX1BBTkVMX09SSUVOVEFUSU9OX05PUk1BTCk7 Cj4KPiBJbiBkcm1fY29ubmVjdG9yX3NldF9wYW5lbF9vcmllbnRhdGlvbigpIFsxXSwgSSBmaW5k IHRoYXQgdGhlCj4gb3JpZW50YXRpb24gY291bGQgYmUgc2V0IG9ubHkgb25jZS4gT25jZSB5b3Ug c2V0IGl0IHRvIG5vcm1hbCwgaXQKPiBjb3VsZCBub3QgYmUgc2V0IHRvIG90aGVyIG9yaWVudGF0 aW9uLiBSaWdodD8KPgpIZWxsbywKWWVhaCB0aGlzIGxvb2tzIHRydWUsIGFuZCBtYWtlcyBzZW5z ZSBhY2NvcmRpbmcgdG8gdGhlIGRvY3VtZW50YXRpb246Cmh0dHBzOi8vMDEub3JnL2xpbnV4Z3Jh cGhpY3MvZ2Z4LWRvY3MvZHJtL2dwdS9kcm0ta21zLmh0bWwjOn46dGV4dD1vbmUlMjBzdGFuZGFy ZGl6ZWQlMjBwcm9wZXJ0eSUzQS0scGFuZWwlMjBvcmllbnRhdGlvbiUzQSwtT24lMjBzb21lJTIw ZGV2aWNlcwoKUGFuZWwgb3JpZW50YXRpb24gaGFzIHRvIGRvIHdpdGggdGhlIGhvdyB0aGUgaGFy ZHdhcmUgaXMgbW91bnRlZCwgaW4KY29udHJhc3Qgd2l0aCB0aGUgUm90YXRpb24gcHJvcGVydHku IEFsbCB0aGUgSFcgd2UgaGF2ZSByaWdodCBub3cgaGFzCmEgbm9ybWFsIHBhbmVsIG9yaWVudGF0 aW9uIHNvIGl0IG1ha2VzIHNlbnNlIHRvIGJlIHNldCB0aGlzIHdheS4gQW1vbmcKb3RoZXIgZHJp dmVycywgcGFuZWwgb3JpZW50YXRpb24gaXMgYWx3YXlzIHNldCByaWdodCBhZnRlciB0aGUKcHJv cGVydHkgaXMgaW5pdGlhbGl6ZWQuCgo+IFsxXSBodHRwczovL2dpdC5rZXJuZWwub3JnL3B1Yi9z Y20vbGludXgva2VybmVsL2dpdC90b3J2YWxkcy9saW51eC5naXQvdHJlZS9kcml2ZXJzL2dwdS9k cm0vZHJtX2Nvbm5lY3Rvci5jP2g9djUuMTYtcmM1I24yMzAyCj4KPiBSZWdhcmRzLAo+IENodW4t S3VhbmcuCj4KPiA+ID4gPgo+ID4gPiA+ICAgICAgIGRybV9jb25uZWN0b3JfYXR0YWNoX2VuY29k ZXIoZHNpLT5jb25uZWN0b3IsICZkc2ktPmVuY29kZXIpOwo+ID4gPiA+Cj4gPiA+ID4gLS0KPiA+ ID4gPiAyLjMzLjAuMTA3OS5nNmU3MDc3OGRjOS1nb29nCj4gPiA+ID4KPiA+ID4KPiA+ID4gLS0K PiA+ID4gU2VhbiBQYXVsLCBTb2Z0d2FyZSBFbmdpbmVlciwgR29vZ2xlIC8gQ2hyb21pdW0gT1MK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LW1l ZGlhdGVrIG1haWxpbmcgbGlzdApMaW51eC1tZWRpYXRla0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbWVkaWF0ZWsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22955C4332F for ; Wed, 15 Dec 2021 17:25:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1B71510F2C2; Wed, 15 Dec 2021 17:25:16 +0000 (UTC) Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by gabe.freedesktop.org (Postfix) with ESMTPS id BB27310F2C2 for ; Wed, 15 Dec 2021 17:25:15 +0000 (UTC) Received: by mail-lf1-x12f.google.com with SMTP id k37so44597368lfv.3 for ; Wed, 15 Dec 2021 09:25:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Ru1QL2NBcOaL08U8KTJ8X+cObMY1RMiyv3ZA0fT6+tc=; b=NR1IRP7NBuHpjy3NNtMcQtDrQeD4PxJvs2bqCI4hudQOXKBccGAg80rzb7VJTpUgKj b7Bp+VIFxZ1rqSd77PsBDV7klG9eUd3MurAAwSlG5r1DquTsvSnoKtfYPeZcEXouJWtA G52s1P4JbdQ81xsrDlSW58wYsOKxsMMQ9xqwo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Ru1QL2NBcOaL08U8KTJ8X+cObMY1RMiyv3ZA0fT6+tc=; b=7LKq+3fwRxb/Tp2Wq7Vhqa2H5rJNYHdfoViCpkJeslp1QqV31j8hNWsdstfggLupAX Z4bqI//6xeRea5EJrInt6QRAX3KN8lmXv1/5PaaEgCfZWlbeURPY+kHkN9tRFrlA6CB9 HCfw2tQbt7oCKXyu9Rsiekwz7q/mibgw9GONQfwsOGPCiHDigTs0tMdOFDp9s4TPnmGJ J2+AXqqn8xozdGFmuVdjZVlCf+zaVhq2XvHxtgtd1G0XcvEDWUzbAlu8Y+1RZQHeKCyn w26MSiPR6i5+u4xI0R/3UuRYHQyk6/rSb1HoCF2/YrPjwbiJvdReTOY2PxY7edVA2Iih YJDQ== X-Gm-Message-State: AOAM5314028OURUKyGIQQUqq8rgjU3Ku1l/GuU1UJOP1ptTBVOEynLES Bs/mGWn8a9FlI96h1QDMBbJHIk58UQ593zmEJXdkZg== X-Google-Smtp-Source: ABdhPJznEJza5b1lb+va724WlFIkZtOElqFWZGL/mIh6Ux79XpFZA9BLaQf0YiyCn/PejWZESk08SwEHLgkNYSPRTxQ= X-Received: by 2002:a19:7417:: with SMTP id v23mr10778310lfe.19.1639589114100; Wed, 15 Dec 2021 09:25:14 -0800 (PST) MIME-Version: 1.0 References: <20211022172413.195559-1-markyacoub@chromium.org> <20211026011318.GF2515@art_vandelay> In-Reply-To: From: Mark Yacoub Date: Wed, 15 Dec 2021 12:25:02 -0500 Message-ID: Subject: Re: [PATCH] mediatek: Set default value for Panel Orientation connector prop. To: Chun-Kuang Hu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel , DRI Development , Sean Paul , Matthias Brugger , "moderated list:ARM/Mediatek SoC support" , Sean Paul , Linux ARM , Mark Yacoub Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Dec 15, 2021 at 11:14 AM Chun-Kuang Hu wr= ote: > > Hi, Mark: > > Mark Yacoub =E6=96=BC 2021=E5=B9=B412=E6=9C=881= 4=E6=97=A5 =E9=80=B1=E4=BA=8C =E4=B8=8B=E5=8D=8811:13=E5=AF=AB=E9=81=93=EF= =BC=9A > > > > Hey CK, can we have this merged? > > Thank you! > > > > On Mon, Oct 25, 2021 at 9:13 PM Sean Paul wrote: > > > > > > On Fri, Oct 22, 2021 at 01:24:03PM -0400, Mark Yacoub wrote: > > > > From: Mark Yacoub > > > > > > > > [Why] > > > > Creating the prop uses UNKNOWN as the initial value, which is not a > > > > supported value if the props is to be supported. > > > > > > > > [How] > > > > Set the panel orientation default value to NORMAL right after creat= ing > > > > the prop. > > > > > > Reviewed-by: Sean Paul > > > > > > > > > > > Tested on Jacuzzi(MTK) > > > > Fixes IGT@kms_properties@get_properties-sanity-{atomic,non-atomic} > > > > > > > > Signed-off-by: Mark Yacoub > > > > --- > > > > drivers/gpu/drm/mediatek/mtk_dsi.c | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/m= ediatek/mtk_dsi.c > > > > index 0ad7157660afa..b7c2528a8f41c 100644 > > > > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > > > > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > > > > @@ -1039,6 +1039,8 @@ static int mtk_dsi_encoder_init(struct drm_de= vice *drm, struct mtk_dsi *dsi) > > > > DRM_ERROR("Unable to init panel orientation\n"); > > > > goto err_cleanup_encoder; > > > > } > > > > + drm_connector_set_panel_orientation(dsi->connector, > > > > + DRM_MODE_PANEL_ORIENTATIO= N_NORMAL); > > In drm_connector_set_panel_orientation() [1], I find that the > orientation could be set only once. Once you set it to normal, it > could not be set to other orientation. Right? > Hello, Yeah this looks true, and makes sense according to the documentation: https://01.org/linuxgraphics/gfx-docs/drm/gpu/drm-kms.html#:~:text=3Done%20= standardized%20property%3A-,panel%20orientation%3A,-On%20some%20devices Panel orientation has to do with the how the hardware is mounted, in contrast with the Rotation property. All the HW we have right now has a normal panel orientation so it makes sense to be set this way. Among other drivers, panel orientation is always set right after the property is initialized. > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tr= ee/drivers/gpu/drm/drm_connector.c?h=3Dv5.16-rc5#n2302 > > Regards, > Chun-Kuang. > > > > > > > > > drm_connector_attach_encoder(dsi->connector, &dsi->encoder); > > > > > > > > -- > > > > 2.33.0.1079.g6e70778dc9-goog > > > > > > > > > > -- > > > Sean Paul, Software Engineer, Google / Chromium OS From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DBADC4332F for ; Wed, 15 Dec 2021 17:27:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343994AbhLOR07 (ORCPT ); Wed, 15 Dec 2021 12:26:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343682AbhLORZV (ORCPT ); Wed, 15 Dec 2021 12:25:21 -0500 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7906C0698C6 for ; Wed, 15 Dec 2021 09:25:15 -0800 (PST) Received: by mail-lf1-x135.google.com with SMTP id cf39so32384490lfb.8 for ; Wed, 15 Dec 2021 09:25:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Ru1QL2NBcOaL08U8KTJ8X+cObMY1RMiyv3ZA0fT6+tc=; b=NR1IRP7NBuHpjy3NNtMcQtDrQeD4PxJvs2bqCI4hudQOXKBccGAg80rzb7VJTpUgKj b7Bp+VIFxZ1rqSd77PsBDV7klG9eUd3MurAAwSlG5r1DquTsvSnoKtfYPeZcEXouJWtA G52s1P4JbdQ81xsrDlSW58wYsOKxsMMQ9xqwo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Ru1QL2NBcOaL08U8KTJ8X+cObMY1RMiyv3ZA0fT6+tc=; b=KV5+HRTivQ49kvorSTBWOIrNugxR6OSEcGiG87JR3OaySMMA9dINT9i86iCvXApbxW lU4Q1bxlzRGSULbm2abgv8CXJjemoQt6ue4QJyr/Tndyzv0nOGJGN3RuaERy3o/ZbGc5 VjQ52Yln3oyOM2XsOicNwe93tYeT3aAbvJFHzG4T1qI09xefTELTobj8WjW4R/lwf9E2 XnK+VJAbMxehk98iX70axdTr1LN1K4ILKgJP7aJTXKElPsi9pMh4mwwqksqxng2Yw/Ra xq68J999iAbYSZR5uT3J+gX7TGsP+QLCS0WF7p/0Bg+g+teI0KZip4b39QdDNoi2uY19 TcBA== X-Gm-Message-State: AOAM5323R/MpS5ls4Hq+1nRAS08PIGYcw68yh56+Ui4vOg2WmiKWZtuZ 4IqyRnrmzFqPR9mFM8Jpj/3Bw31UPGC4vO0mooD5/Q== X-Google-Smtp-Source: ABdhPJznEJza5b1lb+va724WlFIkZtOElqFWZGL/mIh6Ux79XpFZA9BLaQf0YiyCn/PejWZESk08SwEHLgkNYSPRTxQ= X-Received: by 2002:a19:7417:: with SMTP id v23mr10778310lfe.19.1639589114100; Wed, 15 Dec 2021 09:25:14 -0800 (PST) MIME-Version: 1.0 References: <20211022172413.195559-1-markyacoub@chromium.org> <20211026011318.GF2515@art_vandelay> In-Reply-To: From: Mark Yacoub Date: Wed, 15 Dec 2021 12:25:02 -0500 Message-ID: Subject: Re: [PATCH] mediatek: Set default value for Panel Orientation connector prop. To: Chun-Kuang Hu Cc: Sean Paul , "moderated list:ARM/Mediatek SoC support" , Sean Paul , Mark Yacoub , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , DRI Development , Linux ARM , linux-kernel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 15, 2021 at 11:14 AM Chun-Kuang Hu wr= ote: > > Hi, Mark: > > Mark Yacoub =E6=96=BC 2021=E5=B9=B412=E6=9C=881= 4=E6=97=A5 =E9=80=B1=E4=BA=8C =E4=B8=8B=E5=8D=8811:13=E5=AF=AB=E9=81=93=EF= =BC=9A > > > > Hey CK, can we have this merged? > > Thank you! > > > > On Mon, Oct 25, 2021 at 9:13 PM Sean Paul wrote: > > > > > > On Fri, Oct 22, 2021 at 01:24:03PM -0400, Mark Yacoub wrote: > > > > From: Mark Yacoub > > > > > > > > [Why] > > > > Creating the prop uses UNKNOWN as the initial value, which is not a > > > > supported value if the props is to be supported. > > > > > > > > [How] > > > > Set the panel orientation default value to NORMAL right after creat= ing > > > > the prop. > > > > > > Reviewed-by: Sean Paul > > > > > > > > > > > Tested on Jacuzzi(MTK) > > > > Fixes IGT@kms_properties@get_properties-sanity-{atomic,non-atomic} > > > > > > > > Signed-off-by: Mark Yacoub > > > > --- > > > > drivers/gpu/drm/mediatek/mtk_dsi.c | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/m= ediatek/mtk_dsi.c > > > > index 0ad7157660afa..b7c2528a8f41c 100644 > > > > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > > > > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > > > > @@ -1039,6 +1039,8 @@ static int mtk_dsi_encoder_init(struct drm_de= vice *drm, struct mtk_dsi *dsi) > > > > DRM_ERROR("Unable to init panel orientation\n"); > > > > goto err_cleanup_encoder; > > > > } > > > > + drm_connector_set_panel_orientation(dsi->connector, > > > > + DRM_MODE_PANEL_ORIENTATIO= N_NORMAL); > > In drm_connector_set_panel_orientation() [1], I find that the > orientation could be set only once. Once you set it to normal, it > could not be set to other orientation. Right? > Hello, Yeah this looks true, and makes sense according to the documentation: https://01.org/linuxgraphics/gfx-docs/drm/gpu/drm-kms.html#:~:text=3Done%20= standardized%20property%3A-,panel%20orientation%3A,-On%20some%20devices Panel orientation has to do with the how the hardware is mounted, in contrast with the Rotation property. All the HW we have right now has a normal panel orientation so it makes sense to be set this way. Among other drivers, panel orientation is always set right after the property is initialized. > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tr= ee/drivers/gpu/drm/drm_connector.c?h=3Dv5.16-rc5#n2302 > > Regards, > Chun-Kuang. > > > > > > > > > drm_connector_attach_encoder(dsi->connector, &dsi->encoder); > > > > > > > > -- > > > > 2.33.0.1079.g6e70778dc9-goog > > > > > > > > > > -- > > > Sean Paul, Software Engineer, Google / Chromium OS From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E72A7C4332F for ; Wed, 15 Dec 2021 17:26:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zlSAcES/qfoJxIhNjnHdezoBu8cyRi00atpbV7+FtGI=; b=HlUOffB0ue5bZ2 VPTx6xOLmsZDHdJo4qMYMrSULzEtQAgtuplMihSwdeGx1ixk2X8y2F9zmKSUMf/MRKqAa3D1YmTiS YCnY5JCWHPOekI3nCHKaS4RYSYejH8FT/X8jVKOFsdq0k43Yjh3Cie2rydIpG6RRSatwROnPjdYUT NjmCmA5u889l5xsIeSp5X10Pj/H6ES2TUYsKoChfiefP1kw1TZRJ8hOWLVDqp8Hr9Jhblh37KdKIu ZIKeLoDDYKlsQaIlYWXjH6+ajA2BZDqJj9ZYmiN5ivnWJhNP644YQcNBXCm0hoVlsnUeOhDNoCq+B pm4OSHIttdgeQm0D0EVA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxY1q-0024yp-TS; Wed, 15 Dec 2021 17:25:23 +0000 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxY1l-0024vZ-25 for linux-arm-kernel@lists.infradead.org; Wed, 15 Dec 2021 17:25:19 +0000 Received: by mail-lf1-x136.google.com with SMTP id d10so44532296lfg.6 for ; Wed, 15 Dec 2021 09:25:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Ru1QL2NBcOaL08U8KTJ8X+cObMY1RMiyv3ZA0fT6+tc=; b=NR1IRP7NBuHpjy3NNtMcQtDrQeD4PxJvs2bqCI4hudQOXKBccGAg80rzb7VJTpUgKj b7Bp+VIFxZ1rqSd77PsBDV7klG9eUd3MurAAwSlG5r1DquTsvSnoKtfYPeZcEXouJWtA G52s1P4JbdQ81xsrDlSW58wYsOKxsMMQ9xqwo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Ru1QL2NBcOaL08U8KTJ8X+cObMY1RMiyv3ZA0fT6+tc=; b=3uPwqdKXXfU+b5g6z74cXx91a56INiHb0m8FuDkY0ZdPyHZLpzuhVV4yvWmav3XbGx wbOL4T8M3LmhU+hqAq2OMj4vWgGatWbQd0K9mfcbhSgmUdSpB1+LnW0p7x9a0zfl6cgs 4X0ai6GjhOuDRVlRU9wEvdeejkNTCAaT1Yg+lJfkyuc94naKNOVqRdbryIA7GrEy2gaN V+RsdIZc0eAq1Fo2D5AJ3RKF4zowaHJGKBWfPF9ONLt1vbnGLMr0VgVyvFcHK2DLL6uV 9l06GiW+qIItAQak1nZZKAiDEl5ZysCNWQ24CNbml6LOHcklCH6HlEsaLBfEySnaZchz 6tCA== X-Gm-Message-State: AOAM532dI6HRWfCtsu5RqpmRKtqE0Akl7WHarHgQd+xm2PFc/ReTVb9R pf8j517fnXqROMVu/qONGxm4X2uofAXF2oqfpPFfQw== X-Google-Smtp-Source: ABdhPJznEJza5b1lb+va724WlFIkZtOElqFWZGL/mIh6Ux79XpFZA9BLaQf0YiyCn/PejWZESk08SwEHLgkNYSPRTxQ= X-Received: by 2002:a19:7417:: with SMTP id v23mr10778310lfe.19.1639589114100; Wed, 15 Dec 2021 09:25:14 -0800 (PST) MIME-Version: 1.0 References: <20211022172413.195559-1-markyacoub@chromium.org> <20211026011318.GF2515@art_vandelay> In-Reply-To: From: Mark Yacoub Date: Wed, 15 Dec 2021 12:25:02 -0500 Message-ID: Subject: Re: [PATCH] mediatek: Set default value for Panel Orientation connector prop. To: Chun-Kuang Hu Cc: Sean Paul , "moderated list:ARM/Mediatek SoC support" , Sean Paul , Mark Yacoub , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , DRI Development , Linux ARM , linux-kernel X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211215_092517_150618_19B21235 X-CRM114-Status: GOOD ( 25.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBEZWMgMTUsIDIwMjEgYXQgMTE6MTQgQU0gQ2h1bi1LdWFuZyBIdSA8Y2h1bmt1YW5n Lmh1QGtlcm5lbC5vcmc+IHdyb3RlOgo+Cj4gSGksIE1hcms6Cj4KPiBNYXJrIFlhY291YiA8bWFy a3lhY291YkBjaHJvbWl1bS5vcmc+IOaWvCAyMDIx5bm0MTLmnIgxNOaXpSDpgLHkuowg5LiL5Y2I MTE6MTPlr6vpgZPvvJoKPiA+Cj4gPiBIZXkgQ0ssIGNhbiB3ZSBoYXZlIHRoaXMgbWVyZ2VkPwo+ ID4gVGhhbmsgeW91IQo+ID4KPiA+IE9uIE1vbiwgT2N0IDI1LCAyMDIxIGF0IDk6MTMgUE0gU2Vh biBQYXVsIDxzZWFuQHBvb3JseS5ydW4+IHdyb3RlOgo+ID4gPgo+ID4gPiBPbiBGcmksIE9jdCAy MiwgMjAyMSBhdCAwMToyNDowM1BNIC0wNDAwLCBNYXJrIFlhY291YiB3cm90ZToKPiA+ID4gPiBG cm9tOiBNYXJrIFlhY291YiA8bWFya3lhY291YkBjaHJvbWl1bS5vcmc+Cj4gPiA+ID4KPiA+ID4g PiBbV2h5XQo+ID4gPiA+IENyZWF0aW5nIHRoZSBwcm9wIHVzZXMgVU5LTk9XTiBhcyB0aGUgaW5p dGlhbCB2YWx1ZSwgd2hpY2ggaXMgbm90IGEKPiA+ID4gPiBzdXBwb3J0ZWQgdmFsdWUgaWYgdGhl IHByb3BzIGlzIHRvIGJlIHN1cHBvcnRlZC4KPiA+ID4gPgo+ID4gPiA+IFtIb3ddCj4gPiA+ID4g U2V0IHRoZSBwYW5lbCBvcmllbnRhdGlvbiBkZWZhdWx0IHZhbHVlIHRvIE5PUk1BTCByaWdodCBh ZnRlciBjcmVhdGluZwo+ID4gPiA+IHRoZSBwcm9wLgo+ID4gPgo+ID4gPiBSZXZpZXdlZC1ieTog U2VhbiBQYXVsIDxzZWFucGF1bEBjaHJvbWl1bS5vcmc+Cj4gPiA+Cj4gPiA+ID4KPiA+ID4gPiBU ZXN0ZWQgb24gSmFjdXp6aShNVEspCj4gPiA+ID4gRml4ZXMgSUdUQGttc19wcm9wZXJ0aWVzQGdl dF9wcm9wZXJ0aWVzLXNhbml0eS17YXRvbWljLG5vbi1hdG9taWN9Cj4gPiA+ID4KPiA+ID4gPiBT aWduZWQtb2ZmLWJ5OiBNYXJrIFlhY291YiA8bWFya3lhY291YkBjaHJvbWl1bS5vcmc+Cj4gPiA+ ID4gLS0tCj4gPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHNpLmMgfCAyICsr Cj4gPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKykKPiA+ID4gPgo+ID4gPiA+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RzaS5jIGIvZHJpdmVy cy9ncHUvZHJtL21lZGlhdGVrL210a19kc2kuYwo+ID4gPiA+IGluZGV4IDBhZDcxNTc2NjBhZmEu LmI3YzI1MjhhOGY0MWMgMTAwNjQ0Cj4gPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21lZGlh dGVrL210a19kc2kuYwo+ID4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtf ZHNpLmMKPiA+ID4gPiBAQCAtMTAzOSw2ICsxMDM5LDggQEAgc3RhdGljIGludCBtdGtfZHNpX2Vu Y29kZXJfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZHJtLCBzdHJ1Y3QgbXRrX2RzaSAqZHNpKQo+ ID4gPiA+ICAgICAgICAgICAgICAgRFJNX0VSUk9SKCJVbmFibGUgdG8gaW5pdCBwYW5lbCBvcmll bnRhdGlvblxuIik7Cj4gPiA+ID4gICAgICAgICAgICAgICBnb3RvIGVycl9jbGVhbnVwX2VuY29k ZXI7Cj4gPiA+ID4gICAgICAgfQo+ID4gPiA+ICsgICAgIGRybV9jb25uZWN0b3Jfc2V0X3BhbmVs X29yaWVudGF0aW9uKGRzaS0+Y29ubmVjdG9yLAo+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIERSTV9NT0RFX1BBTkVMX09SSUVOVEFUSU9OX05PUk1BTCk7 Cj4KPiBJbiBkcm1fY29ubmVjdG9yX3NldF9wYW5lbF9vcmllbnRhdGlvbigpIFsxXSwgSSBmaW5k IHRoYXQgdGhlCj4gb3JpZW50YXRpb24gY291bGQgYmUgc2V0IG9ubHkgb25jZS4gT25jZSB5b3Ug c2V0IGl0IHRvIG5vcm1hbCwgaXQKPiBjb3VsZCBub3QgYmUgc2V0IHRvIG90aGVyIG9yaWVudGF0 aW9uLiBSaWdodD8KPgpIZWxsbywKWWVhaCB0aGlzIGxvb2tzIHRydWUsIGFuZCBtYWtlcyBzZW5z ZSBhY2NvcmRpbmcgdG8gdGhlIGRvY3VtZW50YXRpb246Cmh0dHBzOi8vMDEub3JnL2xpbnV4Z3Jh cGhpY3MvZ2Z4LWRvY3MvZHJtL2dwdS9kcm0ta21zLmh0bWwjOn46dGV4dD1vbmUlMjBzdGFuZGFy ZGl6ZWQlMjBwcm9wZXJ0eSUzQS0scGFuZWwlMjBvcmllbnRhdGlvbiUzQSwtT24lMjBzb21lJTIw ZGV2aWNlcwoKUGFuZWwgb3JpZW50YXRpb24gaGFzIHRvIGRvIHdpdGggdGhlIGhvdyB0aGUgaGFy ZHdhcmUgaXMgbW91bnRlZCwgaW4KY29udHJhc3Qgd2l0aCB0aGUgUm90YXRpb24gcHJvcGVydHku IEFsbCB0aGUgSFcgd2UgaGF2ZSByaWdodCBub3cgaGFzCmEgbm9ybWFsIHBhbmVsIG9yaWVudGF0 aW9uIHNvIGl0IG1ha2VzIHNlbnNlIHRvIGJlIHNldCB0aGlzIHdheS4gQW1vbmcKb3RoZXIgZHJp dmVycywgcGFuZWwgb3JpZW50YXRpb24gaXMgYWx3YXlzIHNldCByaWdodCBhZnRlciB0aGUKcHJv cGVydHkgaXMgaW5pdGlhbGl6ZWQuCgo+IFsxXSBodHRwczovL2dpdC5rZXJuZWwub3JnL3B1Yi9z Y20vbGludXgva2VybmVsL2dpdC90b3J2YWxkcy9saW51eC5naXQvdHJlZS9kcml2ZXJzL2dwdS9k cm0vZHJtX2Nvbm5lY3Rvci5jP2g9djUuMTYtcmM1I24yMzAyCj4KPiBSZWdhcmRzLAo+IENodW4t S3VhbmcuCj4KPiA+ID4gPgo+ID4gPiA+ICAgICAgIGRybV9jb25uZWN0b3JfYXR0YWNoX2VuY29k ZXIoZHNpLT5jb25uZWN0b3IsICZkc2ktPmVuY29kZXIpOwo+ID4gPiA+Cj4gPiA+ID4gLS0KPiA+ ID4gPiAyLjMzLjAuMTA3OS5nNmU3MDc3OGRjOS1nb29nCj4gPiA+ID4KPiA+ID4KPiA+ID4gLS0K PiA+ID4gU2VhbiBQYXVsLCBTb2Z0d2FyZSBFbmdpbmVlciwgR29vZ2xlIC8gQ2hyb21pdW0gT1MK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFy bS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1r ZXJuZWwK