All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gi-Oh Kim <gi-oh.kim@profitbricks.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>,
	"Gioh Kim" <gi-oh.kim@profitbricks.com>,
	andre.przywara@amd.com, kvm@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] KVM: SVM: ignore type when setting segment registers
Date: Wed, 31 May 2017 08:42:08 +0200	[thread overview]
Message-ID: <CAJX1Yta08Gr_N9BYuKfiaBkQe9yb1qT+wBjtjaN4fucKCzKLWQ@mail.gmail.com> (raw)
In-Reply-To: <20170530180358.GA13648@hydra.tuxags.com>

On Tue, May 30, 2017 at 8:03 PM, Matt Mullins <mmullins@mmlx.us> wrote:
> On Tue, May 30, 2017 at 02:54:21PM +0200, Radim Krčmář wrote:
>> 2017-05-29 15:24+0200, Gioh Kim:
>> > If so, why type is checked when setting segment registers?
>>
>> No idea.  19bca6ab75d8 ("KVM: SVM: Fix cross vendor migration issue with
>> unusable bit") also moved the assigment up to initialize it before use
>> and I think that is enough.
>
> Was this perhaps intended to instead check for a zero selector, which is also
> an unusable segment?

I think that is what present value is for.


-- 
Best regards,
Gi-Oh Kim
TEL: 0176 2697 8962

      reply	other threads:[~2017-05-31  6:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-29 13:24 [RFC] KVM: SVM: ignore type when setting segment registers Gioh Kim
2017-05-30 12:54 ` Radim Krčmář
2017-05-30 13:37   ` Gioh Kim
2017-05-30 18:03   ` Matt Mullins
2017-05-31  6:42     ` Gi-Oh Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJX1Yta08Gr_N9BYuKfiaBkQe9yb1qT+wBjtjaN4fucKCzKLWQ@mail.gmail.com \
    --to=gi-oh.kim@profitbricks.com \
    --cc=andre.przywara@amd.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rkrcmar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.