From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0AA4C433FE for ; Tue, 19 Apr 2022 09:22:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350332AbiDSJZZ (ORCPT ); Tue, 19 Apr 2022 05:25:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236434AbiDSJZY (ORCPT ); Tue, 19 Apr 2022 05:25:24 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2BF32A27C for ; Tue, 19 Apr 2022 02:22:41 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id u3so21584492wrg.3 for ; Tue, 19 Apr 2022 02:22:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=p8P6IeNR1TwtrMg6RsrKfdY4Yo5Rygb5DfiPVUoKhK8=; b=by0FVyX6p0zMcvlQP3Y+c8K8TzgSgvcE5pyCF1vetrjvKiBQtCgOwo2ZZWote70zYk o9LMkdzdoRmlCNb2amRWJGhf1KdRzvw+TmHMwSj3jdMJksgGdAr/RMXpGiMyCbL3wax2 91qaPs2u8lB9l4uXPjOarOfRvJX+DT5UFJGrw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=p8P6IeNR1TwtrMg6RsrKfdY4Yo5Rygb5DfiPVUoKhK8=; b=6LH8eyOXyehArCVvZJDvyQESYcCWVUFdyJD+WE0MOIxnnf4C+FLGRZ7Yg9pzxsthxX 9ex6+RafBjBO+UahHScZ5Pacbfw4phzIaE080jDNiKvcesyl6kG6JwOPDsqNBjvqHvJE FSP9IZN6aooDSwjI7ViRkfM3ZzNfGA5nZ3+jl3y926d/XtD/hIrDP/FTQoBf+H0TC9Hq RDJMogvtagxFbyrwuO9XiYYzhk2cSqEiXI/boIhIm/gihxOC3ohjxneKSqlxe7zBCgL5 jQkoDouFoZN7tvccHzU8WwZmoZRlVOyQ/rRLAwRl0/PJpYuM4xxngiOqdjkvd/D2Obmg O0TQ== X-Gm-Message-State: AOAM531WR81aheTU1Xt3h2FyY51cvaZQe0CGqCldntdOPhe6+p+qknAI c8jYOpOy9izbizwwBuxNMyHGbUwlrUB+O1BtH763Hw== X-Google-Smtp-Source: ABdhPJzFGn7LU0fqJ7O61lsvDaAZ/2DWIaGN8GbhlNMmxqCmPG3XLkxvdSi+ys256zE0obhK3F0PwBs+L0/P7lP7rrk= X-Received: by 2002:a05:6000:18c1:b0:207:87dc:94b2 with SMTP id w1-20020a05600018c100b0020787dc94b2mr10927908wrq.437.1650360160433; Tue, 19 Apr 2022 02:22:40 -0700 (PDT) MIME-Version: 1.0 References: <1649844596-5264-1-git-send-email-quic_srivasam@quicinc.com> In-Reply-To: <1649844596-5264-1-git-send-email-quic_srivasam@quicinc.com> From: Judy Hsiao Date: Tue, 19 Apr 2022 17:22:29 +0800 Message-ID: Subject: Re: [PATCH] ASoC: qcom: lpass-platform: Update memremap flag to MEMREMAP_WC To: Srinivasa Rao Mandadapu Cc: agross@kernel.org, bjorn.andersson@linaro.org, lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, quic_plai@quicinc.com, bgoswami@codeaurora.org, perex@perex.cz, tiwai@suse.com, srinivas.kandagatla@linaro.org, quic_rohkumar@quicinc.com, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, swboyd@chromium.org, Venkata Prasad Potturu Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org > - buf->area = (unsigned char * __force)memremap(buf->addr, buf->bytes, MEMREMAP_WT); > + buf->area = (unsigned char * __force)memremap(buf->addr, buf->bytes, MEMREMAP_WC); Should we replace the memremap() with other standard DMA buffer allocation API like: snd_pcm_set_managed_buffer() ? Thanks! > > return 0; > } > -- > 2.7.4 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50DC5C433F5 for ; Tue, 19 Apr 2022 09:23:38 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8E9A4173F; Tue, 19 Apr 2022 11:22:46 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8E9A4173F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1650360216; bh=5HnvdYm+MxcNp1CSTFoRixzcgUTfrbNWTkciH0qr290=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ajR3+iOs5PigEmX2lV4fnxrYnl2SZ9dw9DqL/oiCvkxKBydkAzFRtZBfNWgRKxd8M HaHkL9RLyiPEhUIk6VgkmoC1t/nbkMr0Xqkt9MczgvKUHrsSzs/OC07Sw6v2qRNpS9 hjhW+BL/PFxdClxpJ9ZtvxW/AzVxDwNV6uHEl0IM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2E95CF80237; Tue, 19 Apr 2022 11:22:46 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A9940F8025D; Tue, 19 Apr 2022 11:22:44 +0200 (CEST) Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 11022F80116 for ; Tue, 19 Apr 2022 11:22:41 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 11022F80116 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="by0FVyX6" Received: by mail-wr1-x42d.google.com with SMTP id bv16so4419986wrb.9 for ; Tue, 19 Apr 2022 02:22:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=p8P6IeNR1TwtrMg6RsrKfdY4Yo5Rygb5DfiPVUoKhK8=; b=by0FVyX6p0zMcvlQP3Y+c8K8TzgSgvcE5pyCF1vetrjvKiBQtCgOwo2ZZWote70zYk o9LMkdzdoRmlCNb2amRWJGhf1KdRzvw+TmHMwSj3jdMJksgGdAr/RMXpGiMyCbL3wax2 91qaPs2u8lB9l4uXPjOarOfRvJX+DT5UFJGrw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=p8P6IeNR1TwtrMg6RsrKfdY4Yo5Rygb5DfiPVUoKhK8=; b=GhiH++LAc/d92VL6sfaRvlNd2k9OkUjKvAX0mXdfTOOJ05vwgF2y5+yeKraKtDtkDY uOvU3xg6IUGfJ5TzHi0eRd/AHCPuSfZqq0lw6dXoKG9zYFcHBj8nL1W+Wo+ZVmtX9/OK KUo+tARb7graEF7FET4epBB2PEyzCmXhU2zPjkaShCAM4Xg1+UuE9iB1kL239jRzMDd7 gljy17rwTni3T2zLOFFyR0t4gQg0/4aUOE6c6f+VgaByRDUKaYHud4ATjs5JeV9y1Vnd yYFH9cGMdO6LjQ3TIdL3wunJ7GuY7G4ODFRdW50ZPdru8xX76Zpx3s8kiMEwYDtetn+z ipCQ== X-Gm-Message-State: AOAM531YdRAHH0z7qDt8s64/c/F/wrrFGnylSSbKQA/o1aID0pM972yo 17Q5uTU07I3b9VnnVfBprMVdxYWHXNl9IleMj9BDlw== X-Google-Smtp-Source: ABdhPJzFGn7LU0fqJ7O61lsvDaAZ/2DWIaGN8GbhlNMmxqCmPG3XLkxvdSi+ys256zE0obhK3F0PwBs+L0/P7lP7rrk= X-Received: by 2002:a05:6000:18c1:b0:207:87dc:94b2 with SMTP id w1-20020a05600018c100b0020787dc94b2mr10927908wrq.437.1650360160433; Tue, 19 Apr 2022 02:22:40 -0700 (PDT) MIME-Version: 1.0 References: <1649844596-5264-1-git-send-email-quic_srivasam@quicinc.com> In-Reply-To: <1649844596-5264-1-git-send-email-quic_srivasam@quicinc.com> From: Judy Hsiao Date: Tue, 19 Apr 2022 17:22:29 +0800 Message-ID: Subject: Re: [PATCH] ASoC: qcom: lpass-platform: Update memremap flag to MEMREMAP_WC To: Srinivasa Rao Mandadapu Content-Type: text/plain; charset="UTF-8" Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, bgoswami@codeaurora.org, Venkata Prasad Potturu , linux-arm-msm@vger.kernel.org, swboyd@chromium.org, tiwai@suse.com, agross@kernel.org, robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, srinivas.kandagatla@linaro.org, quic_rohkumar@quicinc.com, quic_plai@quicinc.com, bjorn.andersson@linaro.org, linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" > - buf->area = (unsigned char * __force)memremap(buf->addr, buf->bytes, MEMREMAP_WT); > + buf->area = (unsigned char * __force)memremap(buf->addr, buf->bytes, MEMREMAP_WC); Should we replace the memremap() with other standard DMA buffer allocation API like: snd_pcm_set_managed_buffer() ? Thanks! > > return 0; > } > -- > 2.7.4 >