From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754068AbdCMQSz (ORCPT ); Mon, 13 Mar 2017 12:18:55 -0400 Received: from mail-it0-f54.google.com ([209.85.214.54]:35514 "EHLO mail-it0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752892AbdCMQSi (ORCPT ); Mon, 13 Mar 2017 12:18:38 -0400 MIME-Version: 1.0 In-Reply-To: <2f21aeb3-dd4e-e170-729a-a785077b6f28@xilinx.com> References: <1489181435-3151-1-git-send-email-mdf@kernel.org> <1489181435-3151-2-git-send-email-mdf@kernel.org> <2f21aeb3-dd4e-e170-729a-a785077b6f28@xilinx.com> From: Moritz Fischer Date: Mon, 13 Mar 2017 09:18:31 -0700 Message-ID: Subject: Re: [PATCH 2/2] fpga: Add support for Xilinx LogiCORE PR Decoupler To: Michal Simek Cc: linux-fpga@vger.kernel.org, Rob Herring , Mark Rutland , linux-arm-kernel , =?UTF-8?Q?S=C3=B6ren_Brinkmann?= , Linux Kernel Mailing List , Devicetree List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v2DGJ2ch002536 On Mon, Mar 13, 2017 at 3:27 AM, Michal Simek wrote: > Hi Moritz, > > On 10.3.2017 23:42, Moritz Fischer wrote: >> On Fri, Mar 10, 2017 at 1:30 PM, Moritz Fischer wrote: >>> This adds support for the Xilinx LogiCORE PR Decoupler >>> soft-ip that does decoupling of PR regions in the FPGA >>> fabric during partial reconfiguration. >>> >>> Signed-off-by: Moritz Fischer >>> Cc: Michal Simek >>> Cc: Sören Brinkmann >>> Cc: linux-kernel@vger.kernel.org >>> Cc: devicetree@vger.kernel.org >>> --- >>> drivers/fpga/Kconfig | 9 +++ >>> drivers/fpga/Makefile | 1 + >>> drivers/fpga/xilinx-pr-decoupler.c | 156 +++++++++++++++++++++++++++++++++++++ >>> 3 files changed, 166 insertions(+) >>> create mode 100644 drivers/fpga/xilinx-pr-decoupler.c > > I have written very similar driver some week ago but didn't sent it out. Hah. I'll take a look. > Here it is. > https://github.com/Xilinx/linux-xlnx/blob/master/drivers/fpga/xilinx-pr-decoupler.c > > Your clk handling is better and my enable_show is better. > You shouldn't rely on setting status before. It is better to read that > reg again. The reason is you can connect status signal from one PR > decoupler to decouple input which can change status I will just merge them together and add you to author's list if that's fine with you? > There is another topic I wanted to open in connection to this. There > should be gpio based bridge because this pr decoupler can be without axi > interface and for that gpio driver would be useful. That's a good idea. I can look at that. This can be pretty generic code I suppose. Cheers, Moritz From mboxrd@z Thu Jan 1 00:00:00 1970 From: Moritz Fischer Subject: Re: [PATCH 2/2] fpga: Add support for Xilinx LogiCORE PR Decoupler Date: Mon, 13 Mar 2017 09:18:31 -0700 Message-ID: References: <1489181435-3151-1-git-send-email-mdf@kernel.org> <1489181435-3151-2-git-send-email-mdf@kernel.org> <2f21aeb3-dd4e-e170-729a-a785077b6f28@xilinx.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <2f21aeb3-dd4e-e170-729a-a785077b6f28-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Michal Simek Cc: linux-fpga-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Mark Rutland , linux-arm-kernel , =?UTF-8?Q?S=C3=B6ren_Brinkmann?= , Linux Kernel Mailing List , Devicetree List List-Id: devicetree@vger.kernel.org On Mon, Mar 13, 2017 at 3:27 AM, Michal Simek wro= te: > Hi Moritz, > > On 10.3.2017 23:42, Moritz Fischer wrote: >> On Fri, Mar 10, 2017 at 1:30 PM, Moritz Fischer wrote: >>> This adds support for the Xilinx LogiCORE PR Decoupler >>> soft-ip that does decoupling of PR regions in the FPGA >>> fabric during partial reconfiguration. >>> >>> Signed-off-by: Moritz Fischer >>> Cc: Michal Simek >>> Cc: S=C3=B6ren Brinkmann >>> Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >>> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >>> --- >>> drivers/fpga/Kconfig | 9 +++ >>> drivers/fpga/Makefile | 1 + >>> drivers/fpga/xilinx-pr-decoupler.c | 156 +++++++++++++++++++++++++++++= ++++++++ >>> 3 files changed, 166 insertions(+) >>> create mode 100644 drivers/fpga/xilinx-pr-decoupler.c > > I have written very similar driver some week ago but didn't sent it out. Hah. I'll take a look. > Here it is. > https://github.com/Xilinx/linux-xlnx/blob/master/drivers/fpga/xilinx-pr-d= ecoupler.c > > Your clk handling is better and my enable_show is better. > You shouldn't rely on setting status before. It is better to read that > reg again. The reason is you can connect status signal from one PR > decoupler to decouple input which can change status I will just merge them together and add you to author's list if that's fine with you? > There is another topic I wanted to open in connection to this. There > should be gpio based bridge because this pr decoupler can be without axi > interface and for that gpio driver would be useful. That's a good idea. I can look at that. This can be pretty generic code I suppose. Cheers, Moritz -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: moritz.fischer.private@gmail.com (Moritz Fischer) Date: Mon, 13 Mar 2017 09:18:31 -0700 Subject: [PATCH 2/2] fpga: Add support for Xilinx LogiCORE PR Decoupler In-Reply-To: <2f21aeb3-dd4e-e170-729a-a785077b6f28@xilinx.com> References: <1489181435-3151-1-git-send-email-mdf@kernel.org> <1489181435-3151-2-git-send-email-mdf@kernel.org> <2f21aeb3-dd4e-e170-729a-a785077b6f28@xilinx.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Mar 13, 2017 at 3:27 AM, Michal Simek wrote: > Hi Moritz, > > On 10.3.2017 23:42, Moritz Fischer wrote: >> On Fri, Mar 10, 2017 at 1:30 PM, Moritz Fischer wrote: >>> This adds support for the Xilinx LogiCORE PR Decoupler >>> soft-ip that does decoupling of PR regions in the FPGA >>> fabric during partial reconfiguration. >>> >>> Signed-off-by: Moritz Fischer >>> Cc: Michal Simek >>> Cc: S?ren Brinkmann >>> Cc: linux-kernel at vger.kernel.org >>> Cc: devicetree at vger.kernel.org >>> --- >>> drivers/fpga/Kconfig | 9 +++ >>> drivers/fpga/Makefile | 1 + >>> drivers/fpga/xilinx-pr-decoupler.c | 156 +++++++++++++++++++++++++++++++++++++ >>> 3 files changed, 166 insertions(+) >>> create mode 100644 drivers/fpga/xilinx-pr-decoupler.c > > I have written very similar driver some week ago but didn't sent it out. Hah. I'll take a look. > Here it is. > https://github.com/Xilinx/linux-xlnx/blob/master/drivers/fpga/xilinx-pr-decoupler.c > > Your clk handling is better and my enable_show is better. > You shouldn't rely on setting status before. It is better to read that > reg again. The reason is you can connect status signal from one PR > decoupler to decouple input which can change status I will just merge them together and add you to author's list if that's fine with you? > There is another topic I wanted to open in connection to this. There > should be gpio based bridge because this pr decoupler can be without axi > interface and for that gpio driver would be useful. That's a good idea. I can look at that. This can be pretty generic code I suppose. Cheers, Moritz