All of lore.kernel.org
 help / color / mirror / Atom feed
* [v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED
@ 2018-04-26 17:40 ` Moritz Fischer
  0 siblings, 0 replies; 16+ messages in thread
From: mdf @ 2018-04-26 17:40 UTC (permalink / raw)
  To: linux-kernel; +Cc: dmaengine, dan.j.williams, vinod.koul, lars, Moritz Fischer

Request IRQ with IRQF_SHARED flag. This works since the interrupt
handler already checks if there is an actual IRQ pending and returns
IRQ_NONE otherwise.

Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Moritz Fischer <mdf@kernel.org>
---
Changes from v1:
- Added Lars' Acked-by
- Dropped patch [1/2] and changed accordingly
---
 drivers/dma/dma-axi-dmac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
index 2419fe524daa..15b2453d2647 100644
--- a/drivers/dma/dma-axi-dmac.c
+++ b/drivers/dma/dma-axi-dmac.c
@@ -687,7 +687,7 @@ static int axi_dmac_probe(struct platform_device *pdev)
 	if (ret)
 		goto err_unregister_device;
 
-	ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, 0,
+	ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, IRQF_SHARED,
 		dev_name(&pdev->dev), dmac);
 	if (ret)
 		goto err_unregister_of;

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [PATCH v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED
@ 2018-04-26 17:40 ` Moritz Fischer
  0 siblings, 0 replies; 16+ messages in thread
From: Moritz Fischer @ 2018-04-26 17:40 UTC (permalink / raw)
  To: linux-kernel; +Cc: dmaengine, dan.j.williams, vinod.koul, lars, Moritz Fischer

Request IRQ with IRQF_SHARED flag. This works since the interrupt
handler already checks if there is an actual IRQ pending and returns
IRQ_NONE otherwise.

Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Moritz Fischer <mdf@kernel.org>
---
Changes from v1:
- Added Lars' Acked-by
- Dropped patch [1/2] and changed accordingly
---
 drivers/dma/dma-axi-dmac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
index 2419fe524daa..15b2453d2647 100644
--- a/drivers/dma/dma-axi-dmac.c
+++ b/drivers/dma/dma-axi-dmac.c
@@ -687,7 +687,7 @@ static int axi_dmac_probe(struct platform_device *pdev)
 	if (ret)
 		goto err_unregister_device;
 
-	ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, 0,
+	ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, IRQF_SHARED,
 		dev_name(&pdev->dev), dmac);
 	if (ret)
 		goto err_unregister_of;
-- 
2.17.0

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED
  2018-04-26 17:40 ` [PATCH v2] " Moritz Fischer
@ 2018-04-27  5:11 ` Vinod Koul
  -1 siblings, 0 replies; 16+ messages in thread
From: Vinod Koul @ 2018-04-27  5:11 UTC (permalink / raw)
  To: Moritz Fischer; +Cc: linux-kernel, dmaengine, dan.j.williams, lars

On Thu, Apr 26, 2018 at 10:40:00AM -0700, Moritz Fischer wrote:
> Request IRQ with IRQF_SHARED flag. This works since the interrupt
> handler already checks if there is an actual IRQ pending and returns
> IRQ_NONE otherwise.

hmmm what are we trying to fix here? Is your device on a shared line or not?

> 
> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
> ---
> Changes from v1:
> - Added Lars' Acked-by
> - Dropped patch [1/2] and changed accordingly
> ---
>  drivers/dma/dma-axi-dmac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
> index 2419fe524daa..15b2453d2647 100644
> --- a/drivers/dma/dma-axi-dmac.c
> +++ b/drivers/dma/dma-axi-dmac.c
> @@ -687,7 +687,7 @@ static int axi_dmac_probe(struct platform_device *pdev)
>  	if (ret)
>  		goto err_unregister_device;
>  
> -	ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, 0,
> +	ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, IRQF_SHARED,
>  		dev_name(&pdev->dev), dmac);
>  	if (ret)
>  		goto err_unregister_of;
> -- 
> 2.17.0
>

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED
@ 2018-04-27  5:11 ` Vinod Koul
  0 siblings, 0 replies; 16+ messages in thread
From: Vinod Koul @ 2018-04-27  5:11 UTC (permalink / raw)
  To: Moritz Fischer; +Cc: linux-kernel, dmaengine, dan.j.williams, lars

On Thu, Apr 26, 2018 at 10:40:00AM -0700, Moritz Fischer wrote:
> Request IRQ with IRQF_SHARED flag. This works since the interrupt
> handler already checks if there is an actual IRQ pending and returns
> IRQ_NONE otherwise.

hmmm what are we trying to fix here? Is your device on a shared line or not?

> 
> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
> ---
> Changes from v1:
> - Added Lars' Acked-by
> - Dropped patch [1/2] and changed accordingly
> ---
>  drivers/dma/dma-axi-dmac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
> index 2419fe524daa..15b2453d2647 100644
> --- a/drivers/dma/dma-axi-dmac.c
> +++ b/drivers/dma/dma-axi-dmac.c
> @@ -687,7 +687,7 @@ static int axi_dmac_probe(struct platform_device *pdev)
>  	if (ret)
>  		goto err_unregister_device;
>  
> -	ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, 0,
> +	ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, IRQF_SHARED,
>  		dev_name(&pdev->dev), dmac);
>  	if (ret)
>  		goto err_unregister_of;
> -- 
> 2.17.0
> 

-- 
~Vinod

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED
  2018-04-27  5:11 ` [PATCH v2] " Vinod Koul
@ 2018-04-27  6:53 ` Lars-Peter Clausen
  -1 siblings, 0 replies; 16+ messages in thread
From: Lars-Peter Clausen @ 2018-04-27  6:53 UTC (permalink / raw)
  To: Vinod Koul, Moritz Fischer; +Cc: linux-kernel, dmaengine, dan.j.williams

On 04/27/2018 07:11 AM, Vinod Koul wrote:
> On Thu, Apr 26, 2018 at 10:40:00AM -0700, Moritz Fischer wrote:
>> Request IRQ with IRQF_SHARED flag. This works since the interrupt
>> handler already checks if there is an actual IRQ pending and returns
>> IRQ_NONE otherwise.
> 
> hmmm what are we trying to fix here? Is your device on a shared line or not?

IRQF_SHARED does not mean that the IRQ is on a shared line. It means that
the driver can handle it if the IRQ is on a shared line. Since the driver
can handle it setting the flag is a good idea since this enables usecases
where the line is shared.

> 
>>
>> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
>> Signed-off-by: Moritz Fischer <mdf@kernel.org>
>> ---
>> Changes from v1:
>> - Added Lars' Acked-by
>> - Dropped patch [1/2] and changed accordingly
>> ---
>>  drivers/dma/dma-axi-dmac.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
>> index 2419fe524daa..15b2453d2647 100644
>> --- a/drivers/dma/dma-axi-dmac.c
>> +++ b/drivers/dma/dma-axi-dmac.c
>> @@ -687,7 +687,7 @@ static int axi_dmac_probe(struct platform_device *pdev)
>>  	if (ret)
>>  		goto err_unregister_device;
>>  
>> -	ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, 0,
>> +	ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, IRQF_SHARED,
>>  		dev_name(&pdev->dev), dmac);
>>  	if (ret)
>>  		goto err_unregister_of;
>> -- 
>> 2.17.0
>>
>
---
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED
@ 2018-04-27  6:53 ` Lars-Peter Clausen
  0 siblings, 0 replies; 16+ messages in thread
From: Lars-Peter Clausen @ 2018-04-27  6:53 UTC (permalink / raw)
  To: Vinod Koul, Moritz Fischer; +Cc: linux-kernel, dmaengine, dan.j.williams

On 04/27/2018 07:11 AM, Vinod Koul wrote:
> On Thu, Apr 26, 2018 at 10:40:00AM -0700, Moritz Fischer wrote:
>> Request IRQ with IRQF_SHARED flag. This works since the interrupt
>> handler already checks if there is an actual IRQ pending and returns
>> IRQ_NONE otherwise.
> 
> hmmm what are we trying to fix here? Is your device on a shared line or not?

IRQF_SHARED does not mean that the IRQ is on a shared line. It means that
the driver can handle it if the IRQ is on a shared line. Since the driver
can handle it setting the flag is a good idea since this enables usecases
where the line is shared.

> 
>>
>> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
>> Signed-off-by: Moritz Fischer <mdf@kernel.org>
>> ---
>> Changes from v1:
>> - Added Lars' Acked-by
>> - Dropped patch [1/2] and changed accordingly
>> ---
>>  drivers/dma/dma-axi-dmac.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
>> index 2419fe524daa..15b2453d2647 100644
>> --- a/drivers/dma/dma-axi-dmac.c
>> +++ b/drivers/dma/dma-axi-dmac.c
>> @@ -687,7 +687,7 @@ static int axi_dmac_probe(struct platform_device *pdev)
>>  	if (ret)
>>  		goto err_unregister_device;
>>  
>> -	ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, 0,
>> +	ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, IRQF_SHARED,
>>  		dev_name(&pdev->dev), dmac);
>>  	if (ret)
>>  		goto err_unregister_of;
>> -- 
>> 2.17.0
>>
> 

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED
  2018-04-27  6:53 ` [PATCH v2] " Lars-Peter Clausen
@ 2018-04-27  7:08 ` Vinod Koul
  -1 siblings, 0 replies; 16+ messages in thread
From: Vinod Koul @ 2018-04-27  7:08 UTC (permalink / raw)
  To: Lars-Peter Clausen
  Cc: Moritz Fischer, linux-kernel, dmaengine, dan.j.williams

On Fri, Apr 27, 2018 at 08:53:39AM +0200, Lars-Peter Clausen wrote:
> On 04/27/2018 07:11 AM, Vinod Koul wrote:
> > On Thu, Apr 26, 2018 at 10:40:00AM -0700, Moritz Fischer wrote:
> >> Request IRQ with IRQF_SHARED flag. This works since the interrupt
> >> handler already checks if there is an actual IRQ pending and returns
> >> IRQ_NONE otherwise.
> > 
> > hmmm what are we trying to fix here? Is your device on a shared line or not?
> 
> IRQF_SHARED does not mean that the IRQ is on a shared line. It means that
> the driver can handle it if the IRQ is on a shared line. Since the driver
> can handle it setting the flag is a good idea since this enables usecases
> where the line is shared.

Yes that is correct indeed, but what is the motivation for the change.

If you never expect this to be in shared environment why to do this?
Sorry but "it works" is not a good enough reason for this change, to enable
usecases where the line is shared is a good reason :)

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED
@ 2018-04-27  7:08 ` Vinod Koul
  0 siblings, 0 replies; 16+ messages in thread
From: Vinod Koul @ 2018-04-27  7:08 UTC (permalink / raw)
  To: Lars-Peter Clausen
  Cc: Moritz Fischer, linux-kernel, dmaengine, dan.j.williams

On Fri, Apr 27, 2018 at 08:53:39AM +0200, Lars-Peter Clausen wrote:
> On 04/27/2018 07:11 AM, Vinod Koul wrote:
> > On Thu, Apr 26, 2018 at 10:40:00AM -0700, Moritz Fischer wrote:
> >> Request IRQ with IRQF_SHARED flag. This works since the interrupt
> >> handler already checks if there is an actual IRQ pending and returns
> >> IRQ_NONE otherwise.
> > 
> > hmmm what are we trying to fix here? Is your device on a shared line or not?
> 
> IRQF_SHARED does not mean that the IRQ is on a shared line. It means that
> the driver can handle it if the IRQ is on a shared line. Since the driver
> can handle it setting the flag is a good idea since this enables usecases
> where the line is shared.

Yes that is correct indeed, but what is the motivation for the change.

If you never expect this to be in shared environment why to do this?
Sorry but "it works" is not a good enough reason for this change, to enable
usecases where the line is shared is a good reason :)

-- 
~Vinod

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED
  2018-04-27  7:08 ` [PATCH v2] " Vinod Koul
@ 2018-04-27 15:15 ` Moritz Fischer
  -1 siblings, 0 replies; 16+ messages in thread
From: Moritz Fischer @ 2018-04-27 15:15 UTC (permalink / raw)
  To: Vinod Koul
  Cc: Lars-Peter Clausen, Linux Kernel Mailing List, dmaengine, dan.j.williams

Hi Vinod,

On Fri, Apr 27, 2018 at 12:08 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> On Fri, Apr 27, 2018 at 08:53:39AM +0200, Lars-Peter Clausen wrote:
>> On 04/27/2018 07:11 AM, Vinod Koul wrote:
>> > On Thu, Apr 26, 2018 at 10:40:00AM -0700, Moritz Fischer wrote:
>> >> Request IRQ with IRQF_SHARED flag. This works since the interrupt
>> >> handler already checks if there is an actual IRQ pending and returns
>> >> IRQ_NONE otherwise.
>> >
>> > hmmm what are we trying to fix here? Is your device on a shared line or not?
>>
>> IRQF_SHARED does not mean that the IRQ is on a shared line. It means that
>> the driver can handle it if the IRQ is on a shared line. Since the driver
>> can handle it setting the flag is a good idea since this enables usecases
>> where the line is shared.
>
> Yes that is correct indeed, but what is the motivation for the change.
>
> If you never expect this to be in shared environment why to do this?
> Sorry but "it works" is not a good enough reason for this change, to enable
> usecases where the line is shared is a good reason :)

Remember, this is an FPGA soft core. I happen to have a design [1] where it
is hooked up with multiple of them on one IRQ line, so to make this work,
I need this change.

Thanks,

Moritz

[1] https://www.ettus.com/product/details/USRP-N310
---
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED
@ 2018-04-27 15:15 ` Moritz Fischer
  0 siblings, 0 replies; 16+ messages in thread
From: Moritz Fischer @ 2018-04-27 15:15 UTC (permalink / raw)
  To: Vinod Koul
  Cc: Lars-Peter Clausen, Linux Kernel Mailing List, dmaengine, dan.j.williams

Hi Vinod,

On Fri, Apr 27, 2018 at 12:08 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> On Fri, Apr 27, 2018 at 08:53:39AM +0200, Lars-Peter Clausen wrote:
>> On 04/27/2018 07:11 AM, Vinod Koul wrote:
>> > On Thu, Apr 26, 2018 at 10:40:00AM -0700, Moritz Fischer wrote:
>> >> Request IRQ with IRQF_SHARED flag. This works since the interrupt
>> >> handler already checks if there is an actual IRQ pending and returns
>> >> IRQ_NONE otherwise.
>> >
>> > hmmm what are we trying to fix here? Is your device on a shared line or not?
>>
>> IRQF_SHARED does not mean that the IRQ is on a shared line. It means that
>> the driver can handle it if the IRQ is on a shared line. Since the driver
>> can handle it setting the flag is a good idea since this enables usecases
>> where the line is shared.
>
> Yes that is correct indeed, but what is the motivation for the change.
>
> If you never expect this to be in shared environment why to do this?
> Sorry but "it works" is not a good enough reason for this change, to enable
> usecases where the line is shared is a good reason :)

Remember, this is an FPGA soft core. I happen to have a design [1] where it
is hooked up with multiple of them on one IRQ line, so to make this work,
I need this change.

Thanks,

Moritz

[1] https://www.ettus.com/product/details/USRP-N310

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED
  2018-04-27 15:15 ` [PATCH v2] " Moritz Fischer
@ 2018-04-27 15:18 ` Lars-Peter Clausen
  -1 siblings, 0 replies; 16+ messages in thread
From: Lars-Peter Clausen @ 2018-04-27 15:18 UTC (permalink / raw)
  To: Moritz Fischer, Vinod Koul
  Cc: Linux Kernel Mailing List, dmaengine, dan.j.williams

On 04/27/2018 05:15 PM, Moritz Fischer wrote:
> Hi Vinod,
> 
> On Fri, Apr 27, 2018 at 12:08 AM, Vinod Koul <vinod.koul@intel.com> wrote:
>> On Fri, Apr 27, 2018 at 08:53:39AM +0200, Lars-Peter Clausen wrote:
>>> On 04/27/2018 07:11 AM, Vinod Koul wrote:
>>>> On Thu, Apr 26, 2018 at 10:40:00AM -0700, Moritz Fischer wrote:
>>>>> Request IRQ with IRQF_SHARED flag. This works since the interrupt
>>>>> handler already checks if there is an actual IRQ pending and returns
>>>>> IRQ_NONE otherwise.
>>>>
>>>> hmmm what are we trying to fix here? Is your device on a shared line or not?
>>>
>>> IRQF_SHARED does not mean that the IRQ is on a shared line. It means that
>>> the driver can handle it if the IRQ is on a shared line. Since the driver
>>> can handle it setting the flag is a good idea since this enables usecases
>>> where the line is shared.
>>
>> Yes that is correct indeed, but what is the motivation for the change.
>>
>> If you never expect this to be in shared environment why to do this?
>> Sorry but "it works" is not a good enough reason for this change, to enable
>> usecases where the line is shared is a good reason :)
> 
> Remember, this is an FPGA soft core. I happen to have a design [1] where it
> is hooked up with multiple of them on one IRQ line, so to make this work,
> I need this change.

I think what Vinod is asking for is a change to the commit message saying
that "this change enables the driver to be used with devices where the
interrupt line is shared".
---
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED
@ 2018-04-27 15:18 ` Lars-Peter Clausen
  0 siblings, 0 replies; 16+ messages in thread
From: Lars-Peter Clausen @ 2018-04-27 15:18 UTC (permalink / raw)
  To: Moritz Fischer, Vinod Koul
  Cc: Linux Kernel Mailing List, dmaengine, dan.j.williams

On 04/27/2018 05:15 PM, Moritz Fischer wrote:
> Hi Vinod,
> 
> On Fri, Apr 27, 2018 at 12:08 AM, Vinod Koul <vinod.koul@intel.com> wrote:
>> On Fri, Apr 27, 2018 at 08:53:39AM +0200, Lars-Peter Clausen wrote:
>>> On 04/27/2018 07:11 AM, Vinod Koul wrote:
>>>> On Thu, Apr 26, 2018 at 10:40:00AM -0700, Moritz Fischer wrote:
>>>>> Request IRQ with IRQF_SHARED flag. This works since the interrupt
>>>>> handler already checks if there is an actual IRQ pending and returns
>>>>> IRQ_NONE otherwise.
>>>>
>>>> hmmm what are we trying to fix here? Is your device on a shared line or not?
>>>
>>> IRQF_SHARED does not mean that the IRQ is on a shared line. It means that
>>> the driver can handle it if the IRQ is on a shared line. Since the driver
>>> can handle it setting the flag is a good idea since this enables usecases
>>> where the line is shared.
>>
>> Yes that is correct indeed, but what is the motivation for the change.
>>
>> If you never expect this to be in shared environment why to do this?
>> Sorry but "it works" is not a good enough reason for this change, to enable
>> usecases where the line is shared is a good reason :)
> 
> Remember, this is an FPGA soft core. I happen to have a design [1] where it
> is hooked up with multiple of them on one IRQ line, so to make this work,
> I need this change.

I think what Vinod is asking for is a change to the commit message saying
that "this change enables the driver to be used with devices where the
interrupt line is shared".

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED
  2018-04-27 15:18 ` [PATCH v2] " Lars-Peter Clausen
@ 2018-04-28  5:10 ` Vinod Koul
  -1 siblings, 0 replies; 16+ messages in thread
From: Vinod Koul @ 2018-04-28  5:10 UTC (permalink / raw)
  To: Lars-Peter Clausen
  Cc: Moritz Fischer, Linux Kernel Mailing List, dmaengine, dan.j.williams

On Fri, Apr 27, 2018 at 05:18:29PM +0200, Lars-Peter Clausen wrote:
> On 04/27/2018 05:15 PM, Moritz Fischer wrote:
> > Hi Vinod,
> > 
> > On Fri, Apr 27, 2018 at 12:08 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> >> On Fri, Apr 27, 2018 at 08:53:39AM +0200, Lars-Peter Clausen wrote:
> >>> On 04/27/2018 07:11 AM, Vinod Koul wrote:
> >>>> On Thu, Apr 26, 2018 at 10:40:00AM -0700, Moritz Fischer wrote:
> >>>>> Request IRQ with IRQF_SHARED flag. This works since the interrupt
> >>>>> handler already checks if there is an actual IRQ pending and returns
> >>>>> IRQ_NONE otherwise.
> >>>>
> >>>> hmmm what are we trying to fix here? Is your device on a shared line or not?
> >>>
> >>> IRQF_SHARED does not mean that the IRQ is on a shared line. It means that
> >>> the driver can handle it if the IRQ is on a shared line. Since the driver
> >>> can handle it setting the flag is a good idea since this enables usecases
> >>> where the line is shared.
> >>
> >> Yes that is correct indeed, but what is the motivation for the change.
> >>
> >> If you never expect this to be in shared environment why to do this?
> >> Sorry but "it works" is not a good enough reason for this change, to enable
> >> usecases where the line is shared is a good reason :)
> > 
> > Remember, this is an FPGA soft core. I happen to have a design [1] where it
> > is hooked up with multiple of them on one IRQ line, so to make this work,
> > I need this change.
> 
> I think what Vinod is asking for is a change to the commit message saying
> that "this change enables the driver to be used with devices where the
> interrupt line is shared".

Correct, changelog need to reflect why a change was made, down the line
people need to know the reasons, sometimes it might be even you..

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED
@ 2018-04-28  5:10 ` Vinod Koul
  0 siblings, 0 replies; 16+ messages in thread
From: Vinod Koul @ 2018-04-28  5:10 UTC (permalink / raw)
  To: Lars-Peter Clausen
  Cc: Moritz Fischer, Linux Kernel Mailing List, dmaengine, dan.j.williams

On Fri, Apr 27, 2018 at 05:18:29PM +0200, Lars-Peter Clausen wrote:
> On 04/27/2018 05:15 PM, Moritz Fischer wrote:
> > Hi Vinod,
> > 
> > On Fri, Apr 27, 2018 at 12:08 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> >> On Fri, Apr 27, 2018 at 08:53:39AM +0200, Lars-Peter Clausen wrote:
> >>> On 04/27/2018 07:11 AM, Vinod Koul wrote:
> >>>> On Thu, Apr 26, 2018 at 10:40:00AM -0700, Moritz Fischer wrote:
> >>>>> Request IRQ with IRQF_SHARED flag. This works since the interrupt
> >>>>> handler already checks if there is an actual IRQ pending and returns
> >>>>> IRQ_NONE otherwise.
> >>>>
> >>>> hmmm what are we trying to fix here? Is your device on a shared line or not?
> >>>
> >>> IRQF_SHARED does not mean that the IRQ is on a shared line. It means that
> >>> the driver can handle it if the IRQ is on a shared line. Since the driver
> >>> can handle it setting the flag is a good idea since this enables usecases
> >>> where the line is shared.
> >>
> >> Yes that is correct indeed, but what is the motivation for the change.
> >>
> >> If you never expect this to be in shared environment why to do this?
> >> Sorry but "it works" is not a good enough reason for this change, to enable
> >> usecases where the line is shared is a good reason :)
> > 
> > Remember, this is an FPGA soft core. I happen to have a design [1] where it
> > is hooked up with multiple of them on one IRQ line, so to make this work,
> > I need this change.
> 
> I think what Vinod is asking for is a change to the commit message saying
> that "this change enables the driver to be used with devices where the
> interrupt line is shared".

Correct, changelog need to reflect why a change was made, down the line
people need to know the reasons, sometimes it might be even you..

-- 
~Vinod

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED
  2018-04-28  5:10 ` [PATCH v2] " Vinod Koul
@ 2018-04-28 19:31 ` Moritz Fischer
  -1 siblings, 0 replies; 16+ messages in thread
From: mdf @ 2018-04-28 19:31 UTC (permalink / raw)
  To: Vinod Koul
  Cc: Lars-Peter Clausen, Moritz Fischer, Linux Kernel Mailing List,
	dmaengine, dan.j.williams

On Sat, Apr 28, 2018 at 10:40:43AM +0530, Vinod Koul wrote:
> On Fri, Apr 27, 2018 at 05:18:29PM +0200, Lars-Peter Clausen wrote:
> > On 04/27/2018 05:15 PM, Moritz Fischer wrote:
> > > Hi Vinod,
> > > 
> > > On Fri, Apr 27, 2018 at 12:08 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> > >> On Fri, Apr 27, 2018 at 08:53:39AM +0200, Lars-Peter Clausen wrote:
> > >>> On 04/27/2018 07:11 AM, Vinod Koul wrote:
> > >>>> On Thu, Apr 26, 2018 at 10:40:00AM -0700, Moritz Fischer wrote:
> > >>>>> Request IRQ with IRQF_SHARED flag. This works since the interrupt
> > >>>>> handler already checks if there is an actual IRQ pending and returns
> > >>>>> IRQ_NONE otherwise.
> > >>>>
> > >>>> hmmm what are we trying to fix here? Is your device on a shared line or not?
> > >>>
> > >>> IRQF_SHARED does not mean that the IRQ is on a shared line. It means that
> > >>> the driver can handle it if the IRQ is on a shared line. Since the driver
> > >>> can handle it setting the flag is a good idea since this enables usecases
> > >>> where the line is shared.
> > >>
> > >> Yes that is correct indeed, but what is the motivation for the change.
> > >>
> > >> If you never expect this to be in shared environment why to do this?
> > >> Sorry but "it works" is not a good enough reason for this change, to enable
> > >> usecases where the line is shared is a good reason :)
> > > 
> > > Remember, this is an FPGA soft core. I happen to have a design [1] where it
> > > is hooked up with multiple of them on one IRQ line, so to make this work,
> > > I need this change.
> > 
> > I think what Vinod is asking for is a change to the commit message saying
> > that "this change enables the driver to be used with devices where the
> > interrupt line is shared".
> 
> Correct, changelog need to reflect why a change was made, down the line
> people need to know the reasons, sometimes it might be even you..

Ok, communication is hard :) Will resubmit with fixed commit message,

Thanks for your feedback,

Moritz
---
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: [PATCH v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED
@ 2018-04-28 19:31 ` Moritz Fischer
  0 siblings, 0 replies; 16+ messages in thread
From: Moritz Fischer @ 2018-04-28 19:31 UTC (permalink / raw)
  To: Vinod Koul
  Cc: Lars-Peter Clausen, Moritz Fischer, Linux Kernel Mailing List,
	dmaengine, dan.j.williams

On Sat, Apr 28, 2018 at 10:40:43AM +0530, Vinod Koul wrote:
> On Fri, Apr 27, 2018 at 05:18:29PM +0200, Lars-Peter Clausen wrote:
> > On 04/27/2018 05:15 PM, Moritz Fischer wrote:
> > > Hi Vinod,
> > > 
> > > On Fri, Apr 27, 2018 at 12:08 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> > >> On Fri, Apr 27, 2018 at 08:53:39AM +0200, Lars-Peter Clausen wrote:
> > >>> On 04/27/2018 07:11 AM, Vinod Koul wrote:
> > >>>> On Thu, Apr 26, 2018 at 10:40:00AM -0700, Moritz Fischer wrote:
> > >>>>> Request IRQ with IRQF_SHARED flag. This works since the interrupt
> > >>>>> handler already checks if there is an actual IRQ pending and returns
> > >>>>> IRQ_NONE otherwise.
> > >>>>
> > >>>> hmmm what are we trying to fix here? Is your device on a shared line or not?
> > >>>
> > >>> IRQF_SHARED does not mean that the IRQ is on a shared line. It means that
> > >>> the driver can handle it if the IRQ is on a shared line. Since the driver
> > >>> can handle it setting the flag is a good idea since this enables usecases
> > >>> where the line is shared.
> > >>
> > >> Yes that is correct indeed, but what is the motivation for the change.
> > >>
> > >> If you never expect this to be in shared environment why to do this?
> > >> Sorry but "it works" is not a good enough reason for this change, to enable
> > >> usecases where the line is shared is a good reason :)
> > > 
> > > Remember, this is an FPGA soft core. I happen to have a design [1] where it
> > > is hooked up with multiple of them on one IRQ line, so to make this work,
> > > I need this change.
> > 
> > I think what Vinod is asking for is a change to the commit message saying
> > that "this change enables the driver to be used with devices where the
> > interrupt line is shared".
> 
> Correct, changelog need to reflect why a change was made, down the line
> people need to know the reasons, sometimes it might be even you..

Ok, communication is hard :) Will resubmit with fixed commit message,

Thanks for your feedback,

Moritz

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2018-04-28 19:31 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-27 15:15 [v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED Moritz Fischer
2018-04-27 15:15 ` [PATCH v2] " Moritz Fischer
  -- strict thread matches above, loose matches on Subject: below --
2018-04-28 19:31 [v2] " mdf
2018-04-28 19:31 ` [PATCH v2] " Moritz Fischer
2018-04-28  5:10 [v2] " Vinod Koul
2018-04-28  5:10 ` [PATCH v2] " Vinod Koul
2018-04-27 15:18 [v2] " Lars-Peter Clausen
2018-04-27 15:18 ` [PATCH v2] " Lars-Peter Clausen
2018-04-27  7:08 [v2] " Vinod Koul
2018-04-27  7:08 ` [PATCH v2] " Vinod Koul
2018-04-27  6:53 [v2] " Lars-Peter Clausen
2018-04-27  6:53 ` [PATCH v2] " Lars-Peter Clausen
2018-04-27  5:11 [v2] " Vinod Koul
2018-04-27  5:11 ` [PATCH v2] " Vinod Koul
2018-04-26 17:40 [v2] " mdf
2018-04-26 17:40 ` [PATCH v2] " Moritz Fischer

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.