From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 131B5C433E0 for ; Tue, 19 May 2020 17:54:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E11E420674 for ; Tue, 19 May 2020 17:54:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589910849; bh=KQ09qmJntw1c9q5pRGAJny+H3aXXXYJ/5NQQVbuBJ6I=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=eeeyPZjdrxHKWiJTONjDKi37xrYiEDEkAIEB1jEfv6+REx5Evr+EvA+aJWU3FsDP2 IWShS67+1xonVJCu0H+N5+2xX5ZnNhZaI04FYISlbb/QsyoN2RJJwwB5XEVTePokmj g6lRDN4DxhveFD+tQMqbRpXWEvOLFPW/AbhhRkGU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727814AbgESRyJ convert rfc822-to-8bit (ORCPT ); Tue, 19 May 2020 13:54:09 -0400 Received: from mail-oi1-f196.google.com ([209.85.167.196]:39216 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726059AbgESRyJ (ORCPT ); Tue, 19 May 2020 13:54:09 -0400 Received: by mail-oi1-f196.google.com with SMTP id s198so515183oie.6 for ; Tue, 19 May 2020 10:54:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=oLkdDiI5HFWL8C7O6W36h9N6UH3412FNuY/4J1ySuKI=; b=BIxbhrzNLd98yodnnR2h8w+FvaTDdJtBN9sB6cQamRDo5XKWqvledas++CSeLvGdlp pGeHjBoydD6emDPG65uTfOQfZg557Q5ySQpbYY3MSG8PdTTLA1yPxKx9ReATDfF9JdiF 2qbKpLWwqPw+m1rfth3yMWpbMQ2wRcTAs58HPPVXiWyJoamq5WOOeksf82H94raRSa+R Z4FUouzbFGK+N2tqs/j5rPkPAfVc/kTMe0Qo99HxdW/0Y6IupJn9yaNCtT/77MALseM3 djxfNio0+VtgD7RVAGZjsx75f2vVbuvM3+gLyfTwIXaHTci10ajVp6sfrdYpsWu1avoH zFUw== X-Gm-Message-State: AOAM533sGt0CI3Tcham02cYsBubz4v4Tvv6PL+htT1zXuau2Z0e29pf5 CViZMZaq3Dpzd6wMZdAlVcmSed6Nt0M++PBhcHM= X-Google-Smtp-Source: ABdhPJyQZS1Xr8gnb53yM7SiKuoBHfAVWDm0sXFCpKkYsNKzAITxSaP4lvBa4TN4o5V50bKrrF/ZMaRIevhXPrGZPZs= X-Received: by 2002:aca:4254:: with SMTP id p81mr454025oia.68.1589910847813; Tue, 19 May 2020 10:54:07 -0700 (PDT) MIME-Version: 1.0 References: <20200501164543.24423-1-james.morse@arm.com> <20200501164543.24423-2-james.morse@arm.com> <49686237.p6yG9EJavU@kreacher> <20200518125828.e4e3973c743556e976c5ee65@linux-foundation.org> <20200519031511.GA31023@hori.linux.bs1.fc.nec.co.jp> In-Reply-To: <20200519031511.GA31023@hori.linux.bs1.fc.nec.co.jp> From: "Rafael J. Wysocki" Date: Tue, 19 May 2020 19:53:56 +0200 Message-ID: Subject: Re: [PATCH v2 1/3] mm/memory-failure: Add memory_failure_queue_kick() To: =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= , James Morse Cc: Andrew Morton , "Rafael J. Wysocki" , "linux-mm@kvack.org" , "linux-acpi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Naoya Horiguchi , Len Brown , Tony Luck , Borislav Petkov , Catalin Marinas , Will Deacon , Mark Rutland , Tyler Baicar , Xie XiuQi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, May 19, 2020 at 5:15 AM HORIGUCHI NAOYA(堀口　直也) wrote: > > On Mon, May 18, 2020 at 12:58:28PM -0700, Andrew Morton wrote: > > On Mon, 18 May 2020 14:45:05 +0200 "Rafael J. Wysocki" wrote: > > > > > On Friday, May 1, 2020 6:45:41 PM CEST James Morse wrote: > > > > The GHES code calls memory_failure_queue() from IRQ context to schedule > > > > work on the current CPU so that memory_failure() can sleep. > > > > > > > > For synchronous memory errors the arch code needs to know any signals > > > > that memory_failure() will trigger are pending before it returns to > > > > user-space, possibly when exiting from the IRQ. > > > > > > > > Add a helper to kick the memory failure queue, to ensure the scheduled > > > > work has happened. This has to be called from process context, so may > > > > have been migrated from the original cpu. Pass the cpu the work was > > > > queued on. > > > > > > > > Change memory_failure_work_func() to permit being called on the 'wrong' > > > > cpu. > > > > > > > > --- a/include/linux/mm.h > > > > +++ b/include/linux/mm.h > > > > @@ -3012,6 +3012,7 @@ enum mf_flags { > > > > }; > > > > extern int memory_failure(unsigned long pfn, int flags); > > > > extern void memory_failure_queue(unsigned long pfn, int flags); > > > > +extern void memory_failure_queue_kick(int cpu); > > > > extern int unpoison_memory(unsigned long pfn); > > > > extern int get_hwpoison_page(struct page *page); > > > > #define put_hwpoison_page(page) put_page(page) > > > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > > > > index a96364be8ab4..c4afb407bf0f 100644 > > > > --- a/mm/memory-failure.c > > > > +++ b/mm/memory-failure.c > > > > @@ -1493,7 +1493,7 @@ static void memory_failure_work_func(struct work_struct *work) > > > > unsigned long proc_flags; > > > > int gotten; > > > > > > > > - mf_cpu = this_cpu_ptr(&memory_failure_cpu); > > > > + mf_cpu = container_of(work, struct memory_failure_cpu, work); > > > > for (;;) { > > > > spin_lock_irqsave(&mf_cpu->lock, proc_flags); > > > > gotten = kfifo_get(&mf_cpu->fifo, &entry); > > > > @@ -1507,6 +1507,19 @@ static void memory_failure_work_func(struct work_struct *work) > > > > } > > > > } > > > > > > > > +/* > > > > + * Process memory_failure work queued on the specified CPU. > > > > + * Used to avoid return-to-userspace racing with the memory_failure workqueue. > > > > + */ > > > > +void memory_failure_queue_kick(int cpu) > > > > +{ > > > > + struct memory_failure_cpu *mf_cpu; > > > > + > > > > + mf_cpu = &per_cpu(memory_failure_cpu, cpu); > > > > + cancel_work_sync(&mf_cpu->work); > > > > + memory_failure_work_func(&mf_cpu->work); > > > > +} > > > > + > > > > static int __init memory_failure_init(void) > > > > { > > > > struct memory_failure_cpu *mf_cpu; > > > > > > > > > > I could apply this provided an ACK from the mm people. > > > > > > > Naoya Horiguchi is the memory-failure.c person. A review would be > > appreciated please? > > > > I'm struggling with it a bit. memory_failure_queue_kick() should be > > called on the cpu which is identified by arg `cpu', yes? > > memory_failure_work_func() appears to assume this. > > > > If that's right then a) why bother passing in the `cpu' arg? and b) > > what keeps this thread pinned to that CPU? cancel_work_sync() can > > schedule. > > If I read correctly, memory_failure work is queue on the CPU on which the > user process ran when it touched the corrupted memory, and the process can > be scheduled on another CPU when the kernel returned back to userspace after > handling the GHES event. So we need to remember where the memory_failure > event is queued to flush proper work queue. So I feel that this properly > implements it. > > Considering the effect to the other caller, currently memory_failure_queue() > has 2 callers, ghes_handle_memory_failure() and cec_add_elem(). The former > is what we try to change now. And the latter is to execute soft offline > (which is related to corrected non-fatal errors), so that's not affected by > the reported issue. So I don't think that this change breaks the other > caller. > > So I'm fine with the suggested change. > > Acked-by: Naoya Horiguchi OK, thanks! So because patch [1/3] has been ACKed already, I'm applying this series as 5.8 material. Thanks everyone! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2FBBC433E2 for ; Tue, 19 May 2020 17:54:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9BB0220758 for ; Tue, 19 May 2020 17:54:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9BB0220758 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6272080007; Tue, 19 May 2020 13:54:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 605F1900002; Tue, 19 May 2020 13:54:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 53A4680007; Tue, 19 May 2020 13:54:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0223.hostedemail.com [216.40.44.223]) by kanga.kvack.org (Postfix) with ESMTP id 3BE97900002 for ; Tue, 19 May 2020 13:54:09 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 03A608245571 for ; Tue, 19 May 2020 17:54:09 +0000 (UTC) X-FDA: 76834217418.08.shock77_7b7fd6a6a9439 X-HE-Tag: shock77_7b7fd6a6a9439 X-Filterd-Recvd-Size: 7417 Received: from mail-oi1-f196.google.com (mail-oi1-f196.google.com [209.85.167.196]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Tue, 19 May 2020 17:54:08 +0000 (UTC) Received: by mail-oi1-f196.google.com with SMTP id v128so505195oia.7 for ; Tue, 19 May 2020 10:54:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=oLkdDiI5HFWL8C7O6W36h9N6UH3412FNuY/4J1ySuKI=; b=YlqYtkx2h1wgZxiUUX/VSpVkgI5NKieXXJ+XA/Q70z210W6yXUi//Bg4AlErgEJg3N Vjgc2PenLqBxhZIqQ4Liw/jrG1qHs2T6WXgJmOqmjNgHg4icdHrpFSTlL5UziuWsv5dV 2OPP1G+wCSCki3Od+lj7d8aI7zwLiMY/j8Bjemhg6+zx5YIhlyfI+2uIZSqIlgRu5c6T X6HlaTDySKdnDl4eXgSly7Sghij6g/VFXXuWXYo3RDO6jO5I+9YPsbSZVehmr2rM2VsF F+UPlQpcAxK+4EVLSFB1An/IGsHb3cEgUM4COIWLUSOzhfVh9kIRf4Ns4C9rQghgujGu RX2w== X-Gm-Message-State: AOAM5313n7o0WT7/Pi+tj5K3PzjPa6c9F3JmfZgpSFLEjHwP3ZNmTOoc PmHF/JgmzwXQ77LRKvRVBUnSOhFbXILNBm9mKII= X-Google-Smtp-Source: ABdhPJyQZS1Xr8gnb53yM7SiKuoBHfAVWDm0sXFCpKkYsNKzAITxSaP4lvBa4TN4o5V50bKrrF/ZMaRIevhXPrGZPZs= X-Received: by 2002:aca:4254:: with SMTP id p81mr454025oia.68.1589910847813; Tue, 19 May 2020 10:54:07 -0700 (PDT) MIME-Version: 1.0 References: <20200501164543.24423-1-james.morse@arm.com> <20200501164543.24423-2-james.morse@arm.com> <49686237.p6yG9EJavU@kreacher> <20200518125828.e4e3973c743556e976c5ee65@linux-foundation.org> <20200519031511.GA31023@hori.linux.bs1.fc.nec.co.jp> In-Reply-To: <20200519031511.GA31023@hori.linux.bs1.fc.nec.co.jp> From: "Rafael J. Wysocki" Date: Tue, 19 May 2020 19:53:56 +0200 Message-ID: Subject: Re: [PATCH v2 1/3] mm/memory-failure: Add memory_failure_queue_kick() To: =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= , James Morse Cc: Andrew Morton , "Rafael J. Wysocki" , "linux-mm@kvack.org" , "linux-acpi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Naoya Horiguchi , Len Brown , Tony Luck , Borislav Petkov , Catalin Marinas , Will Deacon , Mark Rutland , Tyler Baicar , Xie XiuQi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 19, 2020 at 5:15 AM HORIGUCHI NAOYA(=E5=A0=80=E5=8F=A3=E3=80=80= =E7=9B=B4=E4=B9=9F) wrote: > > On Mon, May 18, 2020 at 12:58:28PM -0700, Andrew Morton wrote: > > On Mon, 18 May 2020 14:45:05 +0200 "Rafael J. Wysocki" wrote: > > > > > On Friday, May 1, 2020 6:45:41 PM CEST James Morse wrote: > > > > The GHES code calls memory_failure_queue() from IRQ context to sche= dule > > > > work on the current CPU so that memory_failure() can sleep. > > > > > > > > For synchronous memory errors the arch code needs to know any signa= ls > > > > that memory_failure() will trigger are pending before it returns to > > > > user-space, possibly when exiting from the IRQ. > > > > > > > > Add a helper to kick the memory failure queue, to ensure the schedu= led > > > > work has happened. This has to be called from process context, so m= ay > > > > have been migrated from the original cpu. Pass the cpu the work was > > > > queued on. > > > > > > > > Change memory_failure_work_func() to permit being called on the 'wr= ong' > > > > cpu. > > > > > > > > --- a/include/linux/mm.h > > > > +++ b/include/linux/mm.h > > > > @@ -3012,6 +3012,7 @@ enum mf_flags { > > > > }; > > > > extern int memory_failure(unsigned long pfn, int flags); > > > > extern void memory_failure_queue(unsigned long pfn, int flags); > > > > +extern void memory_failure_queue_kick(int cpu); > > > > extern int unpoison_memory(unsigned long pfn); > > > > extern int get_hwpoison_page(struct page *page); > > > > #define put_hwpoison_page(page) put_page(page) > > > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > > > > index a96364be8ab4..c4afb407bf0f 100644 > > > > --- a/mm/memory-failure.c > > > > +++ b/mm/memory-failure.c > > > > @@ -1493,7 +1493,7 @@ static void memory_failure_work_func(struct w= ork_struct *work) > > > > unsigned long proc_flags; > > > > int gotten; > > > > > > > > - mf_cpu =3D this_cpu_ptr(&memory_failure_cpu); > > > > + mf_cpu =3D container_of(work, struct memory_failure_cpu, work); > > > > for (;;) { > > > > spin_lock_irqsave(&mf_cpu->lock, proc_flags); > > > > gotten =3D kfifo_get(&mf_cpu->fifo, &entry); > > > > @@ -1507,6 +1507,19 @@ static void memory_failure_work_func(struct = work_struct *work) > > > > } > > > > } > > > > > > > > +/* > > > > + * Process memory_failure work queued on the specified CPU. > > > > + * Used to avoid return-to-userspace racing with the memory_failur= e workqueue. > > > > + */ > > > > +void memory_failure_queue_kick(int cpu) > > > > +{ > > > > + struct memory_failure_cpu *mf_cpu; > > > > + > > > > + mf_cpu =3D &per_cpu(memory_failure_cpu, cpu); > > > > + cancel_work_sync(&mf_cpu->work); > > > > + memory_failure_work_func(&mf_cpu->work); > > > > +} > > > > + > > > > static int __init memory_failure_init(void) > > > > { > > > > struct memory_failure_cpu *mf_cpu; > > > > > > > > > > I could apply this provided an ACK from the mm people. > > > > > > > Naoya Horiguchi is the memory-failure.c person. A review would be > > appreciated please? > > > > I'm struggling with it a bit. memory_failure_queue_kick() should be > > called on the cpu which is identified by arg `cpu', yes? > > memory_failure_work_func() appears to assume this. > > > > If that's right then a) why bother passing in the `cpu' arg? and b) > > what keeps this thread pinned to that CPU? cancel_work_sync() can > > schedule. > > If I read correctly, memory_failure work is queue on the CPU on which the > user process ran when it touched the corrupted memory, and the process ca= n > be scheduled on another CPU when the kernel returned back to userspace af= ter > handling the GHES event. So we need to remember where the memory_failure > event is queued to flush proper work queue. So I feel that this properly > implements it. > > Considering the effect to the other caller, currently memory_failure_queu= e() > has 2 callers, ghes_handle_memory_failure() and cec_add_elem(). The forme= r > is what we try to change now. And the latter is to execute soft offline > (which is related to corrected non-fatal errors), so that's not affected = by > the reported issue. So I don't think that this change breaks the other > caller. > > So I'm fine with the suggested change. > > Acked-by: Naoya Horiguchi OK, thanks! So because patch [1/3] has been ACKed already, I'm applying this series as 5.8 material. Thanks everyone! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57EB8C433E0 for ; Tue, 19 May 2020 17:54:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3491F207D4 for ; Tue, 19 May 2020 17:54:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cDWIGBsk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3491F207D4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TlmpzA5Lmcd8pfkejLT6u0tNNZ1aShUp4ibvXuYeCKk=; b=cDWIGBskmd9lNg ac9PTwN8RFxurRjv00mLW+gBi+nBJ0+2Z826aBbbMv2SDKuV4Xmq9eVShFqne/rZsn+/+avSmt/AX ghfJBmVBpI66mXxiDUtJz1upV0aYF0VeoyzWmjaunWoxvgkQnQYgpZyV8o3yOxzgMhsdFhOuAh7eI tMKpJxlvIsSG/OdVbzB7OoaxradhW5TDCSjT2hplenAjM6ZDGYffdPsI6PpGqaqe91UYorWB5drOO aOCwXiLlSc44fVywWIwQar15+s2Db2Qe2zohOYsoMQOg91TvLwVaN48Uivi5JlBP5AeWIJeE1jPnW q+gy3M+sK93DndbB+zJQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jb6RP-0007K5-Qx; Tue, 19 May 2020 17:54:11 +0000 Received: from mail-oi1-f196.google.com ([209.85.167.196]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jb6RN-0007Il-Al for linux-arm-kernel@lists.infradead.org; Tue, 19 May 2020 17:54:10 +0000 Received: by mail-oi1-f196.google.com with SMTP id i22so494323oik.10 for ; Tue, 19 May 2020 10:54:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=oLkdDiI5HFWL8C7O6W36h9N6UH3412FNuY/4J1ySuKI=; b=rT2AY7nay9pp7qUI6pbynX/5Ck665DZkSK5yAFmiZxx462SXyZ2I4mQcnaVjK1znef jPLbJbIL6TOFgJmN/B4RqwN9BaXhXOOecyPo8A7v2GvRUpHiI5Hm1+pCkJv8vmMJVfI+ MCSsD/YaCtBlyOr51JIJmB1g6LRpxPDbLVgZhQylY3cSzs50t9L+NTi0NEIPHmlPtK2v +Wz1XCGIWdDTEmLRBaX7OVhwBkxXkDjW7C4IzdGHS9c+YypoSPX0w3a9mXj1y8lwN8rr cRK1CKKDCVu/uLUXv7ymL5aBop/uNJKT/SosBtBhBBIRQRaD8jzR0ix9a2WEK0DLiQXf jggA== X-Gm-Message-State: AOAM531GDgmrTwJQjUHQ0D0t9y+l2qyExhGmTv4ZO+NYesT1nMLJx2Zi ap/W72yqRf9BnmE6CmxLk0iyrtB4hQE6lOeN/AE= X-Google-Smtp-Source: ABdhPJyQZS1Xr8gnb53yM7SiKuoBHfAVWDm0sXFCpKkYsNKzAITxSaP4lvBa4TN4o5V50bKrrF/ZMaRIevhXPrGZPZs= X-Received: by 2002:aca:4254:: with SMTP id p81mr454025oia.68.1589910847813; Tue, 19 May 2020 10:54:07 -0700 (PDT) MIME-Version: 1.0 References: <20200501164543.24423-1-james.morse@arm.com> <20200501164543.24423-2-james.morse@arm.com> <49686237.p6yG9EJavU@kreacher> <20200518125828.e4e3973c743556e976c5ee65@linux-foundation.org> <20200519031511.GA31023@hori.linux.bs1.fc.nec.co.jp> In-Reply-To: <20200519031511.GA31023@hori.linux.bs1.fc.nec.co.jp> From: "Rafael J. Wysocki" Date: Tue, 19 May 2020 19:53:56 +0200 Message-ID: Subject: Re: [PATCH v2 1/3] mm/memory-failure: Add memory_failure_queue_kick() To: =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= , James Morse X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200519_105409_374760_1020477A X-CRM114-Status: GOOD ( 27.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Tony Luck , "linux-acpi@vger.kernel.org" , Catalin Marinas , Xie XiuQi , "Rafael J. Wysocki" , "linux-mm@kvack.org" , Tyler Baicar , Borislav Petkov , Andrew Morton , Will Deacon , Naoya Horiguchi , "linux-arm-kernel@lists.infradead.org" , Len Brown Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBNYXkgMTksIDIwMjAgYXQgNToxNSBBTSBIT1JJR1VDSEkgTkFPWUEo5aCA5Y+j44CA 55u05LmfKQo8bmFveWEuaG9yaWd1Y2hpQG5lYy5jb20+IHdyb3RlOgo+Cj4gT24gTW9uLCBNYXkg MTgsIDIwMjAgYXQgMTI6NTg6MjhQTSAtMDcwMCwgQW5kcmV3IE1vcnRvbiB3cm90ZToKPiA+IE9u IE1vbiwgMTggTWF5IDIwMjAgMTQ6NDU6MDUgKzAyMDAgIlJhZmFlbCBKLiBXeXNvY2tpIiA8cmp3 QHJqd3lzb2NraS5uZXQ+IHdyb3RlOgo+ID4KPiA+ID4gT24gRnJpZGF5LCBNYXkgMSwgMjAyMCA2 OjQ1OjQxIFBNIENFU1QgSmFtZXMgTW9yc2Ugd3JvdGU6Cj4gPiA+ID4gVGhlIEdIRVMgY29kZSBj YWxscyBtZW1vcnlfZmFpbHVyZV9xdWV1ZSgpIGZyb20gSVJRIGNvbnRleHQgdG8gc2NoZWR1bGUK PiA+ID4gPiB3b3JrIG9uIHRoZSBjdXJyZW50IENQVSBzbyB0aGF0IG1lbW9yeV9mYWlsdXJlKCkg Y2FuIHNsZWVwLgo+ID4gPiA+Cj4gPiA+ID4gRm9yIHN5bmNocm9ub3VzIG1lbW9yeSBlcnJvcnMg dGhlIGFyY2ggY29kZSBuZWVkcyB0byBrbm93IGFueSBzaWduYWxzCj4gPiA+ID4gdGhhdCBtZW1v cnlfZmFpbHVyZSgpIHdpbGwgdHJpZ2dlciBhcmUgcGVuZGluZyBiZWZvcmUgaXQgcmV0dXJucyB0 bwo+ID4gPiA+IHVzZXItc3BhY2UsIHBvc3NpYmx5IHdoZW4gZXhpdGluZyBmcm9tIHRoZSBJUlEu Cj4gPiA+ID4KPiA+ID4gPiBBZGQgYSBoZWxwZXIgdG8ga2ljayB0aGUgbWVtb3J5IGZhaWx1cmUg cXVldWUsIHRvIGVuc3VyZSB0aGUgc2NoZWR1bGVkCj4gPiA+ID4gd29yayBoYXMgaGFwcGVuZWQu IFRoaXMgaGFzIHRvIGJlIGNhbGxlZCBmcm9tIHByb2Nlc3MgY29udGV4dCwgc28gbWF5Cj4gPiA+ ID4gaGF2ZSBiZWVuIG1pZ3JhdGVkIGZyb20gdGhlIG9yaWdpbmFsIGNwdS4gUGFzcyB0aGUgY3B1 IHRoZSB3b3JrIHdhcwo+ID4gPiA+IHF1ZXVlZCBvbi4KPiA+ID4gPgo+ID4gPiA+IENoYW5nZSBt ZW1vcnlfZmFpbHVyZV93b3JrX2Z1bmMoKSB0byBwZXJtaXQgYmVpbmcgY2FsbGVkIG9uIHRoZSAn d3JvbmcnCj4gPiA+ID4gY3B1Lgo+ID4gPiA+Cj4gPiA+ID4gLS0tIGEvaW5jbHVkZS9saW51eC9t bS5oCj4gPiA+ID4gKysrIGIvaW5jbHVkZS9saW51eC9tbS5oCj4gPiA+ID4gQEAgLTMwMTIsNiAr MzAxMiw3IEBAIGVudW0gbWZfZmxhZ3Mgewo+ID4gPiA+ICB9Owo+ID4gPiA+ICBleHRlcm4gaW50 IG1lbW9yeV9mYWlsdXJlKHVuc2lnbmVkIGxvbmcgcGZuLCBpbnQgZmxhZ3MpOwo+ID4gPiA+ICBl eHRlcm4gdm9pZCBtZW1vcnlfZmFpbHVyZV9xdWV1ZSh1bnNpZ25lZCBsb25nIHBmbiwgaW50IGZs YWdzKTsKPiA+ID4gPiArZXh0ZXJuIHZvaWQgbWVtb3J5X2ZhaWx1cmVfcXVldWVfa2ljayhpbnQg Y3B1KTsKPiA+ID4gPiAgZXh0ZXJuIGludCB1bnBvaXNvbl9tZW1vcnkodW5zaWduZWQgbG9uZyBw Zm4pOwo+ID4gPiA+ICBleHRlcm4gaW50IGdldF9od3BvaXNvbl9wYWdlKHN0cnVjdCBwYWdlICpw YWdlKTsKPiA+ID4gPiAgI2RlZmluZSBwdXRfaHdwb2lzb25fcGFnZShwYWdlKSAgcHV0X3BhZ2Uo cGFnZSkKPiA+ID4gPiBkaWZmIC0tZ2l0IGEvbW0vbWVtb3J5LWZhaWx1cmUuYyBiL21tL21lbW9y eS1mYWlsdXJlLmMKPiA+ID4gPiBpbmRleCBhOTYzNjRiZThhYjQuLmM0YWZiNDA3YmYwZiAxMDA2 NDQKPiA+ID4gPiAtLS0gYS9tbS9tZW1vcnktZmFpbHVyZS5jCj4gPiA+ID4gKysrIGIvbW0vbWVt b3J5LWZhaWx1cmUuYwo+ID4gPiA+IEBAIC0xNDkzLDcgKzE0OTMsNyBAQCBzdGF0aWMgdm9pZCBt ZW1vcnlfZmFpbHVyZV93b3JrX2Z1bmMoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQo+ID4gPiA+ ICAgdW5zaWduZWQgbG9uZyBwcm9jX2ZsYWdzOwo+ID4gPiA+ICAgaW50IGdvdHRlbjsKPiA+ID4g Pgo+ID4gPiA+IC0gbWZfY3B1ID0gdGhpc19jcHVfcHRyKCZtZW1vcnlfZmFpbHVyZV9jcHUpOwo+ ID4gPiA+ICsgbWZfY3B1ID0gY29udGFpbmVyX29mKHdvcmssIHN0cnVjdCBtZW1vcnlfZmFpbHVy ZV9jcHUsIHdvcmspOwo+ID4gPiA+ICAgZm9yICg7Oykgewo+ID4gPiA+ICAgICAgICAgICBzcGlu X2xvY2tfaXJxc2F2ZSgmbWZfY3B1LT5sb2NrLCBwcm9jX2ZsYWdzKTsKPiA+ID4gPiAgICAgICAg ICAgZ290dGVuID0ga2ZpZm9fZ2V0KCZtZl9jcHUtPmZpZm8sICZlbnRyeSk7Cj4gPiA+ID4gQEAg LTE1MDcsNiArMTUwNywxOSBAQCBzdGF0aWMgdm9pZCBtZW1vcnlfZmFpbHVyZV93b3JrX2Z1bmMo c3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQo+ID4gPiA+ICAgfQo+ID4gPiA+ICB9Cj4gPiA+ID4K PiA+ID4gPiArLyoKPiA+ID4gPiArICogUHJvY2VzcyBtZW1vcnlfZmFpbHVyZSB3b3JrIHF1ZXVl ZCBvbiB0aGUgc3BlY2lmaWVkIENQVS4KPiA+ID4gPiArICogVXNlZCB0byBhdm9pZCByZXR1cm4t dG8tdXNlcnNwYWNlIHJhY2luZyB3aXRoIHRoZSBtZW1vcnlfZmFpbHVyZSB3b3JrcXVldWUuCj4g PiA+ID4gKyAqLwo+ID4gPiA+ICt2b2lkIG1lbW9yeV9mYWlsdXJlX3F1ZXVlX2tpY2soaW50IGNw dSkKPiA+ID4gPiArewo+ID4gPiA+ICsgc3RydWN0IG1lbW9yeV9mYWlsdXJlX2NwdSAqbWZfY3B1 Owo+ID4gPiA+ICsKPiA+ID4gPiArIG1mX2NwdSA9ICZwZXJfY3B1KG1lbW9yeV9mYWlsdXJlX2Nw dSwgY3B1KTsKPiA+ID4gPiArIGNhbmNlbF93b3JrX3N5bmMoJm1mX2NwdS0+d29yayk7Cj4gPiA+ ID4gKyBtZW1vcnlfZmFpbHVyZV93b3JrX2Z1bmMoJm1mX2NwdS0+d29yayk7Cj4gPiA+ID4gK30K PiA+ID4gPiArCj4gPiA+ID4gIHN0YXRpYyBpbnQgX19pbml0IG1lbW9yeV9mYWlsdXJlX2luaXQo dm9pZCkKPiA+ID4gPiAgewo+ID4gPiA+ICAgc3RydWN0IG1lbW9yeV9mYWlsdXJlX2NwdSAqbWZf Y3B1Owo+ID4gPiA+Cj4gPiA+Cj4gPiA+IEkgY291bGQgYXBwbHkgdGhpcyBwcm92aWRlZCBhbiBB Q0sgZnJvbSB0aGUgbW0gcGVvcGxlLgo+ID4gPgo+ID4KPiA+IE5hb3lhIEhvcmlndWNoaSBpcyB0 aGUgbWVtb3J5LWZhaWx1cmUuYyBwZXJzb24uICBBIHJldmlldyB3b3VsZCBiZQo+ID4gYXBwcmVj aWF0ZWQgcGxlYXNlPwo+ID4KPiA+IEknbSBzdHJ1Z2dsaW5nIHdpdGggaXQgYSBiaXQuICBtZW1v cnlfZmFpbHVyZV9xdWV1ZV9raWNrKCkgc2hvdWxkIGJlCj4gPiBjYWxsZWQgb24gdGhlIGNwdSB3 aGljaCBpcyBpZGVudGlmaWVkIGJ5IGFyZyBgY3B1JywgeWVzPwo+ID4gbWVtb3J5X2ZhaWx1cmVf d29ya19mdW5jKCkgYXBwZWFycyB0byBhc3N1bWUgdGhpcy4KPiA+Cj4gPiBJZiB0aGF0J3Mgcmln aHQgdGhlbiBhKSB3aHkgYm90aGVyIHBhc3NpbmcgaW4gdGhlIGBjcHUnIGFyZz8gIGFuZCBiKQo+ ID4gd2hhdCBrZWVwcyB0aGlzIHRocmVhZCBwaW5uZWQgdG8gdGhhdCBDUFU/ICBjYW5jZWxfd29y a19zeW5jKCkgY2FuCj4gPiBzY2hlZHVsZS4KPgo+IElmIEkgcmVhZCBjb3JyZWN0bHksIG1lbW9y eV9mYWlsdXJlIHdvcmsgaXMgcXVldWUgb24gdGhlIENQVSBvbiB3aGljaCB0aGUKPiB1c2VyIHBy b2Nlc3MgcmFuIHdoZW4gaXQgdG91Y2hlZCB0aGUgY29ycnVwdGVkIG1lbW9yeSwgYW5kIHRoZSBw cm9jZXNzIGNhbgo+IGJlIHNjaGVkdWxlZCBvbiBhbm90aGVyIENQVSB3aGVuIHRoZSBrZXJuZWwg cmV0dXJuZWQgYmFjayB0byB1c2Vyc3BhY2UgYWZ0ZXIKPiBoYW5kbGluZyB0aGUgR0hFUyBldmVu dC4gIFNvIHdlIG5lZWQgdG8gcmVtZW1iZXIgd2hlcmUgdGhlIG1lbW9yeV9mYWlsdXJlCj4gZXZl bnQgaXMgcXVldWVkIHRvIGZsdXNoIHByb3BlciB3b3JrIHF1ZXVlLiAgU28gSSBmZWVsIHRoYXQg dGhpcyBwcm9wZXJseQo+IGltcGxlbWVudHMgaXQuCj4KPiBDb25zaWRlcmluZyB0aGUgZWZmZWN0 IHRvIHRoZSBvdGhlciBjYWxsZXIsIGN1cnJlbnRseSBtZW1vcnlfZmFpbHVyZV9xdWV1ZSgpCj4g aGFzIDIgY2FsbGVycywgZ2hlc19oYW5kbGVfbWVtb3J5X2ZhaWx1cmUoKSBhbmQgY2VjX2FkZF9l bGVtKCkuIFRoZSBmb3JtZXIKPiBpcyB3aGF0IHdlIHRyeSB0byBjaGFuZ2Ugbm93LiAgQW5kIHRo ZSBsYXR0ZXIgaXMgdG8gZXhlY3V0ZSBzb2Z0IG9mZmxpbmUKPiAod2hpY2ggaXMgcmVsYXRlZCB0 byBjb3JyZWN0ZWQgbm9uLWZhdGFsIGVycm9ycyksIHNvIHRoYXQncyBub3QgYWZmZWN0ZWQgYnkK PiB0aGUgcmVwb3J0ZWQgaXNzdWUuICBTbyBJIGRvbid0IHRoaW5rIHRoYXQgdGhpcyBjaGFuZ2Ug YnJlYWtzIHRoZSBvdGhlcgo+IGNhbGxlci4KPgo+IFNvIEknbSBmaW5lIHdpdGggdGhlIHN1Z2dl c3RlZCBjaGFuZ2UuCj4KPiBBY2tlZC1ieTogTmFveWEgSG9yaWd1Y2hpIDxuYW95YS5ob3JpZ3Vj aGlAbmVjLmNvbT4KCk9LLCB0aGFua3MhCgpTbyBiZWNhdXNlIHBhdGNoIFsxLzNdIGhhcyBiZWVu IEFDS2VkIGFscmVhZHksIEknbSBhcHBseWluZyB0aGlzCnNlcmllcyBhcyA1LjggbWF0ZXJpYWwu CgpUaGFua3MgZXZlcnlvbmUhCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==