From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH 1/4] ACPI/PPTT: Add function to return ACPI 6.3 Identical tokens Date: Thu, 28 Mar 2019 11:04:14 +0100 Message-ID: References: <20190326223938.5365-1-jeremy.linton@arm.com> <20190326223938.5365-2-jeremy.linton@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20190326223938.5365-2-jeremy.linton@arm.com> Sender: linux-kernel-owner@vger.kernel.org To: Jeremy Linton Cc: Linux ARM , ACPI Devel Maling List , Linux Kernel Mailing List , Catalin Marinas , Will Deacon , "Rafael J. Wysocki" , Len Brown , Mark Rutland , Sudeep Holla , James Morse , Lorenzo Pieralisi , Linuxarm List-Id: linux-acpi@vger.kernel.org On Tue, Mar 26, 2019 at 11:40 PM Jeremy Linton wrote: > > ACPI 6.3 adds a flag to indicate that child nodes are all > identical cores. This is useful to authoritatively determine > if a set of (possibly offline) cores are identical or not. > > Since the flag doesn't give us a unique id we can generate > one and use it to create bitmaps of sibling nodes, or simply > in a loop to determine if a subset of cores are identical. > > Signed-off-by: Jeremy Linton > --- > drivers/acpi/pptt.c | 26 ++++++++++++++++++++++++++ > include/linux/acpi.h | 5 +++++ > 2 files changed, 31 insertions(+) > > diff --git a/drivers/acpi/pptt.c b/drivers/acpi/pptt.c > index 065c4fc245d1..472c95ec816b 100644 > --- a/drivers/acpi/pptt.c > +++ b/drivers/acpi/pptt.c > @@ -660,3 +660,29 @@ int find_acpi_cpu_topology_package(unsigned int cpu) > return find_acpi_cpu_topology_tag(cpu, PPTT_ABORT_PACKAGE, > ACPI_PPTT_PHYSICAL_PACKAGE); > } > + > +/** > + * find_acpi_cpu_topology_hetero_id() - Determine a unique implementation Maybe "Get a core architecture tag"? > + * @cpu: Kernel logical cpu number s/logical cpu/logical CPU/ please. > + * > + * Determine a unique heterogeneous ID for the given CPU. CPUs with the same > + * implementation should have matching IDs. Since this is a tree we can only > + * detect implementations where the heterogeneous flag is the parent to all > + * matching cores. AKA if a two socket machine has two different core types > + * in each socket this will end up being represented as four unique core types > + * rather than two. I find it quite difficult to parse that comment, honestly. AFAICS, the function returns a tag that will be the same for all cores with the same architecture in one package. That is, if the package is heterogeneous and there are two types of cores in it, there will be two different tags. Is this correct? > + * > + * The returned ID can be used to group peers with identical implementation. > + * > + * The search terminates when a level is found with the identical implementation > + * flag set or we reach a root node. > + * > + * Return: -ENOENT if the PPTT doesn't exist, or the cpu cannot be found. > + * Otherwise returns a value which represents a group of identical cores > + * similar to this cpu. > + */ > +int find_acpi_cpu_topology_hetero_id(unsigned int cpu) > +{ > + return find_acpi_cpu_topology_tag(cpu, PPTT_ABORT_PACKAGE, > + ACPI_PPTT_ACPI_IDENTICAL); > +} > diff --git a/include/linux/acpi.h b/include/linux/acpi.h > index d5dcebd7aad3..1444fb042898 100644 > --- a/include/linux/acpi.h > +++ b/include/linux/acpi.h > @@ -1309,6 +1309,7 @@ static inline int lpit_read_residency_count_address(u64 *address) > #ifdef CONFIG_ACPI_PPTT > int find_acpi_cpu_topology(unsigned int cpu, int level); > int find_acpi_cpu_topology_package(unsigned int cpu); > +int find_acpi_cpu_topology_hetero_id(unsigned int cpu); > int find_acpi_cpu_cache_topology(unsigned int cpu, int level); > #else > static inline int find_acpi_cpu_topology(unsigned int cpu, int level) > @@ -1319,6 +1320,10 @@ static inline int find_acpi_cpu_topology_package(unsigned int cpu) > { > return -EINVAL; > } > +static int find_acpi_cpu_topology_hetero_id(unsigned int cpu) > +{ > + return -EINVAL; > +} > static inline int find_acpi_cpu_cache_topology(unsigned int cpu, int level) > { > return -EINVAL; > -- > 2.20.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8011CC43381 for ; Thu, 28 Mar 2019 10:04:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E5D42173C for ; Thu, 28 Mar 2019 10:04:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FPpiyppd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E5D42173C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/1tKEpO7t+cmVLerOsLR4KYi+hETpWn20N1oBXscnVs=; b=FPpiyppdRTjald 3b6vmLPZb1GHWEQIq8bz0kDkgtQgIwjxhzwSIndlj3r+JwpW00IOlRJgqK3gCz/MVxvvvGs97+C0a dwu8HIPtrnZA/TsPhT5RnAiA8bMQd9jvzRYck6ZMtnZviX71laI92wgbaaN87/qFVslZGnPF8rfq0 1A8cRQPBsAakZyCmjbbhkqGtw6N4H4zCET1PBG5IZe5IxwaT0BSHSqipaVXvCMQ3nhKoAY/VyxYcM qAargJ/2xY0TEhTYe7h3TexFVzdCqPylBYYYts23PTL3aWcj4NzPmgrp52ZTGGWpVOyprJ7A6GCZW YQq2FRDoDthC3B//Yw6g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9Rth-0007l8-Dk; Thu, 28 Mar 2019 10:04:33 +0000 Received: from mail-ot1-f68.google.com ([209.85.210.68]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9Rte-0007ez-4m for linux-arm-kernel@lists.infradead.org; Thu, 28 Mar 2019 10:04:31 +0000 Received: by mail-ot1-f68.google.com with SMTP id o74so17756789ota.3 for ; Thu, 28 Mar 2019 03:04:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xtmdu5XLPrI43gJK8nagjJ6gJWySA3zZa00qKeEf1cg=; b=R6NUvByYLh2F8CYK2Lp4OSmtER0HIzgEvCxGEViCxRJFMfY9XfOrouwiDWbZh6kMO/ x5m+tr+p2X3RJKhTHJzifO04Q/dJXHNJyW0nH/AlYEZR9F1dtv+3jaTAfMYSqrHibE+m WcBst1hnwkOxKV1G0qi56XegI2vQJhBMovFVqPgebohdy/7KfVqaRfKm20AXVYn1kj+I H47YuWORA7nmWepg08q0OdlGI0f9PjU9eaY2tvUUJBFBjOIjfNDnPH1n0RhaGXPjksoq bP+I5oNwzEodbgqhGsBxSbs0YDPNEuewiQRv5izphe9SLMqR5DMSvvpR1x2sTysxPkil RDKw== X-Gm-Message-State: APjAAAVU0xL+LdadOh8iBHdPItZs9NIYTqTt5Fu9JWvA5FVU5x9FhgAY +itiiVBz2iCqA74bJdZV95naHmGBRwiWi2Ii49/G5A== X-Google-Smtp-Source: APXvYqzlJVh1s+XobKp09nau8PesjtF/07r/DzPbrxPVBfpYZV15X+lhIcrKNW+O4swMRYaigkdN8ASQm+O+Bm25WiI= X-Received: by 2002:a9d:36a:: with SMTP id 97mr3722387otv.124.1553767465525; Thu, 28 Mar 2019 03:04:25 -0700 (PDT) MIME-Version: 1.0 References: <20190326223938.5365-1-jeremy.linton@arm.com> <20190326223938.5365-2-jeremy.linton@arm.com> In-Reply-To: <20190326223938.5365-2-jeremy.linton@arm.com> From: "Rafael J. Wysocki" Date: Thu, 28 Mar 2019 11:04:14 +0100 Message-ID: Subject: Re: [PATCH 1/4] ACPI/PPTT: Add function to return ACPI 6.3 Identical tokens To: Jeremy Linton X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190328_030430_183609_EA2CE3D0 X-CRM114-Status: GOOD ( 22.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Lorenzo Pieralisi , Will Deacon , Sudeep Holla , "Rafael J. Wysocki" , Linux Kernel Mailing List , Linuxarm , ACPI Devel Maling List , James Morse , Catalin Marinas , Linux ARM , Len Brown Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 26, 2019 at 11:40 PM Jeremy Linton wrote: > > ACPI 6.3 adds a flag to indicate that child nodes are all > identical cores. This is useful to authoritatively determine > if a set of (possibly offline) cores are identical or not. > > Since the flag doesn't give us a unique id we can generate > one and use it to create bitmaps of sibling nodes, or simply > in a loop to determine if a subset of cores are identical. > > Signed-off-by: Jeremy Linton > --- > drivers/acpi/pptt.c | 26 ++++++++++++++++++++++++++ > include/linux/acpi.h | 5 +++++ > 2 files changed, 31 insertions(+) > > diff --git a/drivers/acpi/pptt.c b/drivers/acpi/pptt.c > index 065c4fc245d1..472c95ec816b 100644 > --- a/drivers/acpi/pptt.c > +++ b/drivers/acpi/pptt.c > @@ -660,3 +660,29 @@ int find_acpi_cpu_topology_package(unsigned int cpu) > return find_acpi_cpu_topology_tag(cpu, PPTT_ABORT_PACKAGE, > ACPI_PPTT_PHYSICAL_PACKAGE); > } > + > +/** > + * find_acpi_cpu_topology_hetero_id() - Determine a unique implementation Maybe "Get a core architecture tag"? > + * @cpu: Kernel logical cpu number s/logical cpu/logical CPU/ please. > + * > + * Determine a unique heterogeneous ID for the given CPU. CPUs with the same > + * implementation should have matching IDs. Since this is a tree we can only > + * detect implementations where the heterogeneous flag is the parent to all > + * matching cores. AKA if a two socket machine has two different core types > + * in each socket this will end up being represented as four unique core types > + * rather than two. I find it quite difficult to parse that comment, honestly. AFAICS, the function returns a tag that will be the same for all cores with the same architecture in one package. That is, if the package is heterogeneous and there are two types of cores in it, there will be two different tags. Is this correct? > + * > + * The returned ID can be used to group peers with identical implementation. > + * > + * The search terminates when a level is found with the identical implementation > + * flag set or we reach a root node. > + * > + * Return: -ENOENT if the PPTT doesn't exist, or the cpu cannot be found. > + * Otherwise returns a value which represents a group of identical cores > + * similar to this cpu. > + */ > +int find_acpi_cpu_topology_hetero_id(unsigned int cpu) > +{ > + return find_acpi_cpu_topology_tag(cpu, PPTT_ABORT_PACKAGE, > + ACPI_PPTT_ACPI_IDENTICAL); > +} > diff --git a/include/linux/acpi.h b/include/linux/acpi.h > index d5dcebd7aad3..1444fb042898 100644 > --- a/include/linux/acpi.h > +++ b/include/linux/acpi.h > @@ -1309,6 +1309,7 @@ static inline int lpit_read_residency_count_address(u64 *address) > #ifdef CONFIG_ACPI_PPTT > int find_acpi_cpu_topology(unsigned int cpu, int level); > int find_acpi_cpu_topology_package(unsigned int cpu); > +int find_acpi_cpu_topology_hetero_id(unsigned int cpu); > int find_acpi_cpu_cache_topology(unsigned int cpu, int level); > #else > static inline int find_acpi_cpu_topology(unsigned int cpu, int level) > @@ -1319,6 +1320,10 @@ static inline int find_acpi_cpu_topology_package(unsigned int cpu) > { > return -EINVAL; > } > +static int find_acpi_cpu_topology_hetero_id(unsigned int cpu) > +{ > + return -EINVAL; > +} > static inline int find_acpi_cpu_cache_topology(unsigned int cpu, int level) > { > return -EINVAL; > -- > 2.20.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel