From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C14A0C433F5 for ; Tue, 22 Feb 2022 12:49:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229893AbiBVMuP (ORCPT ); Tue, 22 Feb 2022 07:50:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229524AbiBVMuO (ORCPT ); Tue, 22 Feb 2022 07:50:14 -0500 Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADC1F128658 for ; Tue, 22 Feb 2022 04:49:49 -0800 (PST) Received: by mail-yb1-f181.google.com with SMTP id y189so19232864ybe.4 for ; Tue, 22 Feb 2022 04:49:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wIovHm0TBH/skoMTuPHUa2kU5sd+QmaGYcINmbWWwuU=; b=4U1rVih9NgAvpyltTSiw7DfYZCTqe8gvEhXbNnar7XH7gy+QEE+7MXEVQ1XM4M7U6Z CiBfWcDfLGx9kROZbFXMz7Ygix8JZJJ76JqGsnKxMJFW1JOBj4qTl5IX/s/UO8XNN3m+ CiMFSUbnSG2+rBUCxQm3ETMQyOW6/ACn86tuvjF0Cyb6HLmn8iP1P0ZuD1+x22Qfoy4/ lpjss6ZcLRf38n91I4NAI/0LHZfgoHu+jSP21Lh+bRWhGkzr7dYFjLyLLMG/nFJWhu2E SmoGPtiPGKdxGUdd3fEerkuI7ytoroO8iGrwJP6mWczK07eGzaGDyMNLGPzx02v/LIUq 8g7A== X-Gm-Message-State: AOAM530vEuZeUrOFRwnYkLm9jsV0m0oRA9nXD+GsHdb5KEst+HPh05fd gByLitRLOJG+S0yl9FyAky9IJEbi+Xj4d5MvVolDMjuuRbU= X-Google-Smtp-Source: ABdhPJz2Gj0kb/t6aRjHUaCjQJX9I0uCYMbjS14UXRSsr51a4kW6tPSyibVJi9zCMXUuZ0u3/QevaaFWhiaFXxMQCP8= X-Received: by 2002:a25:bbc1:0:b0:610:b4ce:31db with SMTP id c1-20020a25bbc1000000b00610b4ce31dbmr22220020ybk.482.1645534188986; Tue, 22 Feb 2022 04:49:48 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: "Rafael J. Wysocki" Date: Tue, 22 Feb 2022 13:49:37 +0100 Message-ID: Subject: Re: Regression in 5.16-rc1 with suspend to idle To: "Limonciello, Mario" Cc: "Rafael J. Wysocki" , Ulf Hansson , "linux-acpi@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Feb 21, 2022 at 9:14 PM Limonciello, Mario wrote: > > [AMD Official Use Only] > > > > > OK > > https://lore.kernel.org/platform-driver-x86/20220221200728.2323469-1-mario.limonciello@amd.com/T/#u The comment in amd_pmc_resume() doesn't match the code, because the QoS request is updated to "don't care" in there. Also, I'd move that update to the end of the function in case what happens in amd_pmc_resume() interferes with idle states. Moreover, since the "no idle states" period covers the entire suspend time now AFAICS, I would use a small int (eg. 3) instead of 0 in the cpu_latency_qos_update_request() call in amd_pmc_verify_czn_rtc() to allow C1 to be entered via cpuidle during that period (which shouldn't really hurt). And the comment would need to be updated accordingly. > > > > > Long term - are you opposed to drivers/acpi/x86/s2idle.c moving to > > drivers/platform/x86/? > > > > It is tied to the code in sleep.c, so I'd rather not move it. > > OK if we're keeping it there, would you be open to a patch exporting a symbol to > let other drivers register another callback after LPS0? It's somewhat similar to what my > test hack did and might be a better long term solution if so. Well, please send the patch and I will tell you if it looks good to me.