From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4343FC25B08 for ; Sat, 20 Aug 2022 11:57:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345875AbiHTL5Z (ORCPT ); Sat, 20 Aug 2022 07:57:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230061AbiHTL5V (ORCPT ); Sat, 20 Aug 2022 07:57:21 -0400 Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9C45248E2; Sat, 20 Aug 2022 04:57:20 -0700 (PDT) Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-333a4a5d495so182359727b3.10; Sat, 20 Aug 2022 04:57:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=eFv+Oj3QaofeetDmZ1hWU31f01S4gXzOn+W40f2bcH8=; b=Jh9VYy5RF6o3w+4t2LygfX4yCtFcAj+toPFoYCAvMWoNJCb340EE6H2jNoUVEER67j Oof6U81HeY5G2lxcydW7TLSZp0DuQxsvl872ON+MxqNCD1MVfR2zqD58U7mGHJJxaRhs dvLX2jNP7jWbeSgqfCwRXeoiV4ypDgLsQP+dzGmnF6zUt21JjPWT8dwKGLhyY9p6kqrm qXCPEgRQJ17hi9oYKJ4jqe1g2DVaULlUy52kwKGAiBam4KFIIL5+5WAFwaikg7F41Ifq JCobYAIBRVa9KCWJADGJjh7YpfvATF+irt6dGz27jdP944/yq4r39b1x1N0U5K16845Z JAjw== X-Gm-Message-State: ACgBeo3V7U5nzltHxIOW19X4yw8aArUvdpQwyvHuc081/fxGuWgZ5GzK 7Ur1LUJkTQBMEkZ0jho3LPtXMbYgmUb8tj7CbHk= X-Google-Smtp-Source: AA6agR6zWHtnabZ6V306XrP13eJqyDVES8EsSaAH+ECiBaAuEnvGN7G48D/WRufhiU2j2MyLI1HC14c/WpW02memvng= X-Received: by 2002:a81:104e:0:b0:336:37f1:9686 with SMTP id 75-20020a81104e000000b0033637f19686mr12206283ywq.149.1660996639914; Sat, 20 Aug 2022 04:57:19 -0700 (PDT) MIME-Version: 1.0 References: <20220812131202.1331238-1-daniel.lezcano@linaro.org> In-Reply-To: From: "Rafael J. Wysocki" Date: Sat, 20 Aug 2022 13:57:09 +0200 Message-ID: Subject: Re: [PATCH] thermal/core: Fix lockdep_assert() warning To: Daniel Lezcano Cc: Marek Szyprowski , "Rafael J. Wysocki" , Krzysztof Kozlowski , "Zhang, Rui" , Linux PM , Linux Kernel Mailing List , Amit Kucheria , Linux Samsung SoC Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 12, 2022 at 3:54 PM Daniel Lezcano wrote: > > On 12/08/2022 15:34, Marek Szyprowski wrote: > > On 12.08.2022 15:12, Daniel Lezcano wrote: > >> The function thermal_zone_device_is_enabled() must be called with the > >> thermal zone lock held. In the resume path, it is called without. > >> > >> As the thermal_zone_device_is_enabled() is also checked in > >> thermal_zone_device_update(), do the check in resume() function is > >> pointless, except for saving an extra initialization which does not > >> hurt if it is done in all the cases. > >> > >> Signed-off-by: Daniel Lezcano > > > > This fixes the warning I've reported. Feel free to add: > > > > Reported-by: Marek Szyprowski > > > > Tested-by: Marek Szyprowski > > Great, thanks for testing Do you want me to apply this for -rc3?