From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH v2 1/2] x86/acpi: add retrieval function for rsdp address Date: Mon, 29 Jan 2018 04:01:45 +0100 Message-ID: References: <20180125143639.9969-1-jgross@suse.com> <20180125143639.9969-2-jgross@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Received: from mail-ot0-f194.google.com ([74.125.82.194]:36235 "EHLO mail-ot0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751464AbeA2DBq (ORCPT ); Sun, 28 Jan 2018 22:01:46 -0500 In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Andy Shevchenko Cc: Juergen Gross , Linux Kernel Mailing List , ACPI Devel Maling List , xen-devel@lists.xenproject.org, Len Brown , "Rafael J. Wysocki" , Ingo Molnar , Boris Ostrovsky , Stable On Fri, Jan 26, 2018 at 7:08 PM, Andy Shevchenko wrote: > On Thu, Jan 25, 2018 at 4:36 PM, Juergen Gross wrote: >> Add a function to get the address of the RSDP table. Per default use a >> __weak annotated function being a nop. > > The problem with weak functions that we can't have more than one > implementation per kernel while we would like to built several code > paths. > > I have stumbled on the similar stuff and realize that. > > Perhaps, one of the solution is to have an additional struct under > x86_init to alternate ACPI related stuff. I'm not sure if that really is a problem in this particular case. Why would you want to use different RSDP retrieval functions for one arch? Thanks, Rafael