From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH 2/3] components: multiple components for a device Date: Wed, 6 Feb 2019 23:57:04 +0100 Message-ID: References: <1548917996-28081-2-git-send-email-ramalingam.c@intel.com> <20190206164551.29400-1-daniel.vetter@ffwll.ch> <20190206164551.29400-2-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190206164551.29400-2-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: "Rafael J . Wysocki" , Intel Graphics Development , Takashi Iwai , DRI Development , Jaroslav Kysela , Greg Kroah-Hartman , Russell King List-Id: dri-devel@lists.freedesktop.org KSBPbiBXZWQsIEZlYiA2LCAyMDE5IGF0IDU6NDYgUE0gRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZl dHRlckBmZndsbC5jaD4gd3JvdGU6Cj4KPiBDb21wb25lbnQgZnJhbWV3b3JrIGlzIGV4dGVuZGVk IHRvIHN1cHBvcnQgbXVsdGlwbGUgY29tcG9uZW50cyBmb3IKPiBhIHN0cnVjdCBkZXZpY2UuIFRo ZXNlIHdpbGwgYmUgbWF0Y2hlZCB3aXRoIGRpZmZlcmVudCBtYXN0ZXJzIGJhc2VkIG9uCj4gaXRz IHN1YiBjb21wb25lbnQgdmFsdWUuCj4KPiBXZSBhcmUgaW50cm9kdWNpbmcgdGhpcywgYXMgSTkx NSBuZWVkcyB0d28gZGlmZmVyZW50IGNvbXBvbmVudHMKPiB3aXRoIGRpZmZlcmVudCBzdWJjb21w b25lbnQgdmFsdWUsIHdoaWNoIHdpbGwgYmUgbWF0Y2hlZCB0byB0d28KPiBkaWZmZXJlbnQgY29t cG9uZW50IG1hc3RlcnMoQXVkaW8gYW5kIEhEQ1ApIGJhc2VkIG9uIHRoZSBzdWJjb21wb25lbnQK PiB2YWx1ZXMuCj4KPiB2MjogQWRkIGRvY3VtZW5hdGlvbi4KPgo+IHYzOiBSZWJhc2Ugb24gdG9w IG9mIHVwZGF0ZWQgZG9jdW1lbmF0aW9uLgo+Cj4gU2lnbmVkLW9mZi1ieTogRGFuaWVsIFZldHRl ciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4gKHYxIGNvZGUpCj4gU2lnbmVkLW9mZi1ieTogUmFt YWxpbmdhbSBDIDxyYW1hbGluZ2FtLmNAaW50ZWwuY29tPiAodjEgY29tbWl0IG1lc3NhZ2UpCj4g Q2M6IFJhbWFsaW5nYW0gQyA8cmFtYWxpbmdhbS5jQGludGVsLmNvbT4KPiBDYzogR3JlZyBLcm9h aC1IYXJ0bWFuIDxncmVna2hAbGludXhmb3VuZGF0aW9uLm9yZz4KPiBDYzogUnVzc2VsbCBLaW5n IDxybWsra2VybmVsQGFybS5saW51eC5vcmcudWs+Cj4gQ2M6IFJhZmFlbCBKLiBXeXNvY2tpIDxy YWZhZWxAa2VybmVsLm9yZz4KPiBDYzogSmFyb3NsYXYgS3lzZWxhIDxwZXJleEBwZXJleC5jej4K PiBDYzogVGFrYXNoaSBJd2FpIDx0aXdhaUBzdXNlLmNvbT4KPiBDYzogUm9kcmlnbyBWaXZpIDxy b2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+IENjOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAbGlu dXguaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0 ZXJAZmZ3bGwuY2g+Cj4gLS0tCj4gIGRyaXZlcnMvYmFzZS9jb21wb25lbnQuYyAgfCAxNjAgKysr KysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0KPiAgaW5jbHVkZS9saW51eC9jb21w b25lbnQuaCB8ICAgOSArKy0KPiAgMiBmaWxlcyBjaGFuZ2VkLCAxMjkgaW5zZXJ0aW9ucygrKSwg NDAgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9iYXNlL2NvbXBvbmVudC5j IGIvZHJpdmVycy9iYXNlL2NvbXBvbmVudC5jCj4gaW5kZXggZjM0ZDRiNzg0NzA5Li42OGNjZDVh MGQ1ZDYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9iYXNlL2NvbXBvbmVudC5jCj4gKysrIGIvZHJp dmVycy9iYXNlL2NvbXBvbmVudC5jCj4gQEAgLTQ3LDYgKzQ3LDcgQEAgc3RydWN0IGNvbXBvbmVu dDsKPiAgc3RydWN0IGNvbXBvbmVudF9tYXRjaF9hcnJheSB7Cj4gICAgICAgICB2b2lkICpkYXRh Owo+ICAgICAgICAgaW50ICgqY29tcGFyZSkoc3RydWN0IGRldmljZSAqLCB2b2lkICopOwo+ICsg ICAgICAgaW50ICgqY29tcGFyZV90eXBlZCkoc3RydWN0IGRldmljZSAqLCBpbnQsIHZvaWQgKik7 Cj4gICAgICAgICB2b2lkICgqcmVsZWFzZSkoc3RydWN0IGRldmljZSAqLCB2b2lkICopOwo+ICAg ICAgICAgc3RydWN0IGNvbXBvbmVudCAqY29tcG9uZW50Owo+ICAgICAgICAgYm9vbCBkdXBsaWNh dGU7Cj4gQEAgLTc0LDYgKzc1LDcgQEAgc3RydWN0IGNvbXBvbmVudCB7Cj4gICAgICAgICBib29s IGJvdW5kOwo+Cj4gICAgICAgICBjb25zdCBzdHJ1Y3QgY29tcG9uZW50X29wcyAqb3BzOwo+ICsg ICAgICAgaW50IHN1YmNvbXBvbmVudDsKPiAgICAgICAgIHN0cnVjdCBkZXZpY2UgKmRldjsKPiAg fTsKPgo+IEBAIC0xNTgsNyArMTYwLDcgQEAgc3RhdGljIHN0cnVjdCBtYXN0ZXIgKl9fbWFzdGVy X2ZpbmQoc3RydWN0IGRldmljZSAqZGV2LAo+ICB9Cj4KPiAgc3RhdGljIHN0cnVjdCBjb21wb25l bnQgKmZpbmRfY29tcG9uZW50KHN0cnVjdCBtYXN0ZXIgKm1hc3RlciwKPiAtICAgICAgIGludCAo KmNvbXBhcmUpKHN0cnVjdCBkZXZpY2UgKiwgdm9pZCAqKSwgdm9pZCAqY29tcGFyZV9kYXRhKQo+ ICsgICAgICAgc3RydWN0IGNvbXBvbmVudF9tYXRjaF9hcnJheSAqbWMpCj4gIHsKPiAgICAgICAg IHN0cnVjdCBjb21wb25lbnQgKmM7Cj4KPiBAQCAtMTY2LDggKzE2OCwxMyBAQCBzdGF0aWMgc3Ry dWN0IGNvbXBvbmVudCAqZmluZF9jb21wb25lbnQoc3RydWN0IG1hc3RlciAqbWFzdGVyLAo+ICAg ICAgICAgICAgICAgICBpZiAoYy0+bWFzdGVyICYmIGMtPm1hc3RlciAhPSBtYXN0ZXIpCj4gICAg ICAgICAgICAgICAgICAgICAgICAgY29udGludWU7Cj4KPiAtICAgICAgICAgICAgICAgaWYgKGNv bXBhcmUoYy0+ZGV2LCBjb21wYXJlX2RhdGEpKQo+ICsgICAgICAgICAgICAgICBpZiAobWMtPmNv bXBhcmVfdHlwZWQpIHsKPiArICAgICAgICAgICAgICAgICAgICAgICBpZiAobWMtPmNvbXBhcmVf dHlwZWQoYy0+ZGV2LCBjLT5zdWJjb21wb25lbnQsCj4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIG1jLT5kYXRhKSkKClRoaXMgbGluZSBicmVhayBsb29rcyBr aW5kIG9mIHdlaXJkIHRvIG1lLAoKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJl dHVybiBjOwo+ICsgICAgICAgICAgICAgICB9IGVsc2UgaWYgKG1jLT5jb21wYXJlKGMtPmRldiwg bWMtPmRhdGEpKSB7Cj4gICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIGM7Cj4gKyAgICAg ICAgICAgICAgIH0KCkFsc28sIHdoeSBkb24ndCB5b3UgZG8KCmlmIChtYy0+Y29tcGFyZShjLT5k ZXYsIG1jLT5kYXRhKSB8fCAobWMtPmNvbXBhcmVfdHlwZWQgJiYKICAgIG1jLT5jb21wYXJlX3R5 cGVkKGMtPmRldiwgYy0+c3ViY29tcG9uZW50LCBtYy0+ZGF0YSkpKQogICAgICAgIHJldHVybiBj OwoKVGhlIG9ubHkgZGlmZmVyZW5jZSBpcyB0aGF0IC0+Y29tcGFyZSgpIHdpbGwgcnVuIGZpcnN0 IGFuZCBpZiBpdCBmaW5kcwphIG1hdGNoLCBjIHdpbGwgYmUgcmV0dXJuZWQgcmlnaHQgYXdheS4g IERvZXMgaXQgbWF0dGVyPwoKPiAgICAgICAgIH0KPgo+ICAgICAgICAgcmV0dXJuIE5VTEw7Cj4g QEAgLTE5Miw3ICsxOTksNyBAQCBzdGF0aWMgaW50IGZpbmRfY29tcG9uZW50cyhzdHJ1Y3QgbWFz dGVyICptYXN0ZXIpCj4gICAgICAgICAgICAgICAgIGlmIChtYXRjaC0+Y29tcGFyZVtpXS5jb21w b25lbnQpCj4gICAgICAgICAgICAgICAgICAgICAgICAgY29udGludWU7Cj4KPiAtICAgICAgICAg ICAgICAgYyA9IGZpbmRfY29tcG9uZW50KG1hc3RlciwgbWMtPmNvbXBhcmUsIG1jLT5kYXRhKTsK PiArICAgICAgICAgICAgICAgYyA9IGZpbmRfY29tcG9uZW50KG1hc3RlciwgbWMpOwo+ICAgICAg ICAgICAgICAgICBpZiAoIWMpIHsKPiAgICAgICAgICAgICAgICAgICAgICAgICByZXQgPSAtRU5Y SU87Cj4gICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7Cj4gQEAgLTMyNywzMCArMzM0LDEy IEBAIHN0YXRpYyBpbnQgY29tcG9uZW50X21hdGNoX3JlYWxsb2Moc3RydWN0IGRldmljZSAqZGV2 LAo+ICAgICAgICAgcmV0dXJuIDA7Cj4gIH0KPgo+IC0vKioKPiAtICogY29tcG9uZW50X21hdGNo X2FkZF9yZWxlYXNlIC0gYWRkIGEgY29tcG9uZW50IG1hdGNoIHdpdGggcmVsZWFzZSBjYWxsYmFj awo+IC0gKiBAbWFzdGVyOiBkZXZpY2Ugd2l0aCB0aGUgYWdncmVnYXRlIGRyaXZlcgo+IC0gKiBA bWF0Y2hwdHI6IHBvaW50ZXIgdG8gdGhlIGxpc3Qgb2YgY29tcG9uZW50IG1hdGNoZXMKPiAtICog QHJlbGVhc2U6IHJlbGVhc2UgZnVuY3Rpb24gZm9yIEBjb21wYXJlX2RhdGEKPiAtICogQGNvbXBh cmU6IGNvbXBhcmUgZnVuY3Rpb24gdG8gbWF0Y2ggYWdhaW5zdCBhbGwgY29tcG9uZW50cwo+IC0g KiBAY29tcGFyZV9kYXRhOiBvcGFxdWUgcG9pbnRlciBwYXNzZWQgdG8gdGhlIEBjb21wYXJlIGZ1 bmN0aW9uCj4gLSAqCj4gLSAqIFRoaXMgYWRkcyBhIG5ldyBjb21wb25lbnQgbWF0Y2ggdG8gdGhl IGxpc3Qgc3RvcmVkIGluIEBtYXRjaHB0ciwgd2hpY2ggdGhlCgoiVGhpcyIgYXBwZWFycyB0byBi ZSByZWR1bmRhbnQgaGVyZSAoYW5kIGluIHNvbWUgcGxhY2VzIGJlbG93IHRvbykuCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5n IGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=