All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Linux PCI <linux-pci@vger.kernel.org>,
	Linux ACPI <linux-acpi@vger.kernel.org>,
	Linux PM <linux-pm@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Bjorn Helgaas <helgaas@kernel.org>,
	Kai-Heng Feng <kai.heng.feng@canonical.com>,
	Utkarsh H Patel <utkarsh.h.patel@intel.com>,
	Koba Ko <koba.ko@canonical.com>
Subject: Re: [PATCH v2] PCI: PM: Add special case handling for PCIe device wakeup
Date: Thu, 29 Jul 2021 15:44:04 +0200	[thread overview]
Message-ID: <CAJZ5v0gUQHV_3A_nFR23M6K8sW6vdVzM3PgTT5yFY9jGUxm2RA@mail.gmail.com> (raw)
In-Reply-To: <YQKruWMmSXeH3GL6@lahna>

Hi Mika,

On Thu, Jul 29, 2021 at 3:23 PM Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
>
> Hi Rafael,
>
> On Wed, Jul 28, 2021 at 07:25:04PM +0200, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >
> > Some PCIe devices only support PME (Power Management Event) from
> > D3cold.  One example is the ASMedia xHCI controller:
> >
> >  11:00.0 USB controller: ASMedia Technology Inc. ASM1042A USB 3.0 Host Controller (prog-if 30 [XHCI])
> >    ...
> >    Capabilities: [78] Power Management version 3
> >        Flags: PMEClk- DSI- D1- D2- AuxCurrent=55mA PME(D0-,D1-,D2-,D3hot-,D3cold+)
> >        Status: D0 NoSoftRst+ PME-Enable- DSel=0 DScale=0 PME-
> >
> > In those cases, if the device is expected to generate wakeup events
> > from its final power state, pci_target_state() returns D0, which
> > prevents the PCIe hierarchy above the device from entering any
> > low-power states too, but the device cannot signal PME from D0
> > either.  However, if the device were allowed to go into D3hot, its
> > parent PCIe port and its ancestors would also be able to go into D3
> > and if any of them goes into D3cold, the device would end up in
> > D3cold too (as per the PCI PM spec v1.2, Table 6-1), in which case
> > it would be able to signal PME.
> >
> > This means that the system could be put into a lower-power
> > configuration while meeting the requirement to enable the device to
> > generate PME from the final state (which is not the case if the
> > device stays in D0 along with the entire hierarchy above it).
> >
> > In order to avoid missing that opportunity, extend pci_pme_capable()
> > to return 'true' in the special case when the target state is D3hot
> > and the device can only signal PME from D3cold and update
> > pci_target_state() to return the current target state if
> > pci_pme_capable() returns 'true' for it.
> >
> > This change can be regarded as a pci_target_state() fix, because that
> > function should ignore its 'wakeup' argument if signaling PME from
> > any power states shallower than the current candidate one (including
> > D0) is not supported.
> >
> > Link: https://lore.kernel.org/linux-pm/20210617123653.58640-1-mika.westerberg@linux.intel.com
> > Fixes: 666ff6f83e1d ("PCI/PM: Avoid using device_may_wakeup() for runtime PM")
> > Reported-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> > Reported-by: Utkarsh H Patel <utkarsh.h.patel@intel.com>
> > Reported-by: Koba Ko <koba.ko@canonical.com>
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Tried this now and it fixes the issue! Also checked with another device
> that actually supports PME from other states than D3cold and it also
> works (as expected).
>
> Feel free to add my,
>
> Tested-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Thank you!

However, after giving some more consideration to this, I've realized
that it may still not be the cleanest way to address the issue at
hand.

Namely, there are two things we want to happen: (1) pci_target_state()
should return the original candidate target state if 'wakeup' is true,
but the device cannot signal PME from any states shallower than the
original one (including D0) and (2) __pci_enable_wake() should call
pci_pme_active() for devices that support signaling PME from D3cold
regardless of whether or not they support signaling PME from the power
state passed to it (because a device may end up in D3cold as a result
of a transition of the hierarchy above it and PME should be signaled
then).  They are only related to each other because the PME signaling
capability is taken into account in both places, but in fact (1) has
nothing to do with D3cold (and making it effectively depend on whether
or not the device can signal PME from D3cold is somewhat artificial)
and (2) has nothing to do with what the target power state of the
device is.  And so each of these two things should be covered by a
separate patch.

Let me post an alternative patch series in accordance with the above.

      reply	other threads:[~2021-07-29 13:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-28 17:25 Rafael J. Wysocki
2021-07-29 13:23 ` Mika Westerberg
2021-07-29 13:44   ` Rafael J. Wysocki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJZ5v0gUQHV_3A_nFR23M6K8sW6vdVzM3PgTT5yFY9jGUxm2RA@mail.gmail.com \
    --to=rafael@kernel.org \
    --cc=helgaas@kernel.org \
    --cc=kai.heng.feng@canonical.com \
    --cc=koba.ko@canonical.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=rjw@rjwysocki.net \
    --cc=utkarsh.h.patel@intel.com \
    --subject='Re: [PATCH v2] PCI: PM: Add special case handling for PCIe device wakeup' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.