From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [V2 PATCH 3/5] device property: Introduces device_dma_is_coherent() Date: Thu, 7 May 2015 01:58:53 +0200 Message-ID: References: <1430838729-21572-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1430838729-21572-4-git-send-email-Suravee.Suthikulpanit@amd.com> <554AA94D.6020503@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: "Rafael J. Wysocki" , Len Brown , Catalin Marinas , Will Deacon , thomas.lendacky@amd.com, herbert@gondor.apana.org.au, David Miller , msalter@redhat.com, Hanjun Guo , Al Stone , Grant Likely , Arnd Bergmann , leo.duran@amd.com, "linux-arm-kernel@lists.infradead.org" , ACPI Devel Maling List , Linux Kernel Mailing List , "linaro-acpi@lists.linaro.org" , netdev@vger.kernel.org, linux-crypto@vger.kernel.org To: Suravee Suthikulanit Return-path: Received: from mail-wi0-f170.google.com ([209.85.212.170]:37223 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751219AbbEFX6z (ORCPT ); Wed, 6 May 2015 19:58:55 -0400 In-Reply-To: <554AA94D.6020503@amd.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Thu, May 7, 2015 at 1:52 AM, Suravee Suthikulanit wrote: > Rafael, > > Any comments on this patch? Well, as long as acpi_dma_is_coherent() does the right thing on all architectures, I have no objections. Thanks, Rafael > On 5/5/2015 10:12 AM, Suravee Suthikulpanit wrote: >> >> Currently, device drivers, which support both OF and ACPI, >> need to call two separate APIs, of_dma_is_coherent() and >> acpi_dma_is_coherent()) to determine device coherency attribute. >> >> This patch simplifies this process by introducing a new device >> property API, device_dma_is_coherent(), which calls the appropriate >> interface based on the booting architecture. >> >> Signed-off-by: Suravee Suthikulpanit >> --- >> drivers/base/property.c | 12 ++++++++++++ >> include/linux/property.h | 2 ++ >> 2 files changed, 14 insertions(+) >> >> diff --git a/drivers/base/property.c b/drivers/base/property.c >> index 1d0b116..8123c6e 100644 >> --- a/drivers/base/property.c >> +++ b/drivers/base/property.c >> @@ -14,6 +14,7 @@ >> #include >> #include >> #include >> +#include >> #include >> >> /** >> @@ -519,3 +520,14 @@ unsigned int device_get_child_node_count(struct >> device *dev) >> return count; >> } >> EXPORT_SYMBOL_GPL(device_get_child_node_count); >> + >> +bool device_dma_is_coherent(struct device *dev) >> +{ >> + if (IS_ENABLED(CONFIG_OF) && dev->of_node) >> + return of_dma_is_coherent(dev->of_node); >> + else if (has_acpi_companion(dev)) >> + return acpi_dma_is_coherent(acpi_node(dev->fwnode)); >> + >> + return false; >> +} >> +EXPORT_SYMBOL_GPL(device_dma_is_coherent); >> diff --git a/include/linux/property.h b/include/linux/property.h >> index de8bdf4..76ebde9 100644 >> --- a/include/linux/property.h >> +++ b/include/linux/property.h >> @@ -164,4 +164,6 @@ struct property_set { >> >> void device_add_property_set(struct device *dev, struct property_set >> *pset); >> >> +bool device_dma_is_coherent(struct device *dev); >> + >> #endif /* _LINUX_PROPERTY_H_ */ >> > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752075AbbEFX66 (ORCPT ); Wed, 6 May 2015 19:58:58 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:37223 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751219AbbEFX6z (ORCPT ); Wed, 6 May 2015 19:58:55 -0400 MIME-Version: 1.0 In-Reply-To: <554AA94D.6020503@amd.com> References: <1430838729-21572-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1430838729-21572-4-git-send-email-Suravee.Suthikulpanit@amd.com> <554AA94D.6020503@amd.com> Date: Thu, 7 May 2015 01:58:53 +0200 X-Google-Sender-Auth: eetyX5_6Ptyu9lCzjKXCgNwu4FQ Message-ID: Subject: Re: [V2 PATCH 3/5] device property: Introduces device_dma_is_coherent() From: "Rafael J. Wysocki" To: Suravee Suthikulanit Cc: "Rafael J. Wysocki" , Len Brown , Catalin Marinas , Will Deacon , thomas.lendacky@amd.com, herbert@gondor.apana.org.au, David Miller , msalter@redhat.com, Hanjun Guo , Al Stone , Grant Likely , Arnd Bergmann , leo.duran@amd.com, "linux-arm-kernel@lists.infradead.org" , ACPI Devel Maling List , Linux Kernel Mailing List , "linaro-acpi@lists.linaro.org" , netdev@vger.kernel.org, linux-crypto@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 7, 2015 at 1:52 AM, Suravee Suthikulanit wrote: > Rafael, > > Any comments on this patch? Well, as long as acpi_dma_is_coherent() does the right thing on all architectures, I have no objections. Thanks, Rafael > On 5/5/2015 10:12 AM, Suravee Suthikulpanit wrote: >> >> Currently, device drivers, which support both OF and ACPI, >> need to call two separate APIs, of_dma_is_coherent() and >> acpi_dma_is_coherent()) to determine device coherency attribute. >> >> This patch simplifies this process by introducing a new device >> property API, device_dma_is_coherent(), which calls the appropriate >> interface based on the booting architecture. >> >> Signed-off-by: Suravee Suthikulpanit >> --- >> drivers/base/property.c | 12 ++++++++++++ >> include/linux/property.h | 2 ++ >> 2 files changed, 14 insertions(+) >> >> diff --git a/drivers/base/property.c b/drivers/base/property.c >> index 1d0b116..8123c6e 100644 >> --- a/drivers/base/property.c >> +++ b/drivers/base/property.c >> @@ -14,6 +14,7 @@ >> #include >> #include >> #include >> +#include >> #include >> >> /** >> @@ -519,3 +520,14 @@ unsigned int device_get_child_node_count(struct >> device *dev) >> return count; >> } >> EXPORT_SYMBOL_GPL(device_get_child_node_count); >> + >> +bool device_dma_is_coherent(struct device *dev) >> +{ >> + if (IS_ENABLED(CONFIG_OF) && dev->of_node) >> + return of_dma_is_coherent(dev->of_node); >> + else if (has_acpi_companion(dev)) >> + return acpi_dma_is_coherent(acpi_node(dev->fwnode)); >> + >> + return false; >> +} >> +EXPORT_SYMBOL_GPL(device_dma_is_coherent); >> diff --git a/include/linux/property.h b/include/linux/property.h >> index de8bdf4..76ebde9 100644 >> --- a/include/linux/property.h >> +++ b/include/linux/property.h >> @@ -164,4 +164,6 @@ struct property_set { >> >> void device_add_property_set(struct device *dev, struct property_set >> *pset); >> >> +bool device_dma_is_coherent(struct device *dev); >> + >> #endif /* _LINUX_PROPERTY_H_ */ >> > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: rafael@kernel.org (Rafael J. Wysocki) Date: Thu, 7 May 2015 01:58:53 +0200 Subject: [V2 PATCH 3/5] device property: Introduces device_dma_is_coherent() In-Reply-To: <554AA94D.6020503@amd.com> References: <1430838729-21572-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1430838729-21572-4-git-send-email-Suravee.Suthikulpanit@amd.com> <554AA94D.6020503@amd.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, May 7, 2015 at 1:52 AM, Suravee Suthikulanit wrote: > Rafael, > > Any comments on this patch? Well, as long as acpi_dma_is_coherent() does the right thing on all architectures, I have no objections. Thanks, Rafael > On 5/5/2015 10:12 AM, Suravee Suthikulpanit wrote: >> >> Currently, device drivers, which support both OF and ACPI, >> need to call two separate APIs, of_dma_is_coherent() and >> acpi_dma_is_coherent()) to determine device coherency attribute. >> >> This patch simplifies this process by introducing a new device >> property API, device_dma_is_coherent(), which calls the appropriate >> interface based on the booting architecture. >> >> Signed-off-by: Suravee Suthikulpanit >> --- >> drivers/base/property.c | 12 ++++++++++++ >> include/linux/property.h | 2 ++ >> 2 files changed, 14 insertions(+) >> >> diff --git a/drivers/base/property.c b/drivers/base/property.c >> index 1d0b116..8123c6e 100644 >> --- a/drivers/base/property.c >> +++ b/drivers/base/property.c >> @@ -14,6 +14,7 @@ >> #include >> #include >> #include >> +#include >> #include >> >> /** >> @@ -519,3 +520,14 @@ unsigned int device_get_child_node_count(struct >> device *dev) >> return count; >> } >> EXPORT_SYMBOL_GPL(device_get_child_node_count); >> + >> +bool device_dma_is_coherent(struct device *dev) >> +{ >> + if (IS_ENABLED(CONFIG_OF) && dev->of_node) >> + return of_dma_is_coherent(dev->of_node); >> + else if (has_acpi_companion(dev)) >> + return acpi_dma_is_coherent(acpi_node(dev->fwnode)); >> + >> + return false; >> +} >> +EXPORT_SYMBOL_GPL(device_dma_is_coherent); >> diff --git a/include/linux/property.h b/include/linux/property.h >> index de8bdf4..76ebde9 100644 >> --- a/include/linux/property.h >> +++ b/include/linux/property.h >> @@ -164,4 +164,6 @@ struct property_set { >> >> void device_add_property_set(struct device *dev, struct property_set >> *pset); >> >> +bool device_dma_is_coherent(struct device *dev); >> + >> #endif /* _LINUX_PROPERTY_H_ */ >> > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html