From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39526C432C0 for ; Thu, 28 Nov 2019 16:25:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0BAE3217D7 for ; Thu, 28 Nov 2019 16:25:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574958315; bh=S+qh78N/QhmMFqJ0Zt5/n/xJ/qP/K/5l4PEcfnVInm4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=MF/yQyosTNRzoVB/xzJzR6YXBS/uVNRbDo6cp7r3BIdVwUpo8kJ5O361t0ezGWSzx elllCfBzteK50zmF+p1ab7ET8xlOmhBY8yeRleKhsLQ7KtBcR5OrR8E8ZX2Lhc2wSn vjoCthrTa1jdoijtCdpHFVcKLjR+PZvFX/RIVNmY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726773AbfK1QZO (ORCPT ); Thu, 28 Nov 2019 11:25:14 -0500 Received: from mail-ot1-f46.google.com ([209.85.210.46]:35149 "EHLO mail-ot1-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726764AbfK1QZO (ORCPT ); Thu, 28 Nov 2019 11:25:14 -0500 Received: by mail-ot1-f46.google.com with SMTP id o9so1533383ote.2 for ; Thu, 28 Nov 2019 08:25:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SbKcS5nX0OzcSGYavRtvBzlsW68ZVjtxgaajveQ8KOo=; b=WEB4BiBcWfq33hIqJWTs6Zp9oVIdu6x1+iKbXFo082bJllodMyrMAV9fjJ6Tvhgkuf 9v6UY1+A2NixfxFjdOcN3cglThw0sx79Kuewl4bmdELOIdBgxbKaWVs1RcctPBSRcLXV AVPLWMzdMwZgKBk2cLUnIvUcIY2ZhQEQ/nAQnUrxENxy0d0H2BXyrLrJsO5tNjFqxDCj zhwsExORt2am7knjAZeJJO2KMmHm2gxakRJwPY7AD+q8MURKQmlL7Sz2MuPdqYaa6Uu2 /lJTCBIlNjyxWCthH5zbn2RF+BBSsH67NQgW81yz1LvoduZqBNfUxhaowtFJeKhNM9F5 wo2Q== X-Gm-Message-State: APjAAAUv0ta313+vefaqbQ7VDKgfq+zDw0FKoHZqiF9r7OnkjFjoIljY WQkAXnuFjgC89pt4i2Pfky8VADZjmeB/ts8L+L0= X-Google-Smtp-Source: APXvYqyf/CsS8OQxxHLhMjO6Mt3Mk7/ZMjU7jf4Oxl0siNGnLX/ktsUyKCOeXMN7jyRHyjBm+HO95aptG6PoMBYEi70= X-Received: by 2002:a9d:7d01:: with SMTP id v1mr7606667otn.167.1574958313389; Thu, 28 Nov 2019 08:25:13 -0800 (PST) MIME-Version: 1.0 References: <12933162.9b7K5rSXZx@kreacher> In-Reply-To: From: "Rafael J. Wysocki" Date: Thu, 28 Nov 2019 17:25:01 +0100 Message-ID: Subject: Re: Help me fix a regression caused by 56b9918490 (PM: sleep: Simplify suspend-to-idle control flow) To: "Kenneth R. Crudup" Cc: "Rafael J. Wysocki" , "Rafael J. Wysocki" , Rafael Wysocki , Linux PM Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Wed, Nov 27, 2019 at 11:30 PM Kenneth R. Crudup wrote: > > > > > If all "ec_no_wakeup=1" actually does is silently ignore EC wakeup events, > > > then I'll stick with it. > > > Yes, that's all it does. > > Thanks. > > BTW, I'm calling it on that patch- it's been working all day long. And with > ec_no_wakeup=1 no spurious wakeups, either: > > ---- > $ fgrep "suspend e" /var/log/syslog > ... > Nov 26 19:36:46 hp-x360n kernel: [ 995.519483] PM: suspend entry (s2idle) > Nov 27 06:56:44 hp-x360n kernel: [41793.786663] PM: suspend exit > ---- > > Sadly I lost ~9% battery over that period due to "modern" suspend, but at least > it's been cool the last few times I've taken it out of the bag. Wish I could > find out what's left powered up, though. > > And finally, last questions about the EC: > > - Is it possible to query it once it's awakened the system to find out exactly why? That's what the current code does, but it also processes everything the EC wants it to process at that time in case there are real system wakeup events hidden in that (which is the case on some systems). > - Is it possible to have the EC mask/ignore certain of those reasons? Yes, it is, at least in principle, but some extra information is necessary for that, like for example which Notify() targets to ignore, and that's rather system-specific. BTW, it should be possible to enable dynamic debug in ec.c and collect some extra output from it to see what the EC is doing, for example, when spurious wakeups occur. > Thanks for all your hard work, YW BTW2, I have a real (non-debug) patch for the $subject issue in the works, will post it later today or tomorrow, most likely.