From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 597A7C433ED for ; Tue, 11 May 2021 10:52:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2BBAD61370 for ; Tue, 11 May 2021 10:52:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231524AbhEKKxa (ORCPT ); Tue, 11 May 2021 06:53:30 -0400 Received: from mail-oi1-f171.google.com ([209.85.167.171]:38649 "EHLO mail-oi1-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231514AbhEKKxY (ORCPT ); Tue, 11 May 2021 06:53:24 -0400 Received: by mail-oi1-f171.google.com with SMTP id z3so17406210oib.5 for ; Tue, 11 May 2021 03:52:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LJ6/iEx981OsThdHsoNHle4saMckTPoLWOXMh4tuyVg=; b=l3QQiy4IrhBEfgn6eqEUUN24O9NK0mW65P9gaLYfMRlwBbO9wCL43jFqrH7BOGmn+a PoUp/YTK87Zy+/rZ+B7oOciddMr10V6y738X3eEpFpN1ahI+maTEjDcwAru5IQ38cv1y ln8gA9z+OrdaFj8XlmtEtrmsN4Yt9a557eyFy5WeXA1jvLgpgphJEsWVWlpEqaLMewf5 byYImgcOEwYY4x11N0Uce3Mxu3Ezzfh2oYE3VAt4VY/sfz7YGiEwMPOUrtGXgVTBCFna PUJzSPLKlfRDuXpuL8vlYQcmkl0vzNqmZFXJrUBim3VTPcpPcVTTR0gxRQO3URh72JjL Ixjw== X-Gm-Message-State: AOAM532ZrwCdl2WbRVKXn8rdnfzqvqReULchn58QnRURtuHnF3cN55/9 hCl8ksEqywkmP7RLiyuE0YYp2mjlGuosiOAuPcQ= X-Google-Smtp-Source: ABdhPJwZq8P+r2q3I4vQUuyKzAJKw8MSL1bi+Xg+MXsSXXSqi5MCoC4NztrTDQcz1iZ1sR8OfL6FDUIj4iRIHoC+hM4= X-Received: by 2002:aca:1815:: with SMTP id h21mr2513827oih.69.1620730336930; Tue, 11 May 2021 03:52:16 -0700 (PDT) MIME-Version: 1.0 References: <20210508074118.1621729-1-swboyd@chromium.org> In-Reply-To: From: "Rafael J. Wysocki" Date: Tue, 11 May 2021 12:52:06 +0200 Message-ID: Subject: Re: [PATCH] component: Move host device to end of device lists on binding To: Stephen Boyd Cc: Daniel Vetter , Greg Kroah-Hartman , Linux Kernel Mailing List , "Rafael J. Wysocki" , Russell King , Rob Clark , dri-devel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 10, 2021 at 9:08 PM Stephen Boyd wrote: [cut] > > > > > > I will try it, but then I wonder about things like system wide > > > suspend/resume too. The drm encoder chain would need to reimplement the > > > logic for system wide suspend/resume so that any PM ops attached to the > > > msm device run in the correct order. Right now the bridge PM ops will > > > run, the i2c bus PM ops will run, and then the msm PM ops will run. > > > After this change, the msm PM ops will run, the bridge PM ops will run, > > > and then the i2c bus PM ops will run. It feels like that could be a > > > problem if we're suspending the DSI encoder while the bridge is still > > > active. > > > > Yup suspend/resume has the exact same problem as shutdown. > > I think suspend/resume has the exact opposite problem. At least I think > the correct order is to suspend the bridge, then the encoder, i.e. DSI, > like is happening today. It looks like drm_atomic_helper_shutdown() > operates from the top down when we want bottom up? I admit I have no > idea what is supposed to happen here. Why would the system-wide suspend ordering be different from the shutdown ordering? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 937E1C433B4 for ; Tue, 11 May 2021 10:52:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 37F4D61132 for ; Tue, 11 May 2021 10:52:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 37F4D61132 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3941D6EA11; Tue, 11 May 2021 10:52:19 +0000 (UTC) Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com [209.85.167.169]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8B2516EA11 for ; Tue, 11 May 2021 10:52:17 +0000 (UTC) Received: by mail-oi1-f169.google.com with SMTP id b25so13399392oic.0 for ; Tue, 11 May 2021 03:52:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LJ6/iEx981OsThdHsoNHle4saMckTPoLWOXMh4tuyVg=; b=eDFl1PtVchg7A9aLJmwUDLU+T6zIk2rdhEnQmrzy/LcuvdJxCbNAKUIby5pWlUE2Lr N2emqE5ziK/GWeiS48dW3MCD/gcJUxjSthLtK/+rCfe0VCDJnbR3TaPA1LbZA1nO8eyp LislCVN1fzbUWBM3j+YHBGMCCaDzJJ10JeKODaAOoZeuOIJVaHHiJL5byPmq706xGQjS 0Fr91GPjA0mgqUWAUFH0n8gy5FcjUciL6JRH+qLtxVcB1A3p1ZXBp8I8HR2B4mFfE6vE DvdZetzOLptZuJSoQoAlEzH7VJ5RPdSr4n44WE66op7dXF+Cb+bEGDdQ2io/eao3H6Yn ThCw== X-Gm-Message-State: AOAM5333ev/LZDLedEHuW9y/a9iBqOMKouMviQ1Tc4LYDpG2nX2UGq5d VvlUfq9i4FEg7qQh0xBiNStajtCj7I46DwGUVwQ= X-Google-Smtp-Source: ABdhPJwZq8P+r2q3I4vQUuyKzAJKw8MSL1bi+Xg+MXsSXXSqi5MCoC4NztrTDQcz1iZ1sR8OfL6FDUIj4iRIHoC+hM4= X-Received: by 2002:aca:1815:: with SMTP id h21mr2513827oih.69.1620730336930; Tue, 11 May 2021 03:52:16 -0700 (PDT) MIME-Version: 1.0 References: <20210508074118.1621729-1-swboyd@chromium.org> In-Reply-To: From: "Rafael J. Wysocki" Date: Tue, 11 May 2021 12:52:06 +0200 Message-ID: Subject: Re: [PATCH] component: Move host device to end of device lists on binding To: Stephen Boyd Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Rafael J. Wysocki" , Greg Kroah-Hartman , Linux Kernel Mailing List , dri-devel , Russell King Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, May 10, 2021 at 9:08 PM Stephen Boyd wrote: [cut] > > > > > > I will try it, but then I wonder about things like system wide > > > suspend/resume too. The drm encoder chain would need to reimplement the > > > logic for system wide suspend/resume so that any PM ops attached to the > > > msm device run in the correct order. Right now the bridge PM ops will > > > run, the i2c bus PM ops will run, and then the msm PM ops will run. > > > After this change, the msm PM ops will run, the bridge PM ops will run, > > > and then the i2c bus PM ops will run. It feels like that could be a > > > problem if we're suspending the DSI encoder while the bridge is still > > > active. > > > > Yup suspend/resume has the exact same problem as shutdown. > > I think suspend/resume has the exact opposite problem. At least I think > the correct order is to suspend the bridge, then the encoder, i.e. DSI, > like is happening today. It looks like drm_atomic_helper_shutdown() > operates from the top down when we want bottom up? I admit I have no > idea what is supposed to happen here. Why would the system-wide suspend ordering be different from the shutdown ordering?